Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Node.Normalize() acts on all descendants #2221

Merged
merged 1 commit into from Apr 24, 2014
Merged

Ensure Node.Normalize() acts on all descendants #2221

merged 1 commit into from Apr 24, 2014

Conversation

@hmac
Copy link
Contributor

hmac commented Apr 24, 2014

Fixes #2170 by recursively calling normalize() on all children that aren't text nodes.
@hmac
Ensure Node.Normalize() acts on all descendants by recursively callin…
Loading status checks…
9e1f63e 
…g it on all non-text child nodes.
@highfive
Copy link

highfive commented Apr 24, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 24, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1375

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 9e1f63e Apr 24, 2014

saw approval from jdm
at https://github.com/hazz/servo/commit/9e1f63e147b65c329b5bc77785cf34fff442ec59

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 24, 2014

merging hazz/servo/normalize = 9e1f63e into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 24, 2014

hazz/servo/normalize = 9e1f63e merged ok, testing candidate = b193767

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 24, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1272
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1226

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 24, 2014

fast-forwarding master to auto = b193767
bors-servo pushed a commit that referenced this pull request Apr 24, 2014
bors-servo
auto merge of #2221 : hazz/servo/normalize, r=jdm
b193767 
Fixes #2170 by recursively calling `normalize()` on all children that aren't text nodes.
@bors-servo bors-servo closed this Apr 24, 2014
@bors-servo bors-servo merged commit 9e1f63e into servo:master Apr 24, 2014
1 check passed
1 check passed
default all tests passed
Ms2ger added a commit to Ms2ger/servo that referenced this pull request May 2, 2014
@Ms2ger
Update web-platform-tests expectations.
0a47659 
The first 11 tests in Event-constructors.html were fixed in servo#2194; the
remaining failure is servo#2173. Node-normalize.html was fixed in servo#2221.
@Ms2ger Ms2ger mentioned this pull request May 2, 2014
Merged
bors-servo pushed a commit that referenced this pull request May 2, 2014
bors-servo
auto merge of #2294 : Ms2ger/servo/update-wpt, r=jdm
9b6b552 
The first 11 tests in Event-constructors.html were fixed in #2194; the
remaining failure is #2173. Node-normalize.html was fixed in #2221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Node.normalize() should normalize all descendants, not just children
4 participants
@hmac @highfive @hoppipolla-critic-bot @bors-servo
You can’t perform that action at this time.