Implement NavigationPreloadManager for ServiceWorker #22218

CYBAI · 2018-11-18T16:49:19Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix part of #19302 .
There are tests for these changes OR
These changes do not require tests because _____

This change is

highfive · 2018-11-18T16:49:23Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/mod.rs, components/script/dom/webidls/NavigationPreloadManager.webidl, components/script/dom/webidls/ServiceWorkerRegistration.webidl, components/script/dom/navigationpreloadmanager.rs, components/script/dom/serviceworkerregistration.rs
@KiChjang: components/script/dom/mod.rs, components/script/dom/webidls/NavigationPreloadManager.webidl, components/script/dom/webidls/ServiceWorkerRegistration.webidl, components/script/dom/navigationpreloadmanager.rs, components/script/dom/serviceworkerregistration.rs

highfive · 2018-11-18T16:49:25Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

CYBAI · 2018-11-18T16:49:55Z

@bors-servo try=wpt

bors-servo · 2018-11-18T16:49:59Z

⌛ Trying commit aaf1034 with merge 16c4c6c...


        Auto merge of #22218 - CYBAI:sw-up-to-date, r=<try>

Implement NavigationPreloadManager for ServiceWorker --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 . - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22218)

bors-servo · 2018-11-18T17:16:51Z

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

CYBAI · 2018-11-19T15:20:22Z

@bors-servo try=wpt

bors-servo · 2018-11-19T15:20:29Z

⌛ Trying commit 159bb38 with merge 1214fef...


        Auto merge of #22218 - CYBAI:sw-up-to-date, r=<try>

Implement NavigationPreloadManager for ServiceWorker --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 . - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22218)

bors-servo · 2018-11-19T15:46:57Z

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

nox · 2018-11-27T09:27:23Z

components/script/dom/webidls/ServiceWorkerRegistration.webidl

@@ -8,7 +8,7 @@ interface ServiceWorkerRegistration : EventTarget {
  readonly attribute ServiceWorker? installing;
  readonly attribute ServiceWorker? waiting;
  readonly attribute ServiceWorker? active;
-  // [SameObject] readonly attribute NavigationPreloadManager navigationPreload;
+  [SameObject] readonly attribute NavigationPreloadManager navigationPreload;


What happens if the pref from Pref="dom.serviceworker.enabled" on the interface isn't enabled? And shouldn't that preference be set when running tests related to that feature?

Ah, I misunderstood the config for mozilla wpt was for web-platform-tests which is located at

servo/tests/wpt/mozilla/meta/mozilla/service-workers/__dir__.ini

Line 1 in 524bd72

prefs: ["dom.serviceworker.enabled:true"]

Let me update the PR to turn on the config for web-platform-tests for SW! Thanks for the good catch!

There's probably no real point; we don't implement enough of the SW API to make tests run to completion.

@jdm Yes, if we turned on SW tests, we'll have other FAIL cases. Or maybe let me keep working on it and turn it on when we have basic implementation for SW? cc @nox

Actually, it's possible that we might be able to get meaningful results out of the upstream SW tests now. One reason we created our own tests was that:

we didn't support promises yet

we didn't support HTTPS tests

Both of those have been fixed, so there's no good reason not to start relying on the upstream tests that require both of those features.

It sounds reasonable for me to start relying on upstream tests if we've already supported these 2 points. How about letting me turn SW upstream tests on in another PR?

Opened at #22278 !


        Auto merge of #22278 - CYBAI:turn-sw-wpt-on, r=<try>

Turn on upstream SW wpt tests Generated these metadata with following command ```sh $ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers $ ./mach update-wpt update.log ``` Ref: #22218 (comment) --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] This PR will turn on `ServiceWorker` for upstream WPT tests  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22278)


        Auto merge of #22278 - CYBAI:turn-sw-wpt-on, r=jdm

Turn on upstream SW wpt tests Generated these metadata with following command ```sh $ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers $ ./mach update-wpt update.log ``` Ref: #22218 (comment) --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] This PR will turn on `ServiceWorker` for upstream WPT tests  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22278)

CYBAI · 2018-11-28T13:53:10Z

@bors-servo try=wpt

Just rebased to latest master but I think we need more implementation for SW so that we can have more PASS tests

bors-servo · 2018-11-28T13:53:17Z

⌛ Trying commit e2cb292 with merge c97f093...


        Auto merge of #22218 - CYBAI:sw-up-to-date, r=<try>

Implement NavigationPreloadManager for ServiceWorker --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 . - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22218)

bors-servo · 2018-11-28T14:25:28Z

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

jdm

Looks good overall!

components/script/dom/navigationpreloadmanager.rs

components/script/dom/serviceworkerregistration.rs

components/script/dom/navigationpreloadmanager.rs


        Introduce NavigationPreloadManager for ServiceWorkerRegistration

CYBAI · 2018-12-09T11:15:41Z

@bors-servo try=wpt

bors-servo · 2018-12-09T11:15:47Z

⌛ Trying commit 235fb59 with merge 3190167...


        Auto merge of #22218 - CYBAI:sw-up-to-date, r=<try>

Implement NavigationPreloadManager for ServiceWorker --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 . - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22218)

bors-servo · 2018-12-09T11:45:48Z

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

jdm · 2018-12-09T19:43:48Z

@bors-servo r+

bors-servo · 2018-12-09T19:43:48Z

📌 Commit 235fb59 has been approved by jdm

bors-servo · 2018-12-09T20:40:05Z

⌛ Testing commit 235fb59 with merge 0a33f86...


        Auto merge of #22218 - CYBAI:sw-up-to-date, r=jdm

Implement NavigationPreloadManager for ServiceWorker --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 . - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22218)

bors-servo · 2018-12-09T21:26:47Z

💔 Test failed - mac-rel-css1

jdm · 2018-12-10T00:21:27Z

@bors-servo retry

restarted servo-mac8

bors-servo · 2018-12-10T00:21:33Z

⌛ Testing commit 235fb59 with merge ddfc799...


        Auto merge of #22218 - CYBAI:sw-up-to-date, r=jdm

Implement NavigationPreloadManager for ServiceWorker --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 . - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22218)

bors-servo · 2018-12-10T01:31:50Z

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing ddfc799 to master...

highfive assigned paulrouget Nov 18, 2018

highfive added the S-awaiting-review label Nov 18, 2018

CYBAI mentioned this pull request Nov 18, 2018

Make Service Worker implementation up-to-date #19302

Closed

5 of 6 tasks complete

CYBAI force-pushed the CYBAI:sw-up-to-date branch from aaf1034 to 159bb38 Nov 19, 2018

paulrouget assigned asajeffrey and unassigned paulrouget Nov 21, 2018

nox reviewed Nov 27, 2018

View changes

CYBAI mentioned this pull request Nov 27, 2018

Turn on upstream SW wpt tests #22278

Merged

3 of 3 tasks complete

CYBAI force-pushed the CYBAI:sw-up-to-date branch from 159bb38 to e2cb292 Nov 28, 2018

jdm requested changes Nov 28, 2018

View changes

jdm added S-needs-code-changes and removed S-awaiting-review labels Nov 28, 2018

jdm assigned jdm and unassigned asajeffrey Nov 28, 2018

jdm requested changes Dec 6, 2018

View changes

components/script/dom/navigationpreloadmanager.rs Outdated Show resolved Hide resolved

components/script/dom/navigationpreloadmanager.rs Outdated Show resolved Hide resolved

jdm added S-needs-code-changes and removed S-awaiting-review labels Dec 6, 2018

CYBAI force-pushed the CYBAI:sw-up-to-date branch from b8b1100 to 4073495 Dec 8, 2018

highfive added S-awaiting-review and removed S-needs-code-changes labels Dec 8, 2018

Introduce NavigationPreloadManager for ServiceWorkerRegistration

Loading status checks…

235fb59

CYBAI force-pushed the CYBAI:sw-up-to-date branch from 4073495 to 235fb59 Dec 8, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 9, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 9, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 10, 2018

bors-servo merged commit 235fb59 into servo:master Dec 10, 2018
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Dec 10, 2018

CYBAI deleted the CYBAI:sw-up-to-date branch Dec 10, 2018

servo / servo

Implement NavigationPreloadManager for ServiceWorker #22218

Implement NavigationPreloadManager for ServiceWorker #22218

CYBAI commented Nov 18, 2018 •

edited by SimonSapin

highfive commented Nov 18, 2018

highfive commented Nov 18, 2018

CYBAI commented Nov 18, 2018

bors-servo commented Nov 18, 2018

bors-servo commented Nov 18, 2018

CYBAI commented Nov 19, 2018

bors-servo commented Nov 19, 2018

bors-servo commented Nov 19, 2018

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

CYBAI commented Nov 28, 2018

bors-servo commented Nov 28, 2018

bors-servo commented Nov 28, 2018

jdm left a comment

CYBAI commented Dec 9, 2018

bors-servo commented Dec 9, 2018

bors-servo commented Dec 9, 2018

jdm commented Dec 9, 2018

bors-servo commented Dec 9, 2018

bors-servo commented Dec 9, 2018

bors-servo commented Dec 9, 2018

jdm commented Dec 10, 2018

bors-servo commented Dec 10, 2018

bors-servo commented Dec 10, 2018

servo / servo

Join GitHub today

Implement NavigationPreloadManager for ServiceWorker #22218

Implement NavigationPreloadManager for ServiceWorker #22218

Conversation

CYBAI commented Nov 18, 2018 • edited by SimonSapin

highfive commented Nov 18, 2018

highfive commented Nov 18, 2018

CYBAI commented Nov 18, 2018

bors-servo commented Nov 18, 2018

bors-servo commented Nov 18, 2018

CYBAI commented Nov 19, 2018

bors-servo commented Nov 19, 2018

bors-servo commented Nov 19, 2018

This comment has been minimized.

nox Nov 27, 2018

This comment has been minimized.

CYBAI Nov 27, 2018

This comment has been minimized.

jdm Nov 27, 2018

This comment has been minimized.

CYBAI Nov 27, 2018

This comment has been minimized.

jdm Nov 27, 2018 • edited

This comment has been minimized.

CYBAI Nov 27, 2018

This comment has been minimized.

jdm Nov 27, 2018

This comment has been minimized.

CYBAI Nov 27, 2018

CYBAI commented Nov 28, 2018

bors-servo commented Nov 28, 2018

bors-servo commented Nov 28, 2018

jdm left a comment

CYBAI commented Dec 9, 2018

bors-servo commented Dec 9, 2018

bors-servo commented Dec 9, 2018

jdm commented Dec 9, 2018

bors-servo commented Dec 9, 2018

bors-servo commented Dec 9, 2018

bors-servo commented Dec 9, 2018

jdm commented Dec 10, 2018

bors-servo commented Dec 10, 2018

bors-servo commented Dec 10, 2018

CYBAI commented Nov 18, 2018 •

edited by SimonSapin

jdm Nov 27, 2018 •

edited