Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure async scene is built before capturing reftest output. #22219
Conversation
highfive
commented
Nov 18, 2018
|
Heads up! This PR modifies the following files:
|
|
r? @gw3583 |
|
Humbug, I can still reproduce #22062 with this patch applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 18, 2018
•
edited by SimonSapin
I strongly suspect that this will solve the underlying cause of #22062 - if the async scene builder isn't done, the compositor will take a screenshot of an empty gl framebuffer, which would be a big back square. I'm going to keep doing my due diligence while bisecting the relevant WR changes, but until then this will definitely not hurt us.
This change is