Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #22221

Merged
merged 6 commits into from Nov 27, 2018
Merged

Update dependencies #22221

merged 6 commits into from Nov 27, 2018

Conversation

@Eijebong
Copy link
Member

Eijebong commented Nov 18, 2018

Those are all easy and unrelated dependency updates, hence the single PR


This change is Reviewable

@highfive
Copy link

highfive commented Nov 18, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml, components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml
  • @emilio: components/style/Cargo.toml
@highfive
Copy link

highfive commented Nov 18, 2018

warning Warning warning

  • These commits modify net, style, gfx, and script code, but no tests are modified. Please consider adding a test!
@Eijebong
Copy link
Member Author

Eijebong commented Nov 18, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2018

Trying commit 2a8af39 with merge d82077a...

bors-servo added a commit that referenced this pull request Nov 18, 2018
Update dependencies

Those are all easy and unrelated dependency updates, hence the single PR
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2018

💔 Test failed - mac-rel-wpt3

@Eijebong
Copy link
Member Author

Eijebong commented Nov 18, 2018

Mhhh I guess the openssl changes are to blame here

@Eijebong
Copy link
Member Author

Eijebong commented Nov 18, 2018

Actually... It passed on linux-wpt.

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2018

Trying commit 2a8af39 with merge 22f9245...

bors-servo added a commit that referenced this pull request Nov 18, 2018
Update dependencies

Those are all easy and unrelated dependency updates, hence the single PR

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22221)
<!-- Reviewable:end -->
@emilio
emilio approved these changes Nov 18, 2018
Copy link
Member

emilio left a comment

r=me, assuming try is happy

@emilio
Copy link
Member

emilio commented Nov 18, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2018

📌 Commit 2a8af39 has been approved by emilio

@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2018

Testing commit 2a8af39 with merge 657248b...

bors-servo added a commit that referenced this pull request Nov 18, 2018
Update dependencies

Those are all easy and unrelated dependency updates, hence the single PR

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22221)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2018

💔 Test failed - mac-rel-wpt3

@Eijebong
Copy link
Member Author

Eijebong commented Nov 18, 2018

Ok, this isn't intermittent but only happens on mac. I'll have a look tomorrow

@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2018

The latest upstream changes (presumably #22200) made this pull request unmergeable. Please resolve the merge conflicts.

@atouchet
Copy link
Contributor

atouchet commented Nov 22, 2018

hyper 0.12.16 is now out.

@nox
Copy link
Member

nox commented Nov 27, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

📌 Commit dafa2cf has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

Testing commit dafa2cf with merge ef1b6ee...

bors-servo added a commit that referenced this pull request Nov 27, 2018
Update dependencies

Those are all easy and unrelated dependency updates, hence the single PR

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22221)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

💔 Test failed - linux-rel-wpt

@CYBAI
Copy link
Collaborator

CYBAI commented Nov 27, 2018

@bors-servo retry

{"status": "FAIL", "group": "default", "message": "/_mozilla/css/inline_block_parent_padding_a.html 495641fc705b6af91aa9ff0d3235cd2c5342179c\n/_mozilla/css/inline_block_parent_padding_ref.html 4e6ec2a4e7504e5c4bb739eb4fad793251d3180f\nTesting 495641fc705b6af91aa9ff0d3235cd2c5342179c == 4e6ec2a4e7504e5c4bb739eb4fad793251d3180f", "stack": null, "subtest": null, "test": "/_mozilla/css/inline_block_parent_padding_a.html", "line": 31791, "action": "test_result", "expected": "PASS"}
@jdm
Copy link
Member

jdm commented Nov 27, 2018

That failure was #22062 for the record.

bors-servo added a commit that referenced this pull request Nov 27, 2018
Update dependencies

Those are all easy and unrelated dependency updates, hence the single PR

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22221)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

Testing commit dafa2cf with merge 482923c...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2018

💔 Test failed - mac-rel-css1

@jdm
Copy link
Member

jdm commented Nov 27, 2018

@bors-servo bors-servo merged commit dafa2cf into servo:master Nov 27, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.