New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward WebDriver CompositionEvent #22224

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
5 participants
@pyfisch
Contributor

pyfisch commented Nov 19, 2018

Dispatch composition events in JS.
Insert characters from composition events to text input.

CompositionEvents currently can only be
created by WebDriver and not by embedders.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Nov 19, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmltextareaelement.rs, components/script/dom/document.rs, components/script/dom/compositionevent.rs, components/webdriver_server/lib.rs, components/script/Cargo.toml and 4 more
  • @cbrewster: components/constellation/constellation.rs
  • @jgraham: components/webdriver_server/lib.rs
  • @paulrouget: components/constellation/constellation.rs
  • @KiChjang: components/script/dom/htmltextareaelement.rs, components/script/dom/document.rs, components/script/dom/compositionevent.rs, components/script/Cargo.toml, components/script/script_thread.rs and 3 more
@highfive

This comment has been minimized.

highfive commented Nov 19, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@pyfisch pyfisch force-pushed the pyfisch:composition-webdriver branch from 4d70155 to df714d0 Nov 19, 2018

@jdm

This comment has been minimized.

Member

jdm commented Nov 19, 2018

r? @nox

@highfive highfive assigned nox and unassigned jdm Nov 19, 2018

@pyfisch pyfisch force-pushed the pyfisch:composition-webdriver branch from df714d0 to cf69fa7 Nov 19, 2018

Forward WebDriver CompositionEvent
Dispatch composition events in JS.
Insert characters from composition events to text input.

CompositionEvents currently can only be
created by WebDriver and not by embedders.

@pyfisch pyfisch force-pushed the pyfisch:composition-webdriver branch from cf69fa7 to b936fea Nov 19, 2018

@nox

This comment has been minimized.

Member

nox commented Nov 20, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 20, 2018

📌 Commit b936fea has been approved by nox

bors-servo added a commit that referenced this pull request Nov 20, 2018

Auto merge of #22224 - pyfisch:composition-webdriver, r=nox
Forward WebDriver CompositionEvent

Dispatch composition events in JS.
Insert characters from composition events to text input.

CompositionEvents currently can only be
created by WebDriver and not by embedders.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22224)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 20, 2018

⌛️ Testing commit b936fea with merge 98527dd...

@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit b936fea into servo:master Nov 20, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment