Send an IpcSharedMemory in tex_image_2d and tex_sub_image_2d #22225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 19, 2018
Send an IpcSharedMemory in tex_image_2d and tex_sub_image_2d
|
💔 Test failed - linux-rel-css |
|
This should be ready to be reviewed. @bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 19, 2018
Send an IpcSharedMemory in tex_image_2d and tex_sub_image_2d <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22225) <!-- Reviewable:end -->
|
💔 Test failed - status-taskcluster |
|
Unhappy tidy, fixed. |
|
r? @jdm |
Nothing else uses it in the whole crate graph.
This avoids a copy in the case of textures coming from HTMLImageElement.
emilio
approved these changes
Nov 21, 2018
| ); | ||
| let effective_data_type = self | ||
| .extension_manager | ||
| .effective_type(data_type.as_gl_constant()); |
There was a problem hiding this comment.
Why doesn't textSubImage2D need to go through the EM in order to get the effective internal format?
There was a problem hiding this comment.
It was like that before, and using it makes everything panic on the GL side.
|
@bors-servo r=emilio |
|
📌 Commit 9a8d03a has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Nov 21, 2018
Send an IpcSharedMemory in tex_image_2d and tex_sub_image_2d <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22225) <!-- Reviewable:end -->
|
☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is