Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send an IpcSharedMemory in tex_image_2d and tex_sub_image_2d #22225

Merged
merged 9 commits into from Nov 21, 2018

Rename gleam feature to gl in compositing

  • Loading branch information
nox committed Nov 20, 2018
commit faee0b2b0c5c5b6c696c83a1ddb03c1d4ba32e21
@@ -13,6 +13,7 @@ path = "lib.rs"

[features]
default = []
gl = ["gleam"]

[dependencies]
crossbeam-channel = "0.3"
@@ -4,7 +4,7 @@

use crate::compositor_thread::{CompositorProxy, CompositorReceiver};
use crate::compositor_thread::{InitialCompositorState, Msg};
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
use crate::gl;
use crate::touch::{TouchAction, TouchHandler};
use crate::windowing::{
@@ -15,13 +15,13 @@ use crate::SendableFrameTree;
use crossbeam_channel::Sender;
use euclid::{TypedPoint2D, TypedScale, TypedVector2D};
use gfx_traits::Epoch;
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
use image::{DynamicImage, ImageFormat};
use ipc_channel::ipc;
use libc::c_void;
use msg::constellation_msg::{PipelineId, PipelineIndex, PipelineNamespaceId};
use net_traits::image::base::Image;
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
use net_traits::image::base::PixelFormat;
use profile_traits::time::{self as profile_time, profile, ProfilerCategory};
use script_traits::CompositorEvent::{MouseButtonEvent, MouseMoveEvent, TouchEvent};
@@ -1211,13 +1211,13 @@ impl<Window: WindowMethods> IOCompositor<Window> {
}

let rt_info = match target {
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
CompositeTarget::Window => gl::RenderTargetInfo::default(),
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
CompositeTarget::WindowAndPng | CompositeTarget::PngFile => {
gl::initialize_png(&*self.window.gl(), width, height)
},
#[cfg(not(feature = "gleam"))]
#[cfg(not(feature = "gl"))]
_ => (),
};

@@ -1272,7 +1272,7 @@ impl<Window: WindowMethods> IOCompositor<Window> {

let rv = match target {
CompositeTarget::Window => None,
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
CompositeTarget::WindowAndPng => {
let img = gl::draw_img(&*self.window.gl(), rt_info, width, height);
Some(Image {
@@ -1283,7 +1283,7 @@ impl<Window: WindowMethods> IOCompositor<Window> {
id: None,
})
},
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
CompositeTarget::PngFile => {
let gl = &*self.window.gl();
profile(
@@ -1307,7 +1307,7 @@ impl<Window: WindowMethods> IOCompositor<Window> {
);
None
},
#[cfg(not(feature = "gleam"))]
#[cfg(not(feature = "gl"))]
_ => None,
};

@@ -20,7 +20,7 @@ use style_traits::CSSPixel;

mod compositor;
pub mod compositor_thread;
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
mod gl;
mod touch;
pub mod windowing;
@@ -6,15 +6,15 @@

use embedder_traits::EventLoopWaker;
use euclid::TypedScale;
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
use gleam::gl;
use keyboard_types::KeyboardEvent;
use msg::constellation_msg::{TopLevelBrowsingContextId, TraversalDirection};
use script_traits::{MouseButton, TouchEventType, TouchId};
use servo_geometry::DeviceIndependentPixel;
use servo_url::ServoUrl;
use std::fmt::{Debug, Error, Formatter};
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
use std::rc::Rc;
use style_traits::DevicePixel;
use webrender_api::{DeviceIntPoint, DevicePoint, DeviceUintRect, DeviceUintSize, ScrollLocation};
@@ -131,7 +131,7 @@ pub trait WindowMethods {
/// proceed and false if it should not.
fn prepare_for_composite(&self) -> bool;
/// Return the GL function pointer trait.
#[cfg(feature = "gleam")]
#[cfg(feature = "gl")]
fn gl(&self) -> Rc<dyn gl::Gl>;
/// Returns a thread-safe object to wake up the window's event loop.
fn create_event_loop_waker(&self) -> Box<dyn EventLoopWaker>;
@@ -38,7 +38,7 @@ bluetooth_traits = {path = "../bluetooth_traits"}
bluetooth = {path = "../bluetooth"}
canvas = {path = "../canvas"}
canvas_traits = {path = "../canvas_traits"}
compositing = {path = "../compositing", features = ["gleam"]}
compositing = {path = "../compositing", features = ["gl"]}
constellation = {path = "../constellation"}
crossbeam-channel = "0.3"
debugger = {path = "../debugger"}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.