Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Audio constructor #22227

Merged
merged 1 commit into from Nov 20, 2018
Merged

Implement Audio constructor #22227

merged 1 commit into from Nov 20, 2018

Conversation

@vn-ki
Copy link
Contributor

vn-ki commented Nov 19, 2018 •
edited by SimonSapin

Implement Audio constructor

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21929 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because tests were already there and the expectations were updated.

This change is Reviewable
@highfive
Copy link

highfive commented Nov 19, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.
@highfive
Copy link

highfive commented Nov 19, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/HTMLAudioElement.webidl, components/script/dom/htmlaudioelement.rs
  • @KiChjang: components/script/dom/webidls/HTMLAudioElement.webidl, components/script/dom/htmlaudioelement.rs
@jdm
jdm requested changes Nov 19, 2018
View changes
Copy link
Member

jdm left a comment

It's nice to see a bunch of tests passing!
components/script/dom/htmlaudioelement.rs Outdated Show resolved Hide resolved
components/script/dom/htmlaudioelement.rs Outdated Show resolved Hide resolved
@jdm jdm assigned jdm and unassigned paulrouget Nov 19, 2018
@vn-ki vn-ki force-pushed the vn-ki:audio-const branch from 977ab6c to 224aee5 Nov 19, 2018
@vn-ki vn-ki force-pushed the vn-ki:audio-const branch 2 times, most recently from eed30a9 to ae1e324 Nov 19, 2018
@vn-ki
Implement Audio constructor
Loading status checks…
684d108
@vn-ki vn-ki force-pushed the vn-ki:audio-const branch from ae1e324 to 684d108 Nov 20, 2018
@vn-ki
vn-ki reviewed Nov 20, 2018
View changes
tests/wpt/metadata/html/dom/interfaces.https.html.ini Show resolved Hide resolved
@vn-ki
vn-ki reviewed Nov 20, 2018
View changes
...bedded-content/media-elements/playing-the-media-resource/pause-remove-from-document.html.ini
[paused state when removing from a document]
expected: FAIL
expected: TIMEOUT

This comment has been minimized.

Sign in to view
@vn-ki

vn-ki Nov 20, 2018

Author Contributor

Is this a mistake from my part? This tests was timing out every time I ran it.

This comment has been minimized.

Sign in to view
@jdm

jdm Nov 20, 2018

Member

It means that the more of the test now executes than it did before.
@jdm
Copy link
Member

jdm commented Nov 20, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2018

📌 Commit 684d108 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2018

⌛ Testing commit 684d108 with merge 3fe83f1...
bors-servo added a commit that referenced this pull request Nov 20, 2018
@bors-servo
Auto merge of #22227 - vn-ki:audio-const, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3fe83f1 
Implement Audio constructor

<!-- Please describe your changes on the following line: -->
Implement Audio constructor

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21929 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because *tests were already there and the expectations were updated*.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22227)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 3fe83f1 to master...
@bors-servo bors-servo merged commit 684d108 into servo:master Nov 20, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 20, 2018
Merged
0 of 5 tasks complete
@vn-ki vn-ki deleted the vn-ki:audio-const branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement Audio constructor
5 participants
@vn-ki @highfive @jdm @bors-servo @paulrouget
You can’t perform that action at this time.