Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for touch events on Android #22229

Merged
merged 1 commit into from Nov 21, 2018
Merged

Add support for touch events on Android #22229

merged 1 commit into from Nov 21, 2018

Conversation

@Manishearth
Copy link
Member

Manishearth commented Nov 20, 2018 •
edited by SimonSapin

Currently on Android we treat all touch events as scroll events. Servo is already capable of distinguishing between scroll-touches and regular touch events (see on_touch_move in components/compositor/touch.rs), so we should just be passing touch events through.

Servo however does not natively support fling gestures, so we continue to use GestureDetector for that.

With this PR, the Three.js cloth animation can be panned around.

r? @paulrouget

This change is Reviewable
@Manishearth Manishearth force-pushed the Manishearth:touch-android branch from 470acce to 1122ccd Nov 20, 2018
@paulrouget
Copy link
Contributor

paulrouget commented Nov 21, 2018

Servo is already capable of distinguishing between scroll-touches and regular touch events

I missed that. Thanks. r=me.

Do we need to wait for #22187 before merging though?
@Manishearth
Copy link
Member Author

Manishearth commented Nov 21, 2018

I thought that was fixed?
@Manishearth
Add support for touch events on Android
Loading status checks…
3bccb8c 
Currently on Android we treat all touch events as scroll events. Servo
is already capable of distinguishing between scroll-touches and regular
touch events (see `on_touch_move` in `components/compositor/touch.rs`),
so we should just be passing touch events through.

Servo however does not natively support fling gestures, so we continue
to use `GestureDetector` for that.
@Manishearth Manishearth force-pushed the Manishearth:touch-android branch from 1122ccd to 3bccb8c Nov 21, 2018
@Manishearth
Copy link
Member Author

Manishearth commented Nov 21, 2018

@bors-servo r=paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

📌 Commit 3bccb8c has been approved by paulrouget
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

⌛ Testing commit 3bccb8c with merge a9e0e21...
bors-servo added a commit that referenced this pull request Nov 21, 2018
@bors-servo
Auto merge of #22229 - Manishearth:touch-android, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a9e0e21 
Add support for touch events on Android

Currently on Android we treat all touch events as scroll events. Servo is already capable of distinguishing between scroll-touches and regular touch events (see `on_touch_move` in `components/compositor/touch.rs`), so we should just be passing touch events through.

Servo however does not natively support fling gestures, so we continue to use `GestureDetector` for that.

With this PR, the [Three.js cloth animation](https://threejs.org/examples/webgl_animation_cloth.html) can be panned around.

r? @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22229)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

💔 Test failed - mac-rel-css1
@Manishearth
Copy link
Member Author

Manishearth commented Nov 21, 2018 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, magicleap, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

💔 Test failed - mac-rel-css1
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 21, 2018

@bors-servo retry

  • referer intermittent again
{"status": "NOTRUN", "group": "default", "message": null, "stack": null, "subtest": "The referrer URL is omitted when a\n                                 document served over http requires an https\n                                 sub-resource via a-tag using the rel-noreferrer\n                                 delivery method with keep-origin-redirect and when\n                                 the target request is cross-origin.", "test": "/_mozilla/mozilla/referrer-policy/no-referrer/rel-noreferrer/cross-origin/http-https/a-tag/generic.keep-origin-redirect.http.html", "line": 59731, "action": "test_result", "expected": "PASS"}
{"status": "TIMEOUT", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/_mozilla/mozilla/referrer-policy/no-referrer/rel-noreferrer/cross-origin/http-https/a-tag/generic.keep-origin-redirect.http.html", "line": 59732, "action": "test_result", "expected": "OK"}
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

⌛ Testing commit 3bccb8c with merge 07e334a...
bors-servo added a commit that referenced this pull request Nov 21, 2018
@bors-servo
Auto merge of #22229 - Manishearth:touch-android, r=paulrouget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
07e334a 
Add support for touch events on Android

Currently on Android we treat all touch events as scroll events. Servo is already capable of distinguishing between scroll-touches and regular touch events (see `on_touch_move` in `components/compositor/touch.rs`), so we should just be passing touch events through.

Servo however does not natively support fling gestures, so we continue to use `GestureDetector` for that.

With this PR, the [Three.js cloth animation](https://threejs.org/examples/webgl_animation_cloth.html) can be panned around.

r? @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22229)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: paulrouget
Pushing 07e334a to master...
@bors-servo bors-servo merged commit 3bccb8c into servo:master Nov 21, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:touch-android branch Nov 21, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2018

💥 Test timed out
@Manishearth Manishearth mentioned this pull request Jan 16, 2019
Closed
@Manishearth Manishearth mentioned this pull request Jan 17, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @paulrouget @bors-servo @CYBAI @highfive
You can’t perform that action at this time.