Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate webrender #22237
Update webrender #22237
Conversation
highfive
commented
Nov 21, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 21, 2018
| @@ -4913,6 +4940,7 @@ dependencies = [ | |||
| "checksum ident_case 1.0.0 (registry+https://github.com/rust-lang/crates.io-index)" = "3c9826188e666f2ed92071d2dadef6edc430b11b158b5b2b3f4babbcc891eaaa" | |||
| "checksum idna 0.1.4 (registry+https://github.com/rust-lang/crates.io-index)" = "014b298351066f1512874135335d62a789ffe78a9974f94b43ed5621951eaf7d" | |||
| "checksum image 0.19.0 (registry+https://github.com/rust-lang/crates.io-index)" = "ebdff791af04e30089bde8ad2a632b86af433b40c04db8d70ad4b21487db7a6a" | |||
| "checksum image 0.20.1 (registry+https://github.com/rust-lang/crates.io-index)" = "44665b4395d1844c96e7dc8ed5754782a1cdfd9ef458a80bbe45702681450504" | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
heh, this update wasn't even necessary to diagnose that bug because we already had the relevant commits on master. Either way, might as well land it. @bors-servo try |
|
|
lol I was only building for android so I didn't do the normal build. Will fix. |
|
I'm ok with that change, but it doesn't appear to fix #22232. |
oh :) |
|
Yeah -- I did all the work for the update whilst bisecting anyway, so made this pr for immediate landing. And then realized that the fix was in an open WR PR, so I'm just waiting for it to land before I finalize this. |
|
|
|
servo/webrender#3338 has been merged. |
|
@bors-servo: r+ |
|
|
|
Ah, it's the same intermittent as in #20633 the test doesn't try to render much so I suspect this is a general intermittent |
|
|
|
@bors-servo r=pcwalton so many new builders to gate on |
|
|
Update webrender Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it All the integer casts are due to servo/webrender#3291 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
Update webrender Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it All the integer casts are due to servo/webrender#3291 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22237) <!-- Reviewable:end -->
|
|
2 similar comments
|
|
|
|
Manishearth commentedNov 21, 2018
•
edited
Fixes #22232 , once servo/webrender#3327 lands and I update this PR to include it
All the integer casts are due to servo/webrender#3291
This change is