Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default scale based on dpi #2224

Merged
merged 1 commit into from Apr 24, 2014
Merged

Set default scale based on dpi #2224

merged 1 commit into from Apr 24, 2014

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented Apr 24, 2014

On high-density (e.g. "Retina") displays, this will set the default scale to 1 px per screen coordinate, rather than the current 1px per hardware pixel. This means that content on high-density displays will be rendered at a higher resolution but about the same physical size, compared to lower-density displays.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 24, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1377

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@metajack

This comment has been minimized.

Copy link

metajack commented on c036f17 Apr 24, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on c036f17 Apr 24, 2014

saw approval from metajack
at mbrubeck@c036f17

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 24, 2014

merging mbrubeck/servo/hidpi = c036f17 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 24, 2014

mbrubeck/servo/hidpi = c036f17 merged ok, testing candidate = a7494f7

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 24, 2014

fast-forwarding master to auto = a7494f7

bors-servo pushed a commit that referenced this pull request Apr 24, 2014
On high-density (e.g. "Retina") displays, this will set the default scale to 1 px per screen coordinate, rather than the current 1px per hardware pixel. This means that content on high-density displays will be rendered at a higher resolution but about the same physical size, compared to lower-density displays.
@bors-servo bors-servo merged commit c036f17 into servo:master Apr 24, 2014
1 check passed
1 check passed
default all tests passed
@mbrubeck mbrubeck deleted the mbrubeck:hidpi branch Jun 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.