Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange Response's statusText default value from 'Ok' to an empty string #22244
Conversation
highfive
commented
Nov 21, 2018
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon. |
highfive
commented
Nov 21, 2018
|
Heads up! This PR modifies the following files:
|
|
Error syncing changes upstream. Logs saved in error-snapshot-1542840208228. |
|
Oh, looks like #22235 means that we have not pulled the most recent changes from the upstream tests yet. That's frustrating. |
|
|
|
If you rebase, the test should show different results now. |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Nov 27, 2018
…, r=<try> Change Response's statusText default value from 'Ok' to an empty string <!-- Please describe your changes on the following line: --> Closes #22238 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22244) <!-- Reviewable:end -->
nox
added
S-needs-code-changes
and removed
S-awaiting-review
S-blocked-on-external
S-needs-rebase
labels
|
Pretty sure this needs expectation changes. |
|
|
|
highfive
added
S-awaiting-review
and removed
S-tests-failed
S-needs-code-changes
labels
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Nov 27, 2018
…, r=<try> Change Response's statusText default value from 'Ok' to an empty string <!-- Please describe your changes on the following line: --> Closes #22238 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22244) <!-- Reviewable:end -->
|
|
|
The code that deals with blob responses in scheme_fetch will need to provide an OK value per https://fetch.spec.whatwg.org/#scheme-fetch . |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 28, 2018
…, r=jdm Change Response's statusText default value from 'Ok' to an empty string <!-- Please describe your changes on the following line: --> Closes #22238 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22244) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 28, 2018
…, r=jdm Change Response's statusText default value from 'Ok' to an empty string <!-- Please describe your changes on the following line: --> Closes #22238 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22244) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
georgeroman commentedNov 21, 2018
•
edited by SimonSapin
Closes #22238
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is