New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on upstream SW wpt tests #22278

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
5 participants
@CYBAI
Collaborator

CYBAI commented Nov 27, 2018

Generated these metadata with following command

$ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers
$ ./mach update-wpt update.log

Ref: #22218 (comment)


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • This PR will turn on ServiceWorker for upstream WPT tests

This change is Reviewable

@CYBAI

This comment has been minimized.

Collaborator

CYBAI commented Nov 27, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 27, 2018

⌛️ Trying commit d44243a with merge 821e489...

bors-servo added a commit that referenced this pull request Nov 27, 2018

Auto merge of #22278 - CYBAI:turn-sw-wpt-on, r=<try>
Turn on upstream SW wpt tests

Generated these metadata with following command

```sh
$ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers
$ ./mach update-wpt update.log
```

Ref: #22218 (comment)

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] This PR will turn on `ServiceWorker` for upstream WPT tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22278)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 27, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@jdm

This comment has been minimized.

Member

jdm commented Nov 27, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 27, 2018

📌 Commit d44243a has been approved by jdm

@Manishearth

This comment has been minimized.

Member

Manishearth commented Nov 28, 2018

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 28, 2018

💡 This pull request was already approved, no need to approve it again.

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 28, 2018

📌 Commit d44243a has been approved by jdm

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 28, 2018

⌛️ Testing commit d44243a with merge 100acea...

bors-servo added a commit that referenced this pull request Nov 28, 2018

Auto merge of #22278 - CYBAI:turn-sw-wpt-on, r=jdm
Turn on upstream SW wpt tests

Generated these metadata with following command

```sh
$ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers
$ ./mach update-wpt update.log
```

Ref: #22218 (comment)

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] This PR will turn on `ServiceWorker` for upstream WPT tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22278)
<!-- Reviewable:end -->
@Manishearth

This comment has been minimized.

Member

Manishearth commented Nov 28, 2018

Some webhook notifications were dropped, homu hits an assertion error in that case.

@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit d44243a into servo:master Nov 28, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@CYBAI CYBAI deleted the CYBAI:turn-sw-wpt-on branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment