Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on upstream SW wpt tests #22278

Merged
merged 1 commit into from Nov 28, 2018
Merged

Turn on upstream SW wpt tests #22278

merged 1 commit into from Nov 28, 2018

Conversation

CYBAI
Copy link
Member

@CYBAI CYBAI commented Nov 27, 2018

Generated these metadata with following command

$ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers
$ ./mach update-wpt update.log

Ref: #22218 (comment)


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • This PR will turn on ServiceWorker for upstream WPT tests

This change is Reviewable

@CYBAI
Copy link
Member Author

CYBAI commented Nov 27, 2018

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

⌛ Trying commit d44243a with merge 821e489...

bors-servo pushed a commit that referenced this pull request Nov 27, 2018
Turn on upstream SW wpt tests

Generated these metadata with following command

```sh
$ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers
$ ./mach update-wpt update.log
```

Ref: #22218 (comment)

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] This PR will turn on `ServiceWorker` for upstream WPT tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22278)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@jdm
Copy link
Member

jdm commented Nov 27, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit d44243a has been approved by jdm

@Manishearth
Copy link
Member

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit d44243a has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit d44243a with merge 100acea...

bors-servo pushed a commit that referenced this pull request Nov 28, 2018
Turn on upstream SW wpt tests

Generated these metadata with following command

```sh
$ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/service-workers
$ ./mach update-wpt update.log
```

Ref: #22218 (comment)

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] This PR will turn on `ServiceWorker` for upstream WPT tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22278)
<!-- Reviewable:end -->
@Manishearth
Copy link
Member

Some webhook notifications were dropped, homu hits an assertion error in that case.

@bors-servo
Copy link
Contributor

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 100acea to master...

@bors-servo bors-servo merged commit d44243a into servo:master Nov 28, 2018
@CYBAI CYBAI deleted the turn-sw-wpt-on branch November 28, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants