New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daydream support #22317

Merged
merged 2 commits into from Nov 30, 2018

Conversation

Projects
None yet
5 participants
@Manishearth
Member

Manishearth commented Nov 29, 2018

Added a googlevr-flavor AndroidManifest.xml for servoapp (this gets
merged with the main one). Daydream works now.

I haven't added an oculus one since as far as I can tell we don't
support pure servo on oculus yet.

r? @jdm @paulrouget


This change is Reviewable

@Manishearth

This comment has been minimized.

Member

Manishearth commented Nov 30, 2018

Stuck part of the fix for #22318 in this PR

@Manishearth

This comment has been minimized.

Member

Manishearth commented Nov 30, 2018

@bors-servo r=MortimerGoro

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 30, 2018

📌 Commit d11c81a has been approved by MortimerGoro

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 30, 2018

⌛️ Testing commit d11c81a with merge aa1b688...

bors-servo added a commit that referenced this pull request Nov 30, 2018

Auto merge of #22317 - Manishearth:vr-packaging, r=MortimerGoro
Fix daydream support

Added a googlevr-flavor AndroidManifest.xml for servoapp (this gets
merged with the main one). Daydream works now.

I haven't added an oculus one since as far as I can tell we don't
support pure servo on oculus yet.

r? @jdm @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22317)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 30, 2018

@bors-servo bors-servo merged commit d11c81a into servo:master Nov 30, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment