Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra backslash from Gstreamer info added to the PATH on Windows #22322

Merged
merged 1 commit into from Nov 30, 2018
Merged

Remove extra backslash from Gstreamer info added to the PATH on Windows #22322

merged 1 commit into from Nov 30, 2018
+1 −1

Conversation

@ferjm
Copy link
Member

ferjm commented Nov 30, 2018 •
edited by SimonSapin

This change is Reviewable
@ferjm
Remove extra backslash from Gstreamer info added to the PATH on Windows
Loading status checks…
b064665
@ferjm
Copy link
Member Author

ferjm commented Nov 30, 2018

@bors-servo try=windows
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

⌛ Trying commit b064665 with merge b6abdfb...
bors-servo added a commit that referenced this pull request Nov 30, 2018
@bors-servo
Auto merge of #22322 - ferjm:windows.extra.backslash, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b6abdfb 
Remove extra backslash from Gstreamer info added to the PATH on Windows

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22322)
<!-- Reviewable:end -->
@ferjm ferjm mentioned this pull request Nov 30, 2018
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

☀️ Test successful - windows-msvc-dev
State: approved= try=True
@ferjm
Copy link
Member Author

ferjm commented Nov 30, 2018

r? @jdm
@highfive highfive assigned jdm and unassigned emilio Nov 30, 2018
@jdm
Copy link
Member

jdm commented Nov 30, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

📌 Commit b064665 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

⌛ Testing commit b064665 with merge 8f162da...
bors-servo added a commit that referenced this pull request Nov 30, 2018
@bors-servo
Auto merge of #22322 - ferjm:windows.extra.backslash, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8f162da 
Remove extra backslash from Gstreamer info added to the PATH on Windows

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22322)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented Nov 30, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

⌛ Testing commit b064665 with merge 08b67ad...
bors-servo added a commit that referenced this pull request Nov 30, 2018
@bors-servo
Auto merge of #22322 - ferjm:windows.extra.backslash, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
08b67ad 
Remove extra backslash from Gstreamer info added to the PATH on Windows

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22322)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Nov 30, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, magicleap, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-wpt3, mac-rel-wpt4...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing 08b67ad to master...
@bors-servo bors-servo merged commit b064665 into servo:master Nov 30, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ferjm @bors-servo @jdm @emilio @highfive
You can’t perform that action at this time.