Implementing HTMLMediaElement.volume attribute #22324

lucasfantacuci · 2018-11-30T12:42:29Z

This P.R. is going to implement the volume attribute to the HTMLMediaElement

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Implement HTMLMediaElement.volume attribute #22292.

There are tests for these changes

This change is

highfive · 2018-11-30T12:42:36Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

highfive · 2018-11-30T12:42:37Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/HTMLMediaElement.webidl
@KiChjang: components/script/dom/webidls/HTMLMediaElement.webidl

highfive · 2018-11-30T12:42:39Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

components/script/dom/htmlmediaelement.rs

KiChjang

Thanks for your work on this! I only have minor comments, once you address them, please squash your commits and we can land this!

components/script/dom/htmlmediaelement.rs

jdm · 2018-11-30T21:40:14Z

Before we merge this, we'll want to pass the volume to the actual player.

lucasfantacuci · 2018-12-03T11:05:44Z

Before we merge this, we'll want to pass the volume to the actual player.

Sorry, I didn't get it.

jdm · 2018-12-03T12:16:49Z

Right now all we do is store and retrieve a value from a local member. The volume of the media stream is not affected; we need to add get_volume and set_volume APIs to https://github.com/servo/media/blob/f90235b16d9eb956ad9dba2dbca53e8f25e8b451/player/src/lib.rs#L46 (using the inner_player_proxy macro to call the appropriate backend APIs, so that we can call those methods on self.player in this code. Does that make sense?

lucasfantacuci · 2018-12-03T12:34:51Z

Right now all we do is store and retrieve a value from a local member. The volume of the media stream is not affected; we need to add get_volume and set_volume APIs to https://github.com/servo/media/blob/f90235b16d9eb956ad9dba2dbca53e8f25e8b451/player/src/lib.rs#L46 (using the inner_player_proxy macro to call the appropriate backend APIs, so that we can call those methods on self.player in this code. Does that make sense?

Sure, it makes sense, so, I've created this P.R. handling it.

As @ferjm said I don't think get_volume at player trait should be necessary.

ferjm · 2018-12-03T16:01:38Z

As @ferjm said I didn't realize get_volume at player trait should be necessary.

Yeah, I don't think we need a getter in this case as we have the value already available on the DOM side.

lucasfantacuci · 2018-12-05T15:19:03Z

Hi Sirs,
Do I have to do anything else?
Regards,

ferjm · 2018-12-05T16:04:13Z

There are at least a couple of things left:

We need to upgrade servo-media (./mach cargo-update -p servo-media) to get your change in Servo and set the volume of the media stream using set_volume method that you added to the Player API. You can access this method through the self.player instance in this code.
We need to check if these changes fix some of these Web Platform Tests (they should) and update the test expectations accordingly. There may be more tests affected:

lucasfantacuci · 2018-12-10T16:53:34Z

tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/audio_volume_check.html
tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/audio_volume_loudest-manual.html
tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/audio_volume_silent-manual.html
tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/event_volumechange.html
tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/video_volume_check.html
tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/video_volume_loudest-manual.html
tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/video_volume_silent-manual.html
tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/volume_nonfinite.html
tests/wpt/web-platform-tests/html/dom/interfaces.https.html

KiChjang · 2018-12-10T22:00:37Z

@bors-servo try=wpt

…lume_attribute, r=<try> Implementing HTMLMediaElement.volume attribute  Work In Progress. Do not Accept. This P.R. is going to implement the volume attribute to the HTMLMediaElement ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22292.  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22324)

bors-servo · 2018-12-10T22:00:43Z

⌛ Trying commit 98d4eab with merge c0e46db...

bors-servo · 2018-12-10T22:51:55Z

💔 Test failed - linux-rel-wpt

jdm · 2018-12-11T00:09:19Z

That failure is #22062.

ferjm · 2018-12-11T10:59:27Z

tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/event_volumechange.html

We are missing the volumechange event part. Check the "Whenever either of the values ..." paragraph of the spec. We need to fire that event if volume changes.

tests/wpt/web-platform-tests/html/semantics/embedded-content/media-elements/audio_volume_loudest-manual.html

Did you try the *-manual ones locally? These are not run automatically and are not listed on the test expectations.

bors-servo · 2018-12-11T21:07:41Z

⌛ Trying commit 46c4fc7 with merge 0649710...

…lume_attribute, r=<try> Implementing HTMLMediaElement.volume attribute  Work In Progress. Do not Accept. This P.R. is going to implement the volume attribute to the HTMLMediaElement ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22292.  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22324)

bors-servo · 2018-12-11T21:32:46Z

💔 Test failed - linux-rel-css

ferjm · 2018-12-11T21:54:44Z

It seems that this patch makes an extra test pass :). Update the test expectations for /html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document.html and squash the commits please.

bors-servo · 2018-12-11T23:28:56Z

☔ The latest upstream changes (presumably #22392) made this pull request unmergeable. Please resolve the merge conflicts.

lucasfantacuci · 2018-12-12T13:19:57Z

It seems that this patch makes an extra test pass :). Update the test expectations for /html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document.html and squash the commits please.

Done sir, And how about this conflict, I don't know what's going on.

ferjm · 2018-12-12T13:23:20Z

The merge conflict means that your patch does not apply cleanly on the current master. You need to rebase your patch on top of the current master.

ferjm · 2018-12-12T16:03:00Z

@bors-servo r+

bors-servo · 2018-12-12T16:03:00Z

📌 Commit ad3ec61 has been approved by ferjm

…lume_attribute, r=ferjm Implementing HTMLMediaElement.volume attribute  This P.R. is going to implement the volume attribute to the HTMLMediaElement ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22292.  - [x] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22324)

bors-servo · 2018-12-12T17:00:47Z

⌛ Testing commit ad3ec61 with merge 0c506ef...

jdm · 2018-12-12T18:54:52Z

@bors-servo retry

bors-servo · 2018-12-12T18:54:58Z

⌛ Testing commit ad3ec61 with merge d5c1690...

…lume_attribute, r=ferjm Implementing HTMLMediaElement.volume attribute  This P.R. is going to implement the volume attribute to the HTMLMediaElement ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22292.  - [x] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22324)

bors-servo · 2018-12-12T20:17:26Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: ferjm
Pushing d5c1690 to master...

highfive assigned Manishearth Nov 30, 2018

highfive added the S-awaiting-review label Nov 30, 2018

lucasfantacuci commented Nov 30, 2018

View reviewed changes

components/script/dom/htmlmediaelement.rs Show resolved Hide resolved

KiChjang suggested changes Nov 30, 2018

View reviewed changes

components/script/dom/htmlmediaelement.rs Show resolved Hide resolved

components/script/dom/htmlmediaelement.rs Show resolved Hide resolved

components/script/dom/htmlmediaelement.rs Outdated Show resolved Hide resolved

KiChjang added S-needs-code-changes and removed S-awaiting-review labels Nov 30, 2018

lucasfantacuci force-pushed the implement_html_media_element_volume_attribute branch from 5d574be to e00b016 Compare December 3, 2018 11:30

highfive added S-awaiting-review and removed S-needs-code-changes labels Dec 3, 2018

lucasfantacuci force-pushed the implement_html_media_element_volume_attribute branch from e00b016 to 207f95e Compare December 3, 2018 12:44

lucasfantacuci changed the title ~~WIP: Implementing HTMLMediaElement.volume attribute~~ Implementing HTMLMediaElement.volume attribute Dec 3, 2018

highfive added the S-tests-failed label Dec 10, 2018

highfive removed the S-tests-failed label Dec 11, 2018

highfive added the S-tests-failed label Dec 11, 2018

highfive added the S-needs-rebase label Dec 11, 2018

lucasfantacuci force-pushed the implement_html_media_element_volume_attribute branch from 46c4fc7 to 211f358 Compare December 12, 2018 11:46

highfive removed the S-tests-failed label Dec 12, 2018

lucasfantacuci force-pushed the implement_html_media_element_volume_attribute branch from d43265e to a2020fc Compare December 12, 2018 13:18

lucasfantacuci force-pushed the implement_html_media_element_volume_attribute branch from a2020fc to e7be09d Compare December 12, 2018 13:42

Implementing volume attribute into HTMLMediaElement

ad3ec61

lucasfantacuci force-pushed the implement_html_media_element_volume_attribute branch from e7be09d to ad3ec61 Compare December 12, 2018 13:51

highfive assigned ferjm and unassigned Manishearth Dec 12, 2018

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Dec 12, 2018

bors-servo merged commit ad3ec61 into servo:master Dec 12, 2018

highfive removed the S-awaiting-merge label Dec 12, 2018

Implementing HTMLMediaElement.volume attribute #22324

Implementing HTMLMediaElement.volume attribute #22324

lucasfantacuci commented Nov 30, 2018 •

edited

highfive commented Nov 30, 2018

highfive commented Nov 30, 2018

highfive commented Nov 30, 2018

KiChjang left a comment

jdm commented Nov 30, 2018

lucasfantacuci commented Dec 3, 2018

jdm commented Dec 3, 2018

lucasfantacuci commented Dec 3, 2018 •

edited

ferjm commented Dec 3, 2018

lucasfantacuci commented Dec 5, 2018 •

edited

ferjm commented Dec 5, 2018

lucasfantacuci commented Dec 10, 2018 •

edited

KiChjang commented Dec 10, 2018

bors-servo commented Dec 10, 2018

bors-servo commented Dec 10, 2018

jdm commented Dec 11, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 11, 2018

bors-servo commented Dec 11, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 11, 2018

lucasfantacuci commented Dec 12, 2018 •

edited

ferjm commented Dec 12, 2018

ferjm commented Dec 12, 2018

bors-servo commented Dec 12, 2018

bors-servo commented Dec 12, 2018

jdm commented Dec 12, 2018

bors-servo commented Dec 12, 2018

bors-servo commented Dec 12, 2018

Implementing HTMLMediaElement.volume attribute #22324

Implementing HTMLMediaElement.volume attribute #22324

Conversation

lucasfantacuci commented Nov 30, 2018 • edited

highfive commented Nov 30, 2018

highfive commented Nov 30, 2018

highfive commented Nov 30, 2018

KiChjang left a comment

Choose a reason for hiding this comment

jdm commented Nov 30, 2018

lucasfantacuci commented Dec 3, 2018

jdm commented Dec 3, 2018

lucasfantacuci commented Dec 3, 2018 • edited

ferjm commented Dec 3, 2018

lucasfantacuci commented Dec 5, 2018 • edited

ferjm commented Dec 5, 2018

lucasfantacuci commented Dec 10, 2018 • edited

KiChjang commented Dec 10, 2018

bors-servo commented Dec 10, 2018

bors-servo commented Dec 10, 2018

jdm commented Dec 11, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 11, 2018

bors-servo commented Dec 11, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 11, 2018

lucasfantacuci commented Dec 12, 2018 • edited

ferjm commented Dec 12, 2018

ferjm commented Dec 12, 2018

bors-servo commented Dec 12, 2018

bors-servo commented Dec 12, 2018

jdm commented Dec 12, 2018

bors-servo commented Dec 12, 2018

bors-servo commented Dec 12, 2018

lucasfantacuci commented Nov 30, 2018 •

edited

lucasfantacuci commented Dec 3, 2018 •

edited

lucasfantacuci commented Dec 5, 2018 •

edited

lucasfantacuci commented Dec 10, 2018 •

edited

lucasfantacuci commented Dec 12, 2018 •

edited