Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Event::bubbles to false #2233

Merged

Conversation

@campadrenalin
Copy link
Contributor

campadrenalin commented Apr 25, 2014

Fixes #2183.

@highfive
Copy link

highfive commented Apr 25, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @kmcallister (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 25, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1387

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger

This comment has been minimized.

Copy link

Ms2ger commented on 6312ff3 Apr 28, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 6312ff3 Apr 28, 2014

saw approval from Ms2ger
at campadrenalin@6312ff3

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 28, 2014

merging campadrenalin/servo/initialize-event-bubbling-to-false = 6312ff3 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 28, 2014

campadrenalin/servo/initialize-event-bubbling-to-false = 6312ff3 merged ok, testing candidate = b6ed246

This comment has been minimized.

Copy link
Contributor

bors-servo replied Apr 28, 2014

fast-forwarding master to auto = b6ed246

bors-servo pushed a commit that referenced this pull request Apr 28, 2014
@bors-servo bors-servo merged commit 6312ff3 into servo:master Apr 28, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.