Implement Ended media attribute #22348

germangb · 2018-12-01T21:10:29Z

This PR should implement:

New method HTMLMediaElement::earliest_possible_position() for the earliest possible position
Ended attribute following https://html.spec.whatwg.org/multipage/media.html#ended-playback
Queue steps for when the playback position reaches the end

This PR contains placeholders for the following issues (I can rebase changes after the corresponding PRs get merged)

#22321 (Define the Loop attribute)
#22293 (To identify playback direction. Either forwards or backwards)

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22294.

This change is

highfive · 2018-12-01T21:10:34Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.

highfive · 2018-12-01T21:10:35Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs
@KiChjang: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs

highfive · 2018-12-01T21:10:36Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

ferjm

Wonderfull work! I have only a few minor comments.

ferjm · 2018-12-05T13:57:24Z

components/script/dom/htmlmediaelement.rs

+
+// XXX Placeholder for [https://github.com/servo/servo/issues/22293]
+#[derive(Clone, Copy, JSTraceable, MallocSizeOf, PartialEq)]
+pub enum PlaybackDirection {


This does not need to be public.

ferjm · 2018-12-05T13:57:24Z

components/script/dom/htmlmediaelement.rs

+                this.upcast::<EventTarget>().fire_event(atom!("timeupdate"));
+
+                // Step 3.2.
+                if this.Ended() && !this.Loop() {


I think this should be !this.Paused() instead of !this.Loop()

You're right, I misread the steps

ferjm · 2018-12-05T13:57:24Z

components/script/dom/htmlmediaelement.rs

+                                // the HTMLMediaElementMethods::Ended method
+
+                                // Step 3.
+                                self.queue_reaches_the_end_steps();


Since this is only going to be used here, could we inline the implementation of queue_reaches_the_end_steps here?

Yes, the reason I put it there is because I looked for examples of using the queue and tried to follow the same pattern. But it this case I'm splitting the steps between two methods, which probably hurts more than it helps..

Thanks for the feedback!

ferjm · 2018-12-07T22:20:42Z

@bors-servo try=wpt

bors-servo · 2018-12-07T22:20:50Z

⌛ Trying commit 5db4e49 with merge 81fd21e...


        Auto merge of #22348 - germangb:html_media_ended, r=<try>

Implement Ended media attribute  This PR should implement: * New method `HTMLMediaElement::earliest_possible_position()` for the [earliest possible position](https://html.spec.whatwg.org/multipage/media.html#earliest-possible-position) * `Ended` attribute following https://html.spec.whatwg.org/multipage/media.html#ended-playback * Queue steps for when the playback position reaches the end This PR contains placeholders for the following issues (I can rebase changes after the corresponding PRs get merged) - #22321 (Define the Loop attribute) - #22293 (To identify playback direction. Either forwards or backwards) ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #22294.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22348)

bors-servo · 2018-12-07T22:42:50Z

💔 Test failed - linux-rel-css

ferjm · 2018-12-10T08:44:23Z

This patch makes some WPT pass:

{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<video autoplay> with <track> child", "test": "/html/semantics/embedded-content/media-elements/autoplay-with-broken-track.html", "line": 123216, "action": "test_result", "expected": "TIMEOUT"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "<video autoplay> with <track> child", "test": "/html/semantics/embedded-content/media-elements/autoplay-with-broken-track.html", "line": 123218, "action": "test_result", "expected": "TIMEOUT"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "setting src attribute on a sufficiently long autoplay audio should trigger timeupdate event", "test": "/html/semantics/embedded-content/media-elements/event_timeupdate.html", "line": 177074, "action": "test_result", "expected": "NOTRUN"}
{"status": "PASS", "group": "default", "message": null, "stack": null, "subtest": "setting src attribute on a sufficiently long autoplay video should trigger timeupdate event", "test": "/html/semantics/embedded-content/media-elements/event_timeupdate.html", "line": 177075, "action": "test_result", "expected": "NOTRUN"}
{"status": "OK", "group": "default", "message": null, "stack": null, "subtest": null, "test": "/html/semantics/embedded-content/media-elements/event_timeupdate.html", "line": 177076, "action": "test_result", "expected": "TIMEOUT"}

So we need to update the test expectations before merging.

germangb · 2018-12-10T13:11:40Z

According to the readme (in this case) I should remove the metadata files where all the expectations are no longer TIMEOUT nor NOTRUN, correct?

ferjm · 2018-12-10T14:39:01Z

According to the readme (in this case) I should remove the metadata files where all the expectations are no longer TIMEOUT nor NOTRUN, correct?

Yes, that's correct.

ferjm

I think this is ready to be merged after squashing the commits. Thanks for the great work done here.

germangb · 2018-12-10T15:19:52Z

Squashed!

ferjm · 2018-12-10T15:24:21Z

@bors-servo r+

bors-servo · 2018-12-10T15:24:23Z

📌 Commit 7020930 has been approved by ferjm

ferjm · 2019-01-10T15:47:07Z

hmm, right, I was confused by the S-needs-rebase label.

jdm · 2019-01-10T15:58:39Z

@bors-servo try=wpt

jdm · 2019-01-10T15:58:52Z

@bors-servo retry

bors-servo · 2019-01-10T15:59:08Z

⌛ Trying commit a4165c9 with merge a847f89...


        Auto merge of #22348 - germangb:html_media_ended, r=<try>

Implement Ended media attribute  This PR should implement: * New method `HTMLMediaElement::earliest_possible_position()` for the [earliest possible position](https://html.spec.whatwg.org/multipage/media.html#earliest-possible-position) * `Ended` attribute following https://html.spec.whatwg.org/multipage/media.html#ended-playback * Queue steps for when the playback position reaches the end This PR contains placeholders for the following issues (I can rebase changes after the corresponding PRs get merged) - #22321 (Define the Loop attribute) - #22293 (To identify playback direction. Either forwards or backwards) ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #22294.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22348)

bors-servo · 2019-01-10T16:28:29Z

💔 Test failed - linux-rel-wpt

ferjm · 2019-01-10T16:31:47Z

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLMediaElement interface: document.createElement(\"video\") must inherit property \"ended\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 79837, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLMediaElement interface: document.createElement(\"audio\") must inherit property \"ended\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 79891, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLMediaElement interface: new Audio() must inherit property \"ended\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 79939, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLMediaElement interface: attribute ended", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80032, 
    "action": "test_result", 
    "expected": "FAIL"
}

We need to update the expectations for tests/wpt/web-platform-tests/html/dom/interfaces.https.html

bors-servo · 2019-01-11T15:45:09Z

☔ The latest upstream changes (presumably #22522) made this pull request unmergeable. Please resolve the merge conflicts.


        Implement Ended media attribute

Signed-off-by: german gomez <germangb42@gmail.com>


        Update interfaces.https.html test expectations

Signed-off-by: german gomez <germangb42@gmail.com>

germangb · 2019-01-11T17:26:32Z

Some of the patterns in the player event's match statement had been rearranged

ferjm · 2019-01-14T09:17:17Z

@bors-servo try=wpt

bors-servo · 2019-01-14T09:17:22Z

⌛ Trying commit 352fed7 with merge e6f9dfa...


        Auto merge of #22348 - germangb:html_media_ended, r=<try>

Implement Ended media attribute  This PR should implement: * New method `HTMLMediaElement::earliest_possible_position()` for the [earliest possible position](https://html.spec.whatwg.org/multipage/media.html#earliest-possible-position) * `Ended` attribute following https://html.spec.whatwg.org/multipage/media.html#ended-playback * Queue steps for when the playback position reaches the end This PR contains placeholders for the following issues (I can rebase changes after the corresponding PRs get merged) - #22321 (Define the Loop attribute) - #22293 (To identify playback direction. Either forwards or backwards) ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #22294.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22348)

bors-servo · 2019-01-14T09:46:28Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

ferjm · 2019-01-14T11:35:41Z

@bors-servo r+

bors-servo · 2019-01-14T11:35:42Z

📌 Commit 352fed7 has been approved by ferjm

bors-servo · 2019-01-14T11:35:47Z

⌛ Testing commit 352fed7 with merge 1f9b134...


        Auto merge of #22348 - germangb:html_media_ended, r=ferjm

Implement Ended media attribute  This PR should implement: * New method `HTMLMediaElement::earliest_possible_position()` for the [earliest possible position](https://html.spec.whatwg.org/multipage/media.html#earliest-possible-position) * `Ended` attribute following https://html.spec.whatwg.org/multipage/media.html#ended-playback * Queue steps for when the playback position reaches the end This PR contains placeholders for the following issues (I can rebase changes after the corresponding PRs get merged) - #22321 (Define the Loop attribute) - #22293 (To identify playback direction. Either forwards or backwards) ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #22294.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22348)

bors-servo · 2019-01-14T13:46:23Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: ferjm
Pushing 1f9b134 to master...

highfive assigned avadacatavra Dec 1, 2018

highfive added the S-awaiting-review label Dec 1, 2018

germangb force-pushed the germangb:html_media_ended branch from a1a96cb to 989bec6 Dec 1, 2018

germangb changed the title ~~WIP: Implement Ended media attribute~~ Implement Ended media attribute Dec 3, 2018

ferjm requested changes Dec 5, 2018

View changes

highfive added the S-tests-failed label Dec 7, 2018

highfive removed the S-tests-failed label Dec 10, 2018

germangb force-pushed the germangb:html_media_ended branch from ba20d8c to ee6ccf9 Dec 10, 2018

ferjm approved these changes Dec 10, 2018

View changes

jdm added S-needs-squash and removed S-awaiting-review labels Dec 10, 2018

jdm assigned ferjm and unassigned avadacatavra Dec 10, 2018

germangb force-pushed the germangb:html_media_ended branch from ee6ccf9 to 7020930 Dec 10, 2018

highfive added the S-awaiting-review label Dec 10, 2018

highfive removed S-awaiting-review S-needs-squash labels Dec 10, 2018

ferjm removed the S-needs-rebase label Jan 10, 2019

highfive added the S-needs-rebase label Jan 11, 2019

germangb added 2 commits Dec 11, 2018

Implement Ended media attribute

5605f23

Signed-off-by: german gomez <germangb42@gmail.com>

Update interfaces.https.html test expectations

Verified

This commit was signed with a verified signature.

germangb german gömez

GPG key ID: 1B4B35B9E05D3D4C Learn about signing commits

Loading status checks…

352fed7

Signed-off-by: german gomez <germangb42@gmail.com>

germangb force-pushed the germangb:html_media_ended branch from a4165c9 to 352fed7 Jan 11, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Jan 11, 2019

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Jan 14, 2019

highfive removed the S-awaiting-merge label Jan 14, 2019

servo / servo

Implement Ended media attribute #22348

Implement Ended media attribute #22348

germangb commented Dec 1, 2018 •

edited by ferjm

highfive commented Dec 1, 2018

highfive commented Dec 1, 2018

highfive commented Dec 1, 2018

ferjm left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ferjm commented Dec 7, 2018

bors-servo commented Dec 7, 2018

bors-servo commented Dec 7, 2018

ferjm commented Dec 10, 2018

germangb commented Dec 10, 2018

ferjm commented Dec 10, 2018

ferjm left a comment

germangb commented Dec 10, 2018

ferjm commented Dec 10, 2018

bors-servo commented Dec 10, 2018

ferjm commented Jan 10, 2019

jdm commented Jan 10, 2019

jdm commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

ferjm commented Jan 10, 2019

bors-servo commented Jan 11, 2019

germangb commented Jan 11, 2019

ferjm commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

ferjm commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

servo / servo

Join GitHub today

Implement Ended media attribute #22348

Implement Ended media attribute #22348

Conversation

germangb commented Dec 1, 2018 • edited by ferjm

highfive commented Dec 1, 2018

highfive commented Dec 1, 2018

highfive commented Dec 1, 2018

ferjm left a comment

This comment has been minimized.

ferjm Dec 5, 2018

This comment has been minimized.

ferjm Dec 5, 2018

This comment has been minimized.

germangb Dec 7, 2018

This comment has been minimized.

ferjm Dec 5, 2018

This comment has been minimized.

germangb Dec 7, 2018

ferjm commented Dec 7, 2018

bors-servo commented Dec 7, 2018

bors-servo commented Dec 7, 2018

ferjm commented Dec 10, 2018

germangb commented Dec 10, 2018

ferjm commented Dec 10, 2018

ferjm left a comment

germangb commented Dec 10, 2018

ferjm commented Dec 10, 2018

bors-servo commented Dec 10, 2018

ferjm commented Jan 10, 2019

jdm commented Jan 10, 2019

jdm commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

ferjm commented Jan 10, 2019

bors-servo commented Jan 11, 2019

germangb commented Jan 11, 2019

ferjm commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

ferjm commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

germangb commented Dec 1, 2018 •

edited by ferjm