Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate rust-mozjs #22353
Conversation
highfive
assigned
avadacatavra
Dec 2, 2018
This comment has been minimized.
This comment has been minimized.
highfive
commented
Dec 2, 2018
Heads up! This PR modifies the following files:
|
This comment has been minimized.
This comment has been minimized.
highfive
commented
Dec 2, 2018
highfive
added
the
S-awaiting-review
label
Dec 2, 2018
This comment has been minimized.
This comment has been minimized.
@bors-servo try=wpt |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Dec 2, 2018
This comment has been minimized.
This comment has been minimized.
@paulrouget We'll need to figure out if this new model requires any changes to accommodate the FxR integration. |
jdm
added
the
S-blocked-on-external
label
Dec 2, 2018
This comment has been minimized.
This comment has been minimized.
|
jdm
force-pushed the
jdm:runtime-parent
branch
3 times, most recently
from
0e3a880
to
79a3774
Dec 2, 2018
jdm
changed the title
Runtime parent
Update rust-mozjs
Dec 3, 2018
This comment has been minimized.
This comment has been minimized.
Side note. There was a force push and the Cargo.lock turned to be wrong. This is necessary: index 9ea9d39f71..6432091dc5 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2512,7 +2512,7 @@ dependencies = [
[[package]]
name = "mozjs"
version = "0.10.0"
-source = "git+https://github.com/jdm/rust-mozjs?branch=parent-refactor#ac7f350c0a16217bd4e6a558a747ad5669a2f203"
+source = "git+https://github.com/jdm/rust-mozjs?branch=parent-refactor#69cfd4ac9b3f313214e635cb292812813a694ba4"
dependencies = [
"cc 1.0.18 (registry+https://github.com/rust-lang/crates.io-index)",
"integer-atomics 1.0.2 (registry+https://github.com/rust-lang/crates.io-index)", |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@jdm this appears to work well in FxR. |
This comment has been minimized.
This comment has been minimized.
|
highfive
added
the
S-needs-rebase
label
Dec 29, 2018
jdm
force-pushed the
jdm:runtime-parent
branch
4 times, most recently
from
89344e7
to
e3a1190
Jan 14, 2019
jdm
removed
S-blocked-on-external
S-needs-rebase
labels
Jan 15, 2019
This comment has been minimized.
This comment has been minimized.
r? @nox |
highfive
assigned
nox
and unassigned
avadacatavra
Jan 15, 2019
jdm
force-pushed the
jdm:runtime-parent
branch
from
e3a1190
to
ce56f79
Jan 15, 2019
jdm
force-pushed the
jdm:runtime-parent
branch
2 times, most recently
from
0940e9f
to
ac606fc
Jan 15, 2019
This comment has been minimized.
This comment has been minimized.
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14868. |
jdm
added some commits
Dec 2, 2018
jdm
force-pushed the
jdm:runtime-parent
branch
from
ac606fc
to
367014a
Jan 15, 2019
This comment has been minimized.
This comment has been minimized.
No upstreamable changes; closed existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14868. |
jdm
referenced this pull request
Jan 17, 2019
Closed
Headless testing (webdriver) causes servo crash on 5th (was 12th) load/screenshot operation #20015
This comment has been minimized.
This comment has been minimized.
@bors-servo r+ |
This comment has been minimized.
This comment has been minimized.
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
labels
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
|
jdm commentedDec 2, 2018
•
edited by SimonSapin
These changes adjust our uses of the rust-mozjs APIs to accommodate the changes in servo/rust-mozjs#450.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is