New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DuckDuckGo HTML search #22354

Merged
merged 3 commits into from Dec 22, 2018

Conversation

Projects
None yet
8 participants
@jdm
Copy link
Member

jdm commented Dec 3, 2018

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22090
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 3, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlformelement.rs
  • @KiChjang: components/script/dom/htmlformelement.rs, components/net/http_loader.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Dec 3, 2018

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 3, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 3, 2018

⌛️ Trying commit ba27903 with merge ff765f1...

bors-servo added a commit that referenced this pull request Dec 3, 2018

Auto merge of #22354 - jdm:ddg, r=<try>
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [ ] There are tests for these changes
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 3, 2018

💔 Test failed - linux-rel-wpt

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Dec 3, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14344.

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 3, 2018

I can't test the Origin header change meaningfully, unfortunately, since the WPT tests run on ports 8000 and 8443 by default.

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 8, 2018

r? @nox

@highfive highfive assigned nox and unassigned emilio Dec 8, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 14, 2018

@@ -6,5 +6,7 @@ def main(request, response):
else:
result = request.POST.first('foo') == 'bar'

results = result and request.url_parts.query == 'query=1'

This comment has been minimized.

@Manishearth

Manishearth Dec 14, 2018

Member

results isn't used at all here

This comment has been minimized.

@jdm

jdm Dec 14, 2018

Member

Aieee.

@jdm jdm force-pushed the jdm:ddg branch from 215f576 to 88dfd14 Dec 14, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 14, 2018

@bors-servo try=wpt

@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Dec 14, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14344.

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 14, 2018

@bors-servo retry

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 14, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 14, 2018

😪 I'm awake I'm awake

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 14, 2018

@bors-servo try=wpt try-

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 14, 2018

@bors-servo clean try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 14, 2018

⌛️ Trying commit 88dfd14 with merge d9e2a01...

bors-servo added a commit that referenced this pull request Dec 14, 2018

Auto merge of #22354 - jdm:ddg, r=<try>
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Dec 18, 2018

Auto merge of #22354 - jdm:ddg, r=manishearth
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

💔 Test failed - status-taskcluster

@CYBAI

This comment has been minimized.

Copy link
Collaborator

CYBAI commented Dec 19, 2018

@bors-servo retry

{
    "status": "CRASH", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/html/syntax/parsing/html5lib_menuitem-element.html?run_type=uri", 
    "line": 134340, 
    "action": "test_result", 
    "expected": "OK"
}
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 19, 2018

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 19, 2018

⌛️ Testing commit 1c7cfaf with merge c1f45cb...

bors-servo added a commit that referenced this pull request Dec 19, 2018

Auto merge of #22354 - jdm:ddg, r=manishearth
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 19, 2018

💔 Test failed - status-taskcluster

@CYBAI

This comment has been minimized.

Copy link
Collaborator

CYBAI commented Dec 19, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 19, 2018

@bors-servo r-
Emptying the queue so #22493 can merge easily.

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 22, 2018

@bors-servo retry

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 22, 2018

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 22, 2018

📌 Commit 1c7cfaf has been approved by Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 22, 2018

⌛️ Testing commit 1c7cfaf with merge 9caf215...

bors-servo added a commit that referenced this pull request Dec 22, 2018

Auto merge of #22354 - jdm:ddg, r=Manishearth
Fix DuckDuckGo HTML search

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22090
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 22, 2018

@bors-servo bors-servo merged commit 1c7cfaf into servo:master Dec 22, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Dec 22, 2018

Error syncing changes upstream. Logs saved in error-snapshot-1545458945633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment