Fix DuckDuckGo HTML search #22354

jdm · 2018-12-03T06:47:02Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22090
There are tests for these changes

This change is


        net: Log HTTP request headers.

highfive · 2018-12-03T06:47:07Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmlformelement.rs
@KiChjang: components/script/dom/htmlformelement.rs, components/net/http_loader.rs

highfive · 2018-12-03T06:47:08Z

Warning

These commits modify net and script code, but no tests are modified. Please consider adding a test!

jdm · 2018-12-03T06:47:09Z

@bors-servo try=wpt

bors-servo · 2018-12-03T06:47:14Z

⌛ Trying commit ba27903 with merge ff765f1...


        Auto merge of #22354 - jdm:ddg, r=<try>

Fix DuckDuckGo HTML search - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22090 - [ ] There are tests for these changes

bors-servo · 2018-12-03T07:15:26Z

💔 Test failed - linux-rel-wpt

servo-wpt-sync · 2018-12-03T20:03:38Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14344.

jdm · 2018-12-03T20:18:55Z

I can't test the Origin header change meaningfully, unfortunately, since the WPT tests run on ports 8000 and 8443 by default.

jdm · 2018-12-08T10:44:50Z

r? @nox

jdm · 2018-12-14T16:08:54Z

r? @Manishearth

Manishearth · 2018-12-14T17:44:50Z

tests/wpt/web-platform-tests/common/form-submission.py

@@ -6,5 +6,7 @@ def main(request, response):
    else:
        result = request.POST.first('foo') == 'bar'

+    results = result and request.url_parts.query == 'query=1'


results isn't used at all here

jdm · 2018-12-14T17:59:38Z

@bors-servo try=wpt

servo-wpt-sync · 2018-12-14T18:00:50Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14344.

jdm · 2018-12-14T18:28:40Z

@bors-servo retry

jdm · 2018-12-14T18:28:54Z

@bors-servo ping

bors-servo · 2018-12-14T18:28:55Z

😪 I'm awake I'm awake

jdm · 2018-12-14T18:29:13Z

@bors-servo try=wpt try-

jdm · 2018-12-14T18:29:37Z

@bors-servo clean try=wpt

bors-servo · 2018-12-14T18:31:13Z

⌛ Trying commit 88dfd14 with merge d9e2a01...


        Auto merge of #22354 - jdm:ddg, r=<try>

Fix DuckDuckGo HTML search - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22090 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)


        Auto merge of #22354 - jdm:ddg, r=manishearth

Fix DuckDuckGo HTML search - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22090 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)

bors-servo · 2018-12-18T15:47:46Z

💔 Test failed - status-taskcluster

CYBAI · 2018-12-19T02:18:21Z

@bors-servo retry

{
    "status": "CRASH", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/html/syntax/parsing/html5lib_menuitem-element.html?run_type=uri", 
    "line": 134340, 
    "action": "test_result", 
    "expected": "OK"
}

bors-servo · 2018-12-19T02:18:24Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2018-12-19T02:18:32Z

⌛ Testing commit 1c7cfaf with merge c1f45cb...


        Auto merge of #22354 - jdm:ddg, r=manishearth

Fix DuckDuckGo HTML search - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22090 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)

bors-servo · 2018-12-19T02:45:07Z

💔 Test failed - status-taskcluster

CYBAI · 2018-12-19T02:53:09Z

@bors-servo retry

#22492

jdm · 2018-12-19T04:08:07Z

@bors-servo r-
Emptying the queue so #22493 can merge easily.

jdm · 2018-12-22T04:07:03Z

@bors-servo retry

jdm · 2018-12-22T04:08:50Z

@bors-servo r=Manishearth

bors-servo · 2018-12-22T04:08:50Z

📌 Commit 1c7cfaf has been approved by Manishearth

bors-servo · 2018-12-22T04:32:16Z

⌛ Testing commit 1c7cfaf with merge 9caf215...


        Auto merge of #22354 - jdm:ddg, r=Manishearth

Fix DuckDuckGo HTML search - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22090 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22354)

bors-servo · 2018-12-22T06:06:56Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: Manishearth
Pushing 9caf215 to master...

servo-wpt-sync · 2018-12-22T06:07:15Z

Error syncing changes upstream. Logs saved in error-snapshot-1545458945633.

net: Log HTTP request headers.

bf564ca

highfive assigned emilio Dec 3, 2018

highfive added the S-awaiting-review label Dec 3, 2018

highfive added the S-tests-failed label Dec 3, 2018

jdm force-pushed the jdm:ddg branch from ba27903 to 215f576 Dec 3, 2018

highfive removed the S-tests-failed label Dec 3, 2018

servo-wpt-sync mentioned this pull request Dec 3, 2018

Fix DuckDuckGo HTML search web-platform-tests/wpt#14344

Merged

highfive assigned nox and unassigned emilio Dec 8, 2018

Manishearth approved these changes Dec 14, 2018

View changes

jdm force-pushed the jdm:ddg branch from 215f576 to 88dfd14 Dec 14, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 18, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 18, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 19, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 19, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 22, 2018

bors-servo merged commit 1c7cfaf into servo:master Dec 22, 2018
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Dec 22, 2018

bors-servo mentioned this pull request Dec 22, 2018

Sync WPT with upstream (21-12-2018) #22529

Closed

bors-servo mentioned this pull request Dec 22, 2018

Reduce intermittent failures for taskcluster #22493

Closed

servo / servo

Fix DuckDuckGo HTML search #22354

Fix DuckDuckGo HTML search #22354

jdm commented Dec 3, 2018 •

edited

highfive commented Dec 3, 2018

highfive commented Dec 3, 2018

jdm commented Dec 3, 2018

bors-servo commented Dec 3, 2018

bors-servo commented Dec 3, 2018

servo-wpt-sync commented Dec 3, 2018

jdm commented Dec 3, 2018

jdm commented Dec 8, 2018

jdm commented Dec 14, 2018

This comment has been minimized.

This comment has been minimized.

jdm commented Dec 14, 2018

servo-wpt-sync commented Dec 14, 2018

jdm commented Dec 14, 2018

jdm commented Dec 14, 2018

bors-servo commented Dec 14, 2018

jdm commented Dec 14, 2018

jdm commented Dec 14, 2018

bors-servo commented Dec 14, 2018

bors-servo commented Dec 18, 2018

CYBAI commented Dec 19, 2018

bors-servo commented Dec 19, 2018

bors-servo commented Dec 19, 2018

bors-servo commented Dec 19, 2018

CYBAI commented Dec 19, 2018

jdm commented Dec 19, 2018

jdm commented Dec 22, 2018

jdm commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

servo-wpt-sync commented Dec 22, 2018

servo / servo

Join GitHub today

Fix DuckDuckGo HTML search #22354

Fix DuckDuckGo HTML search #22354

Conversation

jdm commented Dec 3, 2018 • edited

highfive commented Dec 3, 2018

highfive commented Dec 3, 2018

jdm commented Dec 3, 2018

bors-servo commented Dec 3, 2018

bors-servo commented Dec 3, 2018

servo-wpt-sync commented Dec 3, 2018

jdm commented Dec 3, 2018

jdm commented Dec 8, 2018

jdm commented Dec 14, 2018

This comment has been minimized.

Manishearth Dec 14, 2018

This comment has been minimized.

jdm Dec 14, 2018

jdm commented Dec 14, 2018

servo-wpt-sync commented Dec 14, 2018

jdm commented Dec 14, 2018

jdm commented Dec 14, 2018

bors-servo commented Dec 14, 2018

jdm commented Dec 14, 2018

jdm commented Dec 14, 2018

bors-servo commented Dec 14, 2018

bors-servo commented Dec 18, 2018

CYBAI commented Dec 19, 2018

bors-servo commented Dec 19, 2018

bors-servo commented Dec 19, 2018

bors-servo commented Dec 19, 2018

CYBAI commented Dec 19, 2018

jdm commented Dec 19, 2018

jdm commented Dec 22, 2018

jdm commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

servo-wpt-sync commented Dec 22, 2018

jdm commented Dec 3, 2018 •

edited