Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for image reloading bug #22356

Merged
merged 1 commit into from Dec 11, 2018
Merged

Add missing test for image reloading bug #22356

merged 1 commit into from Dec 11, 2018

Conversation

@jdm
Copy link
Member

jdm commented Dec 3, 2018 •
edited by SimonSapin

This adds an automated test for #22336.

This change is Reviewable
@servo-wpt-sync servo-wpt-sync mentioned this pull request Dec 3, 2018
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Dec 3, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14347.
@Manishearth
Manishearth reviewed Dec 6, 2018
View changes
...-platform-tests/html/semantics/embedded-content/the-img-element/available-images-onload.html
@@ -0,0 +1,26 @@
<!doctype html>
<html>
<title>Ensure images from available images list can be drawn to a canvas</title>

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Dec 6, 2018 •
edited

Member

spec link about available images list?

we should perhaps explain what can go wrong here in a comment somewhere
@Manishearth
Manishearth approved these changes Dec 6, 2018
View changes
@jdm
Add a test for dealing with multiple image loading tasks when the lis…
Loading status checks…
037d8dd 
…t of available images is usable.
@jdm jdm force-pushed the jdm:image-reload-test branch from c9e0fff to 037d8dd Dec 10, 2018
@jdm
Copy link
Member Author

jdm commented Dec 10, 2018

@bors-servo r=Manishearth
@highfive highfive assigned Manishearth and unassigned nox Dec 10, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2018

📌 Commit 037d8dd has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2018

⌛ Testing commit 037d8dd with merge ccdc060...
bors-servo added a commit that referenced this pull request Dec 10, 2018
@bors-servo
Auto merge of #22356 - jdm:image-reload-test, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ccdc060 
Add missing test for image reloading bug

This adds an automated test for #22336.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22356)
<!-- Reviewable:end -->
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Dec 10, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14347.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2018

💔 Test failed - linux-dev
@jdm
Copy link
Member Author

jdm commented Dec 10, 2018

@bors-servo retry

  • cleaned up linux-dev build directory on servo-linux4
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2018

⌛ Testing commit 037d8dd with merge 91ed4a7...
bors-servo added a commit that referenced this pull request Dec 10, 2018
@bors-servo
Auto merge of #22356 - jdm:image-reload-test, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91ed4a7 
Add missing test for image reloading bug

This adds an automated test for #22336.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22356)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Dec 10, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2018

⌛ Testing commit 037d8dd with merge 9980d6a...
bors-servo added a commit that referenced this pull request Dec 11, 2018
@bors-servo
Auto merge of #22356 - jdm:image-reload-test, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9980d6a 
Add missing test for image reloading bug

This adds an automated test for #22336.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22356)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: Manishearth
Pushing 9980d6a to master...
@bors-servo bors-servo merged commit 037d8dd into servo:master Dec 11, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @servo-wpt-sync @bors-servo @Manishearth @nox @highfive
You can’t perform that action at this time.