Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.33.0-nightly (fb86d604b 2018-12-27) #22385

Merged
merged 3 commits into from Dec 31, 2018
Merged

Upgrade to rustc 1.33.0-nightly (fb86d604b 2018-12-27) #22385

merged 3 commits into from Dec 31, 2018
+1,219 −1,367

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 8, 2018 •
edited

This change is Reviewable
@highfive
Copy link

highfive commented Dec 8, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml, components/net_traits/Cargo.toml
@highfive
Copy link

highfive commented Dec 8, 2018

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 8, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2018

📌 Commit 6339ff7 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned avadacatavra Dec 8, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2018

⌛ Testing commit 6339ff7 with merge aa1af2d...
bors-servo added a commit that referenced this pull request Dec 8, 2018
@bors-servo
Auto merge of #22385 - servo:rustup, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa1af2d 
Upgrade to rustc 1.32.0-nightly (4a45578bc 2018-12-07)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22385)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2018

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 8, 2018 

$ rustup component add rustfmt
error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download

This will need to wait for a nightly that has rustfmt. https://rust-lang-nursery.github.io/rust-toolstate/ tracks status.
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 12, 2018

Rustfmt is fixed, now waiting for the next Nightly: rust-lang/rust#56667
@SimonSapin SimonSapin force-pushed the rustup branch from 6339ff7 to 23a84e5 Dec 14, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 14, 2018

There’s a new Nightly! But rustfmt has changed its default style, and we get a thousand-line diff :/

r? @jdm
@SimonSapin SimonSapin changed the title Upgrade to rustc 1.32.0-nightly (4a45578bc 2018-12-07) Upgrade to rustc 1.32.0-nightly (f4a421ee3 2018-12-13) Dec 14, 2018
@KiChjang
Copy link
Member

KiChjang commented Dec 14, 2018

This new default format style made a whole lot more sense to me.
@jdm
Copy link
Member

jdm commented Dec 14, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2018

📌 Commit 23a84e5 has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Dec 14, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2018

⌛ Testing commit 23a84e5 with merge dec9387...
@SimonSapin
Fix some warnings
Loading status checks…
be2218a
@SimonSapin SimonSapin force-pushed the rustup branch from afdcbd5 to be2218a Dec 28, 2018
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 28, 2018

Up to what point are blind fixes easier than figuring out how to get the ML SDK?

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 28, 2018

📌 Commit be2218a has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 28, 2018

⌛ Testing commit be2218a with merge ef49d01...
bors-servo added a commit that referenced this pull request Dec 28, 2018
@bors-servo
Auto merge of #22385 - servo:rustup, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ef49d01 
Upgrade to rustc 1.33.0-nightly (fb86d604b 2018-12-27)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22385)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 28, 2018

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Dec 31, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2018

⌛ Testing commit be2218a with merge 8de1b8d...
bors-servo added a commit that referenced this pull request Dec 31, 2018
@bors-servo
Auto merge of #22385 - servo:rustup, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8de1b8d 
Upgrade to rustc 1.33.0-nightly (fb86d604b 2018-12-27)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22385)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2018

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: SimonSapin
Pushing 8de1b8d to master...
@bors-servo bors-servo merged commit be2218a into master Dec 31, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Dec 31, 2018
Closed
Merged
@SimonSapin SimonSapin deleted the rustup branch Jan 1, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 7, 2019
@SimonSapin @emilio
Bug 1518045 - Rustfmt has changed its default style. r=emilio
81312a1 
This cherry-picks the formatting parts of
servo/servo#22385.
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jan 7, 2019
@SimonSapin @emilio
Bug 1518045 - Rustfmt has changed its default style. r=emilio
da0d9ba 
This cherry-picks the formatting parts of
servo/servo#22385.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1518045 - Rustfmt has changed its default style. r=emilio
26c3dcd 
This cherry-picks the formatting parts of
servo/servo#22385.

UltraBlame original commit: c62ba89a005dc61b5bc627c6779dd780609eadab
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1518045 - Rustfmt has changed its default style. r=emilio
e6adb55 
This cherry-picks the formatting parts of
servo/servo#22385.

UltraBlame original commit: c62ba89a005dc61b5bc627c6779dd780609eadab
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1518045 - Rustfmt has changed its default style. r=emilio
5428495 
This cherry-picks the formatting parts of
servo/servo#22385.

UltraBlame original commit: c62ba89a005dc61b5bc627c6779dd780609eadab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @bors-servo @KiChjang @jdm @avadacatavra
You can’t perform that action at this time.