New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the base Ubuntu distro instead of LinuxMint in './mach bootstrap' #22386

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
4 participants
@cdeler
Copy link
Contributor

cdeler commented Dec 8, 2018

I'm LinuxMint user.

I couldn't install all dependencies via ./mach bootstrap due to error, described in this ticket: #21732

As LinuxMint is based on the stable Ubuntu, I've made a little fix for the bootstrap procedure.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #21732 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because I haven't found the tests for ./mach bootstrap (please correct me if I'm wrong)

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 8, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 8, 2018

Heads up! This PR modifies the following files:

@cdeler cdeler force-pushed the cdeler:fix-mach-bootstrap-LinuxMint branch from 72d9bbf to 7ceabce Dec 8, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 8, 2018

@bors-servo r+
Thanks!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

📌 Commit 7ceabce has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

⌛️ Testing commit 7ceabce with merge 8fb1b56...

bors-servo added a commit that referenced this pull request Dec 8, 2018

Auto merge of #22386 - cdeler:fix-mach-bootstrap-LinuxMint, r=jdm
Use the base Ubuntu distro instead of LinuxMint in './mach bootstrap'

I'm LinuxMint user.

I couldn't install all dependencies via `./mach bootstrap` due to error, described in this ticket: #21732

As LinuxMint is based on the stable Ubuntu, I've made a little fix for the `bootstrap` procedure.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21732 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I haven't found the tests for `./mach bootstrap` (please correct me if I'm wrong)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22386)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit 7ceabce into servo:master Dec 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment