New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel animations that affect nodes that do not participate in layout. #22389

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
6 participants
@jdm
Copy link
Member

jdm commented Dec 8, 2018

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22378
  • There are tests for these changes

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 8, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/Window.webidl, components/script/dom/window.rs
  • @KiChjang: components/script/dom/webidls/Window.webidl, components/script/dom/window.rs
  • @emilio: components/layout/animation.rs
@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 8, 2018

r? @ferjm

@highfive highfive assigned ferjm and unassigned paulrouget Dec 8, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 8, 2018

@bors-servo try=wpt

bors-servo added a commit that referenced this pull request Dec 8, 2018

Auto merge of #22389 - jdm:anim-complete, r=<try>
Cancel animations that affect nodes that do not participate in layout.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22378
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

⌛️ Trying commit e43900a with merge 45141a4...

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

💔 Test failed - linux-rel-css

@jdm jdm force-pushed the jdm:anim-complete branch from e43900a to f0f0e68 Dec 8, 2018

@highfive highfive removed the S-tests-failed label Dec 8, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 8, 2018

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

⌛️ Trying commit f0f0e68 with merge fd60a9c...

bors-servo added a commit that referenced this pull request Dec 8, 2018

Auto merge of #22389 - jdm:anim-complete, r=<try>
Cancel animations that affect nodes that do not participate in layout.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22378
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 8, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

⌛️ Trying commit f0f0e68 with merge 067b268...

bors-servo added a commit that referenced this pull request Dec 8, 2018

Auto merge of #22389 - jdm:anim-complete, r=<try>
Cancel animations that affect nodes that do not participate in layout.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22378
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389)
<!-- Reviewable:end -->

partial interface Window {
[Pref="css.animations.testing.enabled"]
readonly attribute unsigned long runningAnimations;

This comment has been minimized.

@emilio

emilio Dec 8, 2018

Member

runningAnimationCount?

where
E: TElement,
{
let mut invalid_nodes = FxHashSet::default();

This comment has been minimized.

@emilio

emilio Dec 8, 2018

Member

animations.keys().collect()?

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 8, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt
State: approved= try=True

@ferjm

ferjm approved these changes Dec 10, 2018

Copy link
Member

ferjm left a comment

LGTM with @emilio's comments addressed. Thanks!

@ferjm

This comment has been minimized.

Copy link
Member

ferjm commented Dec 10, 2018

We need to make tidy happy before merging as well.

@jdm jdm force-pushed the jdm:anim-complete branch from f0f0e68 to 8796067 Dec 10, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 10, 2018

@bors-servo r=emilio,ferjm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 10, 2018

📌 Commit 8796067 has been approved by emilio,ferjm

@highfive highfive assigned emilio and unassigned ferjm Dec 10, 2018

bors-servo added a commit that referenced this pull request Dec 10, 2018

Auto merge of #22389 - jdm:anim-complete, r=emilio,ferjm
Cancel animations that affect nodes that do not participate in layout.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22378
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 10, 2018

⌛️ Testing commit 8796067 with merge e0103f3...

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 10, 2018

💔 Test failed - linux-rel-wpt

@jdm jdm force-pushed the jdm:anim-complete branch from 8796067 to ed74b89 Dec 10, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 10, 2018

@bors-servo r=emilio,ferjm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 10, 2018

📌 Commit ed74b89 has been approved by emilio,ferjm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 10, 2018

⌛️ Testing commit ed74b89 with merge 42a620a...

bors-servo added a commit that referenced this pull request Dec 10, 2018

Auto merge of #22389 - jdm:anim-complete, r=emilio,ferjm
Cancel animations that affect nodes that do not participate in layout.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22378
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389)
<!-- Reviewable:end -->
@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 10, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 10, 2018

⌛️ Testing commit ed74b89 with merge eeaca0b...

bors-servo added a commit that referenced this pull request Dec 10, 2018

Auto merge of #22389 - jdm:anim-complete, r=emilio,ferjm
Cancel animations that affect nodes that do not participate in layout.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22378
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22389)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 11, 2018

@bors-servo bors-servo merged commit ed74b89 into servo:master Dec 11, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment