Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link DOMImplementation to owner Document rather than Window #2239

Closed
wants to merge 1 commit into from

Conversation

@caitp
Copy link

caitp commented Apr 27, 2014

This matches implementations in Blink and WebKit, and passes an extra 14
web-platform-tests.

Closes #2230

@highfive
Copy link

highfive commented Apr 27, 2014

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 27, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1396

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

This matches implementations in Blink and WebKit, and passes an extra 14 web-platform-tests.

Closes #2230
@metajack metajack closed this May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.