Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor pull request template cleanup #22391

Merged
merged 1 commit into from Dec 9, 2018
Merged

Minor pull request template cleanup #22391

merged 1 commit into from Dec 9, 2018

Conversation

@atouchet
Copy link
Contributor

atouchet commented Dec 8, 2018 •
edited by SimonSapin

Some minor changes to improve the consistency of the pull request template.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@atouchet
Minor pull request template cleanup
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6dce40d
@jdm
Copy link
Member

jdm commented Dec 8, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2018

📌 Commit 6dce40d has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Dec 8, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2018

⌛ Testing commit 6dce40d with merge 25e86a7...
bors-servo added a commit that referenced this pull request Dec 8, 2018
@bors-servo
Auto merge of #22391 - atouchet:prt, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
25e86a7 
Minor pull request template cleanup

<!-- Please describe your changes on the following line: -->
Some minor changes to improve the consistency of the pull request template.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22391)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2018

💔 Test failed - mac-rel-css1
@KiChjang
Copy link
Member

KiChjang commented Dec 8, 2018

not cool
@KiChjang
Copy link
Member

KiChjang commented Dec 8, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2018

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented Dec 9, 2018

@bors-servo retry

  • cleaned up old servo processes on servo-mac8
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2018

⚡ Previous build results for android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev are reusable. Rebuilding only mac-rel-css1...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2018

💔 Test failed - mac-rel-css1
@jdm
Copy link
Member

jdm commented Dec 9, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2018

⌛ Testing commit 6dce40d with merge f370fdf...
bors-servo added a commit that referenced this pull request Dec 9, 2018
@bors-servo
Auto merge of #22391 - atouchet:prt, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f370fdf 
Minor pull request template cleanup

<!-- Please describe your changes on the following line: -->
Some minor changes to improve the consistency of the pull request template.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22391)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: jdm
Pushing f370fdf to master...
@bors-servo bors-servo merged commit 6dce40d into servo:master Dec 9, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@atouchet atouchet deleted the atouchet:prt branch Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@atouchet @jdm @bors-servo @KiChjang @ferjm @highfive
You can’t perform that action at this time.