Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize iframe viewport immediately #22395

Merged
merged 5 commits into from Dec 18, 2018
Prev

mac: Treat CT returning 0 glyph indexes as failing to find indexes.

  • Loading branch information
jdm committed Dec 14, 2018
commit 496e2f621d0c903bbcb4a74684e2bc38850671de
@@ -239,15 +239,14 @@ impl FontHandleMethods for FontHandle {

let result = unsafe {
self.ctfont
.get_glyphs_for_characters(&characters[0], &mut glyphs[0], count)
.get_glyphs_for_characters(characters.as_ptr(), glyphs.as_mut_ptr(), count)
};

if !result {
if !result || glyphs[0] == 0 {
// No glyph for this character
return None;
}

assert_ne!(glyphs[0], 0); // FIXME: error handling
return Some(glyphs[0] as GlyphId);
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.