Implement HTMLMediaElement poster attribute #22399

ferjm · 2018-12-10T14:53:49Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22288
There are tests for these changes

This change is

highfive · 2018-12-10T14:53:53Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmlvideoelement.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/webidls/HTMLVideoElement.webidl
@KiChjang: components/script/dom/htmlvideoelement.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/webidls/HTMLVideoElement.webidl

highfive · 2018-12-10T14:53:56Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

ferjm · 2018-12-11T17:20:37Z

@bors-servo try=wpt

bors-servo · 2018-12-11T17:20:43Z

⌛ Trying commit 74b9d9e with merge 8de190f...


        Auto merge of #22399 - ferjm:poster.frame, r=<try>

WIP Implement HTMLMediaElement poster attribute - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #22288 - [ ] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22399)

bors-servo · 2018-12-11T17:53:12Z

💔 Test failed - linux-rel-wpt

ferjm · 2018-12-11T22:03:20Z

r? @jdm

bors-servo · 2018-12-13T00:56:37Z

☔ The latest upstream changes (presumably #22433) made this pull request unmergeable. Please resolve the merge conflicts.

jdm

Can we add a reftest that compares a paused video with a poster attribute against a page with an image element?

components/script/dom/htmlmediaelement.rs

components/script/dom/htmlvideoelement.rs

components/script/dom/htmlmediaelement.rs

components/script/dom/htmlvideoelement.rs

bors-servo · 2019-01-14T10:45:23Z

⌛ Testing commit 4e286ff with merge f759959...


        Auto merge of #22399 - ferjm:poster.frame, r=jdm

Implement HTMLMediaElement poster attribute - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22288 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22399)

bors-servo · 2019-01-14T11:12:28Z

💔 Test failed - linux-rel-wpt

jdm · 2019-01-14T16:15:01Z

  ▶ TIMEOUT [expected OK] /resource-timing/resource_initiator_types.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 18.3.0-devel
  │ 0:00:00.054561787 124407 0x7f43a802e230 WARN                typefind gsttypefindelement.c:856:gst_type_find_get_extension:<typefind> could not find uri extension in appsrc://
  │ 0:00:00.074380640 124407 0x7f439c0030a0 WARN                typefind gsttypefindelement.c:856:gst_type_find_get_extension:<typefind> could not find uri extension in appsrc://
  │ 0:00:00.083655392 124407 0x7f43a802e230 WARN                 qtdemux qtdemux.c:3154:qtdemux_parse_trex:<qtdemux0> failed to find fragment defaults for stream 1
  │ 0:00:00.083719707 124407 0x7f439c0030a0 WARN                 qtdemux qtdemux.c:3154:qtdemux_parse_trex:<qtdemux1> failed to find fragment defaults for stream 1
  │ 0:00:00.083758015 124407 0x7f43a802e230 WARN                 qtdemux qtdemux.c:3154:qtdemux_parse_trex:<qtdemux0> failed to find fragment defaults for stream 2
  │ 0:00:00.083783753 124407 0x7f439c0030a0 WARN                 qtdemux qtdemux.c:3154:qtdemux_parse_trex:<qtdemux1> failed to find fragment defaults for stream 2
  │ 0:00:00.087888372 124407 0x7f43a802e230 WARN                 default oss4-property-probe.c:303:gst_oss4_property_probe_get_values:<oss4sink0> Can't open file descriptor to probe available devices: No such file or directory
  │ 0:00:00.088150220 124407 0x7f43a802e230 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<oss4sink0> error: Could not open audio device for playback.
  │ 0:00:00.087894828 124407 0x7f439c0030a0 WARN                 default oss4-property-probe.c:303:gst_oss4_property_probe_get_values:<oss4sink1> Can't open file descriptor to probe available devices: No such file or directory
  │ 0:00:00.088646959 124407 0x7f439c0030a0 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<oss4sink1> error: Could not open audio device for playback.
  │ 0:00:00.088755785 124407 0x7f439c0030a0 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<oss4sink1> error: system error: No such file or directory
  │ 0:00:00.088853397 124407 0x7f439c0030a0 WARN                 playbin gstplaybin2.c:4663:autoplug_select_cb:<playbin> Could not activate sink oss4sink
  │ 0:00:00.089216375 124407 0x7f43a802e230 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<oss4sink0> error: system error: No such file or directory
  │ 0:00:00.089400439 124407 0x7f43a802e230 WARN                 playbin gstplaybin2.c:4663:autoplug_select_cb:<playbin> Could not activate sink oss4sink
  │ 0:00:00.089864409 124407 0x7f43a802e230 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<osssink1> error: Could not open audio device for playback.
  │ 0:00:00.089974637 124407 0x7f43a802e230 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<osssink1> error: system error: No such file or directory
  │ 0:00:00.090166638 124407 0x7f43a802e230 WARN                 playbin gstplaybin2.c:4663:autoplug_select_cb:<playbin> Could not activate sink osssink
  │ 0:00:00.090508757 124407 0x7f439c0030a0 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<osssink0> error: Could not open audio device for playback.
  │ 0:00:00.090527999 124407 0x7f439c0030a0 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<osssink0> error: system error: No such file or directory
  │ 0:00:00.090583580 124407 0x7f439c0030a0 WARN                 playbin gstplaybin2.c:4663:autoplug_select_cb:<playbin> Could not activate sink osssink
  │ 0:00:00.116693011 124407 0x7f44641405e0 FIXME                    bin gstbin.c:4337:gst_bin_query: implement duration caching in GstBin again
  │ 0:00:00.168474247 124407 0x7f43b814c590 WARN                 default oss4-property-probe.c:303:gst_oss4_property_probe_get_values:<audiosink-actual-sink-oss4> Can't open file descriptor to probe available devices: No such file or directory
  │ 0:00:00.168546586 124407 0x7f43b814c590 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<audiosink-actual-sink-oss4> error: Could not open audio device for playback.
  │ 0:00:00.168555585 124407 0x7f43b814c590 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<audiosink-actual-sink-oss4> error: system error: No such file or directory
  │ 0:00:00.168652628 124407 0x7f43b814c590 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<audiosink-actual-sink-oss> error: Could not open audio device for playback.
  │ 0:00:00.168661041 124407 0x7f43b814c590 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<audiosink-actual-sink-oss> error: system error: No such file or directory
  │ 0:00:00.174282737 124407 0x7f446412f8f0 WARN                 default oss4-property-probe.c:303:gst_oss4_property_probe_get_values:<audiosink-actual-sink-oss4> Can't open file descriptor to probe available devices: No such file or directory
  │ 0:00:00.174468943 124407 0x7f446412f8f0 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<audiosink-actual-sink-oss4> error: Could not open audio device for playback.
  │ 0:00:00.174573609 124407 0x7f446412f8f0 WARN                oss4sink oss4-sink.c:514:gst_oss4_sink_open:<audiosink-actual-sink-oss4> error: system error: No such file or directory
  │ 0:00:00.174797488 124407 0x7f446412f8f0 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<audiosink-actual-sink-oss> error: Could not open audio device for playback.
  │ 0:00:00.174909927 124407 0x7f446412f8f0 WARN                     oss gstosssink.c:399:gst_oss_sink_open:<audiosink-actual-sink-oss> error: system error: No such file or directory
  │ 0:00:05.192981034 124407 0x7f43b814c590 WARN                   libav gstavauddec.c:630:gst_ffmpegauddec_drain:<avdec_aac0> send packet failed, could not drain decoder
  └ 0:00:05.197381213 124407 0x7f43840039e0 WARN                   libav gstavauddec.c:630:gst_ffmpegauddec_drain:<avdec_aac1> send packet failed, could not drain decoder


        Make poster frame load blocker independent from media element's one

ferjm · 2019-01-14T21:35:19Z

The last commit fixes the timeout. We need independent load blockers. r? @jdm

jdm · 2019-01-14T21:40:44Z

components/script/dom/htmlvideoelement.rs

+        // <video poster="poster.png"></video>
+        // (which triggers no media load algorithm unless a explicit call to .load() is done)
+        // will block the document's load event forever.
+        let mut blocker = self.load_blocker.borrow_mut();


Does this still work correctly if we switch the poster attribute value while the poster is loading? I think we probably need to call LoadBlocker::terminate.

Good point. Done.


        Terminate poster frame load blocker before blocking again

jdm · 2019-01-14T22:09:50Z

@bors-servo r+

bors-servo · 2019-01-14T22:09:50Z

📌 Commit 7633cab has been approved by jdm

bors-servo · 2019-01-14T22:35:25Z

⌛ Testing commit 7633cab with merge 2cf9a00...


        Auto merge of #22399 - ferjm:poster.frame, r=jdm

Implement HTMLMediaElement poster attribute - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22288 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22399)

bors-servo · 2019-01-15T00:12:55Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 2cf9a00 to master...

highfive assigned SimonSapin Dec 10, 2018

highfive added the S-awaiting-review label Dec 10, 2018

highfive added the S-tests-failed label Dec 11, 2018

ferjm force-pushed the ferjm:poster.frame branch from 74b9d9e to 909979b Dec 11, 2018

highfive removed the S-tests-failed label Dec 11, 2018

ferjm force-pushed the ferjm:poster.frame branch from 909979b to e07be5c Dec 11, 2018

ferjm changed the title ~~WIP Implement HTMLMediaElement poster attribute~~ Implement HTMLMediaElement poster attribute Dec 11, 2018

ferjm force-pushed the ferjm:poster.frame branch from e07be5c to 026a5b9 Dec 11, 2018

highfive assigned jdm and unassigned SimonSapin Dec 11, 2018

highfive added the S-needs-rebase label Dec 13, 2018

jdm requested changes Dec 13, 2018

View changes

jdm added S-needs-code-changes S-needs-rebase and removed S-awaiting-review S-needs-rebase labels Dec 13, 2018

ferjm force-pushed the ferjm:poster.frame branch from 026a5b9 to 4e193bb Dec 21, 2018

highfive added S-awaiting-review and removed S-needs-code-changes labels Dec 21, 2018

jdm removed the S-needs-rebase label Dec 21, 2018

jdm approved these changes Dec 21, 2018

View changes

components/script/dom/htmlvideoelement.rs Outdated Show resolved Hide resolved

jdm added the S-needs-code-changes label Dec 21, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 14, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 14, 2019

ferjm mentioned this pull request Jan 14, 2019

Intermittent timout in resource-timing/resource_initiator_types.html #22683

Closed

Make poster frame load blocker independent from media element's one

Loading status checks…

fde7d45

highfive added S-awaiting-review and removed S-tests-failed labels Jan 14, 2019

jdm reviewed Jan 14, 2019

View changes

jdm added S-awaiting-answer and removed S-awaiting-review labels Jan 14, 2019

Terminate poster frame load blocker before blocking again

Loading status checks…

7633cab

highfive added the S-awaiting-review label Jan 14, 2019

highfive added S-awaiting-merge and removed S-awaiting-review S-awaiting-answer labels Jan 14, 2019

bors-servo mentioned this pull request Jan 15, 2019

Implement formdata event #22660

Merged

4 of 4 tasks complete

highfive removed the S-awaiting-merge label Jan 15, 2019

bors-servo mentioned this pull request Jan 15, 2019

Fix brotli decoding #22616

Merged

4 of 4 tasks complete

servo / servo

Implement HTMLMediaElement poster attribute #22399

Implement HTMLMediaElement poster attribute #22399

ferjm commented Dec 10, 2018 •

edited

highfive commented Dec 10, 2018

highfive commented Dec 10, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 11, 2018

bors-servo commented Dec 11, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 13, 2018

jdm left a comment

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

jdm commented Jan 14, 2019

ferjm commented Jan 14, 2019

This comment has been minimized.

This comment has been minimized.

jdm commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 15, 2019

servo / servo

Join GitHub today

Implement HTMLMediaElement poster attribute #22399

Implement HTMLMediaElement poster attribute #22399

Conversation

ferjm commented Dec 10, 2018 • edited

highfive commented Dec 10, 2018

highfive commented Dec 10, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 11, 2018

bors-servo commented Dec 11, 2018

ferjm commented Dec 11, 2018

bors-servo commented Dec 13, 2018

jdm left a comment

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

jdm commented Jan 14, 2019

ferjm commented Jan 14, 2019

This comment has been minimized.

jdm Jan 14, 2019

This comment has been minimized.

ferjm Jan 14, 2019

jdm commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 14, 2019

bors-servo commented Jan 15, 2019

ferjm commented Dec 10, 2018 •

edited