Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLMediaElement poster attribute #22399

Merged
merged 6 commits into from Jan 15, 2019
Prev

Terminate poster frame load blocker before blocking again

  • Loading branch information
ferjm committed Jan 14, 2019
commit 7633cab63a0080350b3883a7fed045d3b9d83a15
@@ -179,6 +179,7 @@ impl HTMLVideoElement {
// (which triggers no media load algorithm unless a explicit call to .load() is done)
// will block the document's load event forever.
let mut blocker = self.load_blocker.borrow_mut();

This comment has been minimized.

@jdm

jdm Jan 14, 2019

Member

Does this still work correctly if we switch the poster attribute value while the poster is loading? I think we probably need to call LoadBlocker::terminate.

This comment has been minimized.

@ferjm

ferjm Jan 14, 2019

Author Member

Good point. Done.

LoadBlocker::terminate(&mut *blocker);
*blocker = Some(LoadBlocker::new(
&document_from_node(self),
LoadType::Image(poster_url.clone()),
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.