New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HTMLMediaElement poster attribute #22399
Merged
+483
−64
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c5b5aa
Implement HTMLMediaElement poster attribute
ferjm 9d5499b
Reftest for video poster frame
ferjm 1033d6b
ImageContext.aborted does not need to be inside a Cell
ferjm 4e286ff
Parse poster url relative to the node's document
ferjm fde7d45
Make poster frame load blocker independent from media element's one
ferjm 7633cab
Terminate poster frame load blocker before blocking again
ferjm File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
Terminate poster frame load blocker before blocking again
- Loading branch information
commit 7633cab63a0080350b3883a7fed045d3b9d83a15
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Does this still work correctly if we switch the poster attribute value while the poster is loading? I think we probably need to call LoadBlocker::terminate.