Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make desktop webdriver WPT harness work #22411

Merged
merged 5 commits into from Dec 11, 2018
Merged

Make desktop webdriver WPT harness work #22411

merged 5 commits into from Dec 11, 2018

Conversation

@jdm
Copy link
Member

jdm commented Dec 11, 2018 •
edited by SimonSapin

This change allows me to run ./mach test-wpt --product servodriver --no-pause-after-test tests/wpt/mozilla/tests/mozilla/DOMParser.html successfully again.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22409
  • There are tests for these changes

This change is Reviewable
jdm added 4 commits Dec 10, 2018
@jdm
Add debug output for webdriver commands.
db786a4
@jdm
Delay setting the constellation's active browser id until the context…
b62a1ca 
… exists.
@jdm
Add headless support to servodriver harness.
832b796
@jdm
Add automated test for servodriver harness.
Loading status checks…
08b76ee
@highfive
Copy link

highfive commented Dec 11, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/lib.rs, components/constellation/constellation.rs
  • @cbrewster: components/constellation/constellation.rs
  • @jgraham: components/webdriver_server/lib.rs
  • @paulrouget: components/constellation/constellation.rs
@jdm
Copy link
Member Author

jdm commented Dec 11, 2018

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned Manishearth Dec 11, 2018
@jdm
Copy link
Member Author

jdm commented Dec 11, 2018

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2018

⌛ Trying commit 08b76ee with merge fc2888e...
bors-servo added a commit that referenced this pull request Dec 11, 2018
@bors-servo
Auto merge of #22411 - jdm:fix-webdriver, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fc2888e 
Make desktop webdriver WPT harness work

This change allows me to run `./mach test-wpt --product servodriver --no-pause-after-test tests/wpt/mozilla/tests/mozilla/DOMParser.html` successfully again.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22409
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22411)
<!-- Reviewable:end -->
@servo-wpt-sync servo-wpt-sync mentioned this pull request Dec 11, 2018
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Dec 11, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14445.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Dec 11, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14445.
@jdm jdm mentioned this pull request Dec 11, 2018
Closed
@SimonSapin
Copy link
Member

SimonSapin commented Dec 11, 2018

r+, but tidy is unhappy on Travis. I don’t know why.

 0:19.20 ERROR Manifest /home/travis/build/servo/servo/tests/wpt/webgl/meta/MANIFEST.json is outdated, use |./mach update-manifest| to fix.
@SimonSapin
Copy link
Member

SimonSapin commented Dec 11, 2018

Ah I see. The manifest contains a hash of tools/wptrunner/wptrunner/browsers/servodriver.py. r=me with ./mach update-manifest.
@jdm
Make SSL tests work in servodriver.
Loading status checks…
6ab475b
@jdm jdm force-pushed the jdm:fix-webdriver branch from ff4da5d to 6ab475b Dec 11, 2018
@jdm
Copy link
Member Author

jdm commented Dec 11, 2018

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2018

📌 Commit 6ab475b has been approved by SimonSapin
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Dec 11, 2018

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14445.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2018

⌛ Testing commit 6ab475b with merge 92962de...
bors-servo added a commit that referenced this pull request Dec 11, 2018
@bors-servo
Auto merge of #22411 - jdm:fix-webdriver, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
92962de 
Make desktop webdriver WPT harness work

This change allows me to run `./mach test-wpt --product servodriver --no-pause-after-test tests/wpt/mozilla/tests/mozilla/DOMParser.html` successfully again.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22409
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22411)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2018

☀️ Test successful - android, android-mac, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster, windows-msvc-dev
Approved by: SimonSapin
Pushing 92962de to master...
@bors-servo bors-servo merged commit 6ab475b into servo:master Dec 11, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@cdeler cdeler mentioned this pull request Dec 14, 2018
Merged
4 of 5 tasks complete
@jdm jdm mentioned this pull request Dec 22, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Running WPT with servodriver on desktop is broken
6 participants
@jdm @highfive @bors-servo @servo-wpt-sync @SimonSapin @Manishearth
You can’t perform that action at this time.