Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable upstream bluetooth tests #22420

Merged
merged 9 commits into from Dec 22, 2018

#20437 added a special bluetooth tests to CI

  • Loading branch information
cdeler committed Dec 16, 2018
commit e0030eab3dde769bc17032ac31c7336021a86f93
@@ -55,6 +55,14 @@ mac-rel-css2:
- ./mach test-wpt --release --processes 4 --total-chunks 6 --this-chunk 6 --log-raw test-wpt.log --log-errorsummary wpt-errorsummary.log --always-succeed
- ./mach filter-intermittents wpt-errorsummary.log --log-intermittents intermittents.log --log-filteredsummary filtered-wpt-errorsummary.log --tracker-api default --reporter-api default

mac-rel-bluetooth:

This comment has been minimized.

Copy link
@jdm

jdm Dec 14, 2018

Member

Instead of a different job, please add this to an existing mac job that runs WPT tests.

This comment has been minimized.

Copy link
@cdeler

cdeler Dec 14, 2018

Author Contributor

Ok, I've moved the execution to mac-rel-wpt4

- ./mach clean-nightlies --keep 3 --force
- ./mach clean-cargo-cache --keep 3 --force
- env PKG_CONFIG_PATH=/usr/local/opt/zlib/lib/pkgconfig ./mach build --release
- ./mach test-wpt --release --processes=8 --log-raw test-bluetooth.log --log-errorsummary bluetooth-errorsummary.log --always-succeed bluetooth

This comment has been minimized.

Copy link
@jdm

jdm Dec 14, 2018

Member

We will need to pass --product=servodriver with the other changes that I recommended.

This comment has been minimized.

Copy link
@jdm

jdm Dec 14, 2018

Member

This still has not been addressed.

This comment has been minimized.

Copy link
@cdeler

cdeler Dec 14, 2018

Author Contributor

Yes, thank you, Im sorry for delay

servo rebuild takes a while after my rebase to upstream; I just wanted to get #22411 in my repo

This comment has been minimized.

Copy link
@cdeler

cdeler Dec 15, 2018

Author Contributor

It's done, thank you

I've also added --headless to the bluetooth tests execution

- ./mach filter-intermittents bluetooth-errorsummary.log --log-intermittents bluetooth-intermittents.log --log-filteredsummary filtered-bluetooth-errorsummary.log --tracker-api default --reporter-api default
- bash ./etc/ci/lockfile_changed.sh

mac-nightly:
- ./mach clean-nightlies --keep 3 --force
- ./mach clean-cargo-cache --keep 3 --force
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.