Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskcluster: start a decision task for all try-* branches #22426

Merged
merged 1 commit into from Dec 12, 2018
Merged

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 11, 2018

This is an alternative fix for servo/saltfs#903, and anticipates adding trychooser support to Taskcluster.


This change is Reviewable

This is an alternative fix for servo/saltfs#903,
and anticipates adding trychooser support to Taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 11, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2018

📌 Commit fdb2a66 has been approved by SimonSapin

@highfive highfive assigned SimonSapin and unassigned emilio Dec 11, 2018
SimonSapin added a commit to servo/homu that referenced this pull request Dec 11, 2018
This reverts commit 755c02c.

The reverted commit was a fix for servo/saltfs#903,
but that issue is also fixed by servo/servo#22426:
if `.taskcluster.yml` is configured with at least one task,
then taskcluster-github will set the status that Homu is waiting for.
@jdm
Copy link
Member

jdm commented Dec 11, 2018

I appreciate that this should work with any future trychooser additions.

bors-servo added a commit to servo/homu that referenced this pull request Dec 12, 2018
Revert "Quick fix for homu timeout on try (fixes #903)"

This reverts commit 755c02c.

The reverted commit was a fix for servo/saltfs#903, but that issue is also fixed by servo/servo#22426: if `.taskcluster.yml` is configured with at least one task, then taskcluster-github will set the status that Homu is waiting for.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/184)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2018

Testing commit fdb2a66 with merge 17ad16b...

bors-servo added a commit that referenced this pull request Dec 12, 2018
Taskcluster: start a decision task for all try-* branches

This is an alternative fix for servo/saltfs#903, and anticipates adding trychooser support to Taskcluster.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22426)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2018

💔 Test failed - linux-rel-css

@jdm
Copy link
Member

jdm commented Dec 12, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2018

Testing commit fdb2a66 with merge aab239c...

bors-servo added a commit that referenced this pull request Dec 12, 2018
Taskcluster: start a decision task for all try-* branches

This is an alternative fix for servo/saltfs#903, and anticipates adding trychooser support to Taskcluster.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22426)
<!-- Reviewable:end -->
@bors-servo bors-servo merged commit fdb2a66 into master Dec 12, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (push) TaskGroup: success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the choosers branch Dec 12, 2018
yshui pushed a commit to hadeaninc/homu that referenced this pull request Apr 1, 2019
This reverts commit 755c02c.

The reverted commit was a fix for servo/saltfs#903,
but that issue is also fixed by servo/servo#22426:
if `.taskcluster.yml` is configured with at least one task,
then taskcluster-github will set the status that Homu is waiting for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.