Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit simpleservo into 3 crates for rust, c and jni apis #22428
Merged
Conversation
highfive
commented
Dec 12, 2018
|
Heads up! This PR modifies the following files:
|
|
This should allow libmlservo to be based on simpleservo. /cc @asajeffrey |
|
@bors-servo r+ |
|
|
|
|
|
|
paulrouget
force-pushed the
paulrouget:split_simpleservo
branch
from
0027e90
to
bc0a5f8
paulrouget
force-pushed the
paulrouget:split_simpleservo
branch
from
bc0a5f8
to
16a00a1
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 28, 2018
Split simpleservo into 3 crates for rust, c and jni apis - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22413 (GitHub issue number if applicable) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22428) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedDec 12, 2018
•
edited by SimonSapin
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is