New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split simpleservo into 3 crates for rust, c and jni apis #22428

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
5 participants
@paulrouget
Copy link
Contributor

paulrouget commented Dec 12, 2018

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22413 (GitHub issue number if applicable)

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 12, 2018

Heads up! This PR modifies the following files:

@paulrouget

This comment has been minimized.

Copy link
Contributor

paulrouget commented Dec 12, 2018

This should allow libmlservo to be based on simpleservo.

/cc @asajeffrey

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 22, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 22, 2018

📌 Commit 0027e90 has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Dec 22, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 22, 2018

☔️ The latest upstream changes (presumably #22388) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

🔒 Merge conflict

@paulrouget paulrouget force-pushed the paulrouget:split_simpleservo branch from 0027e90 to bc0a5f8 Dec 28, 2018

@paulrouget paulrouget force-pushed the paulrouget:split_simpleservo branch from bc0a5f8 to 16a00a1 Dec 28, 2018

@paulrouget

This comment has been minimized.

Copy link
Contributor

paulrouget commented Dec 28, 2018

@bors-servo r=jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

📌 Commit 16a00a1 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

⌛️ Testing commit 16a00a1 with merge f80c497...

bors-servo added a commit that referenced this pull request Dec 28, 2018

Auto merge of #22428 - paulrouget:split_simpleservo, r=jdm
Split simpleservo into 3 crates for rust, c and jni apis

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22413 (GitHub issue number if applicable)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22428)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

@bors-servo bors-servo merged commit 16a00a1 into servo:master Dec 28, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment