Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister components while exiting #22474

Merged
merged 1 commit into from Dec 18, 2018
Merged

Unregister components while exiting #22474

merged 1 commit into from Dec 18, 2018

Conversation

@csmoe
Copy link
Contributor

csmoe commented Dec 16, 2018 •
edited

r=@gterzian

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22468 (GitHub issue number if applicable)

This change is Reviewable
@highfive
Copy link

highfive commented Dec 16, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.
@highfive
Copy link

highfive commented Dec 16, 2018

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Dec 16, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@gterzian
gterzian suggested changes Dec 16, 2018
View changes
Copy link
Member

gterzian left a comment •
edited

Looks good so far, thanks!

Could you please add a test-case for this? You could for example do a notify_activity followed by a unregister call, and then assert that after a timeout no alerts have been received on the ipc channel.
components/background_hang_monitor/background_hang_monitor.rs Outdated Show resolved Hide resolved
components/layout_thread/lib.rs Outdated Show resolved Hide resolved
@CYBAI CYBAI mentioned this pull request Dec 16, 2018
Closed
@csmoe csmoe force-pushed the csmoe:unregister branch from eb8ef9e to 310779a Dec 16, 2018
@gterzian
gterzian reviewed Dec 16, 2018
View changes
components/background_hang_monitor/tests/hang_monitor_tests.rs Outdated Show resolved Hide resolved
@gterzian
gterzian reviewed Dec 16, 2018
View changes
components/background_hang_monitor/tests/hang_monitor_tests.rs Show resolved Hide resolved
@csmoe csmoe force-pushed the csmoe:unregister branch from faea1c6 to a4e2196 Dec 17, 2018
@gterzian
gterzian reviewed Dec 17, 2018
View changes
components/layout_thread/lib.rs Outdated Show resolved Hide resolved
@csmoe csmoe force-pushed the csmoe:unregister branch from a4e2196 to a75935b Dec 17, 2018
@csmoe csmoe changed the title [WIP] Unregister components while exiting Unregister components while exiting Dec 17, 2018
@gterzian
Copy link
Member

gterzian commented Dec 17, 2018

Great! Please squash into one commit and then it should be good to go...
@gterzian gterzian assigned gterzian and unassigned avadacatavra Dec 17, 2018
@csmoe
unregister components while exiting
Loading status checks…
5600a1d
@csmoe csmoe force-pushed the csmoe:unregister branch from a75935b to 5600a1d Dec 17, 2018
@KiChjang
Copy link
Member

KiChjang commented Dec 18, 2018

@bors-servo r=gterzian

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2018

📌 Commit 5600a1d has been approved by gterzian
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2018

⌛ Testing commit 5600a1d with merge 59a9da3...
bors-servo added a commit that referenced this pull request Dec 18, 2018
@bors-servo
Auto merge of #22474 - csmoe:unregister, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
59a9da3 
Unregister components while exiting

r=@gterzian

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22468 (GitHub issue number if applicable)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22474)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2018

💔 Test failed - status-taskcluster
@gterzian
Copy link
Member

gterzian commented Dec 18, 2018

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2018

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2018

⌛ Testing commit 5600a1d with merge a067620...
bors-servo added a commit that referenced this pull request Dec 18, 2018
@bors-servo
Auto merge of #22474 - csmoe:unregister, r=gterzian
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a067620 
Unregister components while exiting

r=@gterzian

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22468 (GitHub issue number if applicable)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22474)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2018

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: gterzian
Pushing a067620 to master...
@bors-servo bors-servo merged commit 5600a1d into servo:master Dec 18, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 18, 2018
Merged
@gterzian
Copy link
Member

gterzian commented Dec 18, 2018

@csmoe thank you!
@csmoe
Copy link
Contributor Author

csmoe commented Dec 18, 2018

@gterzian thank for your patience :)
@csmoe csmoe deleted the csmoe:unregister branch Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gterzian gterzian

Assignees

@gterzian gterzian

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

When exiting, monitored component should unregister itself
6 participants
@csmoe @highfive @gterzian @KiChjang @bors-servo @avadacatavra
You can’t perform that action at this time.