Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs #22477

ferjm · 2018-12-16T12:19:07Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

This should help with the WPTs problems observed in #22348 (comment)

Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our canPlayType report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.

This change is

highfive · 2018-12-16T12:19:12Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs
@KiChjang: components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs

ferjm · 2018-12-16T12:19:26Z

r? @jdm

jdm · 2018-12-17T14:33:26Z

@bors-servo r+

bors-servo · 2018-12-17T14:33:27Z

📌 Commit d19834e has been approved by jdm

bors-servo · 2018-12-17T14:54:08Z

⌛ Testing commit d19834e with merge d2f66cb...


        Auto merge of #22477 - ferjm:media_time_marches_on_step_6, r=jdm

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes This should help with the WPTs problems observed in #22348 (comment) Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our `canPlayType` report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22477)

bors-servo · 2018-12-17T15:18:02Z

💔 Test failed - status-taskcluster

ferjm · 2018-12-17T15:49:02Z

@bors-servo retry

#21666

bors-servo · 2018-12-17T19:57:00Z

⌛ Testing commit d19834e with merge 04afbe4...


        Auto merge of #22477 - ferjm:media_time_marches_on_step_6, r=jdm

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes This should help with the WPTs problems observed in #22348 (comment) Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our `canPlayType` report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22477)

bors-servo · 2018-12-17T20:20:23Z

💔 Test failed - status-taskcluster

ferjm · 2018-12-18T08:31:40Z

@bors-servo retry

bors-servo · 2018-12-18T11:27:17Z

⌛ Testing commit d19834e with merge 340aa9e...


        Auto merge of #22477 - ferjm:media_time_marches_on_step_6, r=jdm

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes This should help with the WPTs problems observed in #22348 (comment) Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our `canPlayType` report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22477)

bors-servo · 2018-12-18T11:52:47Z

💔 Test failed - status-taskcluster

ferjm · 2019-01-09T09:05:30Z

@bors-servo try=wpt

bors-servo · 2019-01-09T09:05:35Z

⌛ Trying commit 4d9fb87 with merge ca7f362...


        Auto merge of #22477 - ferjm:media_time_marches_on_step_6, r=<try>

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes This should help with the WPTs problems observed in #22348 (comment) Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our `canPlayType` report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22477)

bors-servo · 2019-01-09T09:26:03Z

💔 Test failed - linux-rel-css

ferjm · 2019-01-09T15:47:57Z

Oh gosh...

  │ 0:00:00.043080348 61918 0x7f9ba44095e0 ERROR             gst-player gstplayer.c:1139:emit_warning:<player0> Warning: Warning from element /GstPlayBin:playbin/GstURIDecodeBin:uridecodebin0: There is no codec present that can handle the stream's type.
  │ No decoder available for type 'audio/mpeg, mpegversion=(int)1, mpegaudioversion=(int)2, layer=(int)3, rate=(int)22050, channels=(int)1, parsed=(boolean)true'.
  │ ../subprojects/gst-plugins-base/gst/playback/gsturidecodebin.c(921): unknown_type_cb (): /GstPlayBin:playbin/GstURIDecodeBin:uridecodebin0 (gst-player-error-quark, 0)
  │ 0:00:00.043580538 61918 0x7f9b5002d230 WARN            uridecodebin gsturidecodebin.c:988:no_more_pads_full:<uridecodebin0> error: no suitable plugins found:
  │ ../subprojects/gst-plugins-base/gst/playback/gstdecodebin2.c(4640): gst_decode_bin_expose (): /GstPlayBin:playbin/GstURIDecodeBin:uridecodebin0/GstDecodeBin:decodebin0:
  │ no suitable plugins found:
  │ Missing decoder: MPEG-1 Layer 3 (MP3) (audio/mpeg, mpegversion=(int)1, mpegaudioversion=(int)2, layer=(int)3, rate=(int)22050, channels=(int)1, parsed=(boolean)true)

More missing decoders.

ferjm · 2019-01-09T17:00:09Z

@bors-servo try=wpt

jdm · 2019-01-09T17:35:59Z

@bors-servo retry

bors-servo · 2019-01-09T17:36:06Z

⌛ Trying commit 4d9fb87 with merge da5584b...


        Auto merge of #22477 - ferjm:media_time_marches_on_step_6, r=<try>

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes This should help with the WPTs problems observed in #22348 (comment) Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our `canPlayType` report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22477)

bors-servo · 2019-01-09T17:56:37Z

💔 Test failed - linux-rel-css

ferjm · 2019-01-10T11:20:00Z

With servo/saltfs@1ec4e8f I am able to play an mp4 file on servo-linux1.servo.org

gst-play-1.0 movie_5.mp4
Press 'k' to see a list of keyboard shortcuts.
Now playing /tmp/movie_5.mp4
Redistribute latency...
Redistribute latency...
Redistribute latency...
0:00:00.8 / 0:00:05.1

@bors-servo try=wpt

ferjm · 2019-01-10T11:20:20Z

@bors-servo retry

bors-servo · 2019-01-10T11:20:26Z

⌛ Trying commit 4d9fb87 with merge f387508...


        Auto merge of #22477 - ferjm:media_time_marches_on_step_6, r=<try>

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes This should help with the WPTs problems observed in #22348 (comment) Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our `canPlayType` report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22477)

bors-servo · 2019-01-10T11:50:10Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

ferjm · 2019-01-10T11:52:53Z

@bors-servo r=jdm

bors-servo · 2019-01-10T11:52:54Z

📌 Commit 4d9fb87 has been approved by jdm

bors-servo · 2019-01-10T11:52:59Z

⌛ Testing commit 4d9fb87 with merge 4ac5b8a...


        Auto merge of #22477 - ferjm:media_time_marches_on_step_6, r=jdm

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes This should help with the WPTs problems observed in #22348 (comment) Unfortunately, GStreamer does not seem to be very reliable with Ogg (check https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/520) and most of the media-element WPTs uses a short ogv file, so I had to make our `canPlayType` report that it is not able to play this type to make the tests pick the alternative mp4 version of the same files. Once Ogg support for GStreamer improves, we should be able to revert this change.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22477)

bors-servo · 2019-01-10T13:14:43Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 4ac5b8a to master...

highfive assigned nox Dec 16, 2018

highfive added the S-awaiting-review label Dec 16, 2018

highfive assigned jdm and unassigned nox Dec 16, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 17, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 17, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 17, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 17, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 18, 2018

highfive removed the S-awaiting-merge label Dec 18, 2018

highfive added the S-tests-failed label Jan 9, 2019

ferjm mentioned this pull request Jan 9, 2019

Update gstreamer binaries on Travis CI #22659

Closed

highfive added S-awaiting-merge and removed S-awaiting-review S-tests-failed labels Jan 10, 2019

Media playback automation moved this from In progress to Done Jan 10, 2019

highfive removed the S-awaiting-merge label Jan 10, 2019

bors-servo mentioned this pull request Jan 10, 2019

HTMLMediaElement backoff protocol and other improvements to a/v playback #22522

Merged

2 of 2 tasks complete

ferjm deleted the ferjm:media_time_marches_on_step_6 branch Jan 10, 2019

servo / servo

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs #22477

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs #22477

ferjm commented Dec 16, 2018 •

edited by SimonSapin

highfive commented Dec 16, 2018

ferjm commented Dec 16, 2018

jdm commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 17, 2018

ferjm commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 17, 2018

ferjm commented Dec 18, 2018

bors-servo commented Dec 18, 2018

bors-servo commented Dec 18, 2018

ferjm commented Jan 9, 2019

bors-servo commented Jan 9, 2019

bors-servo commented Jan 9, 2019

ferjm commented Jan 9, 2019

ferjm commented Jan 9, 2019

jdm commented Jan 9, 2019

bors-servo commented Jan 9, 2019

bors-servo commented Jan 9, 2019

ferjm commented Jan 10, 2019

ferjm commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

ferjm commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

servo / servo

Join GitHub today

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs #22477

Implement step 6 of media `time marches on` algorithm. Improves stability of media WPTs #22477

Conversation

ferjm commented Dec 16, 2018 • edited by SimonSapin

highfive commented Dec 16, 2018

ferjm commented Dec 16, 2018

jdm commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 17, 2018

ferjm commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 17, 2018

ferjm commented Dec 18, 2018

bors-servo commented Dec 18, 2018

bors-servo commented Dec 18, 2018

ferjm commented Jan 9, 2019

bors-servo commented Jan 9, 2019

bors-servo commented Jan 9, 2019

ferjm commented Jan 9, 2019

ferjm commented Jan 9, 2019

jdm commented Jan 9, 2019

bors-servo commented Jan 9, 2019

bors-servo commented Jan 9, 2019

ferjm commented Jan 10, 2019

ferjm commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

ferjm commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

bors-servo commented Jan 10, 2019

ferjm commented Dec 16, 2018 •

edited by SimonSapin