Implement dom exception constructor #22480

cdeler · 2018-12-17T10:52:32Z

The constructor method was implemented

I have a question: should I edit ./mach test-wpt expectations?

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22412
There are tests for these changes

This change is

highfive · 2018-12-17T10:52:40Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.

highfive · 2018-12-17T10:52:40Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/DOMException.webidl, components/script/dom/domexception.rs
@KiChjang: components/script/dom/webidls/DOMException.webidl, components/script/dom/domexception.rs

highfive · 2018-12-17T10:52:43Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

jdm · 2018-12-17T13:35:49Z

Yes, you should follow https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations and you can restrict the tests that are run to the directories that are known to use this.

cdeler · 2018-12-17T14:06:49Z

@jdm I've updated expectations for the tests, which are executed by ./mach test-wpt WebIDL

cdeler · 2018-12-21T20:01:34Z

@jdm @SimonSapin
Hello,
Do you have a chance to review the PR? May be I should change something?

jdm

This looks like a sensible implementation of the specification. Thanks!

jdm · 2018-12-22T04:10:05Z

@bors-servo r+

bors-servo · 2018-12-22T04:10:06Z

📌 Commit 83d318c has been approved by jdm

bors-servo · 2018-12-22T13:40:06Z

⌛ Testing commit 83d318c with merge 8c82cd9...


        Auto merge of #22480 - cdeler:implement-DOMException-constructor, r=jdm

Implement dom exception constructor The constructor method was implemented I have a question: should I edit `./mach test-wpt` expectations? ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22412 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22480)

bors-servo · 2018-12-22T14:39:18Z

💔 Test failed - mac-rel-wpt4

jdm · 2018-12-22T14:43:24Z

These changes expose a problem with the upstream Bluetooth tests - they rely on a Chrome-only test feature.

jdm · 2018-12-22T16:44:09Z

This actually comes from code that is supposed to deal with non-Chromium browsers: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/bluetooth/resources/bluetooth-helpers.js#21-24
We should be able to fix this by changing the condition to if (!('Mojo' in this)) instead.

cdeler · 2018-12-22T20:30:19Z

Wilco

CYBAI · 2018-12-23T05:16:34Z

Could we do rebase instead of merge ?
btw, do you mind to squash these commit into one or two commits ? ( one for implementation of DOMException constructor and another one for updating test expectation; or, it's also fine to squash them into just one commit :) )

jdm · 2018-12-23T05:21:21Z

I actually prefer to keep the commits together when possible. It makes sense to include the test result changes in the same commit as the code changes that caused them.

jdm · 2019-03-20T14:35:02Z

@bors-servo r+
Thanks!

bors-servo · 2019-03-20T14:35:03Z

📌 Commit 18fe572 has been approved by jdm


        Auto merge of #22480 - cdeler:implement-DOMException-constructor, r=jdm

Implement dom exception constructor The constructor method was implemented I have a question: should I edit `./mach test-wpt` expectations? ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22412 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22480)

bors-servo · 2019-03-20T14:35:12Z

⌛ Testing commit 18fe572 with merge 1845f1a...

bors-servo · 2019-03-20T15:06:09Z

💔 Test failed - linux-rel-wpt

highfive · 2019-03-20T15:06:14Z

Test failures:

▶ ERROR [expected OK] /bluetooth/requestDevice/canonicalizeFilter/empty-services-member.https.html └ → ''

  ▶ ERROR [expected OK] /bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-name-unicode.https.html
  └   → ''

  ▶ ERROR [expected OK] /bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-namePrefix-unicode.https.html
  └   → ''

  ▶ ERROR [expected OK] /bluetooth/requestDevice/canonicalizeFilter/wrong-service-in-services-member.https.html
  └   → ''

jdm · 2019-03-20T17:10:08Z

Looks like four tests results need to have a toplevel expected: ERROR added.

cdeler · 2019-03-20T18:24:40Z

@jdm
It's strange. When I run the tests locally, I've got:

(SRV) user ~/workspace/skv/servo % ./mach test-wpt --processes 1 --release --product=servodriver --headless /bluetooth/requestDevice/canonicalizeFilter                                
Running 19 tests in web-platform-tests

Unsupported test type wdspec for product servodriver
Ran 19 tests finished in 5.0 seconds.
  • 19 ran as expected. 0 tests skipped.

jdm · 2019-03-20T18:42:28Z

Hmm. I suspect that this code is racy in Servo; maybe the page finishes loading sometimes before the promise_test call is executed. I think we should modify that file to immediately call promise_test instead of calling it from a then() callback.

cdeler · 2019-03-20T18:57:01Z

@jdm

Something like that?

function bluetooth_test(func, name, properties) {
      promise_test(t => Promise.resolve()
      // Trigger Chromium-specific setup.
      .then(performChromiumSetup)
      .then(() => func(t))
      .then(() => navigator.bluetooth.test.allResponsesConsumed())
      .then(consumed => assert_true(consumed)), name, properties);
}

I did it locally. Ran test a couple of times and got that /bluetooth/requestDevice/canonicalizeFilter tests can fail unexpectedly.

Maybe it would be better to turn them off?

UPD without the above changeset these tests also fail unexpectedly.

jdm · 2019-03-20T19:08:22Z

Humbug. Let's try disabling those tests in that case (disable: #23066 in the ini files) and see if that's enough to merge these changes.

cdeler · 2019-03-20T19:16:54Z

@jdm

I'm sorry, looks like I don't understand you. Should I disable /bluetooth/requestDevice/canonicalizeFilter, also should I do that in this PR?

By the way:

I ran the tests

(SRV) user ~/workspace/skv/servo % ./mach test-wpt --processes 1 --release --product=servodriver --headless /bluetooth/requestDevice/canonicalizeFilter
Running 19 tests in web-platform-tests

Unsupported test type wdspec for product servodriver
  ▶ ERROR [expected OK] /bluetooth/requestDevice/canonicalizeFilter/filters-xor-acceptAllDevices.https.html
  └   → ''

Ran 19 tests finished in 6.0 seconds.
  • 18 ran as expected. 0 tests skipped.
  • 1 tests had errors unexpectedly

jdm · 2019-03-20T19:27:37Z

Yes, let's try adding a __dir__.ini to tests/wpt/metadata/bluetooth/requestDevice/canonicalizeFilter/ which contains disable: #23066. This will cause all of those tests to be skipped.


        #22412 disabled /bluetooth/requestDevice/canonicalizeFilter wpt tests…

… due to #23066

cdeler · 2019-03-20T19:38:29Z

@jdm

I did it (# is a special .ini character, so I escaped it). If test pass, I can squash commits.

jdm · 2019-03-20T19:48:07Z

@bors-servo r+

bors-servo · 2019-03-20T19:48:08Z

📌 Commit 76fed04 has been approved by jdm

bors-servo · 2019-03-20T20:13:22Z

⌛ Testing commit 76fed04 with merge 6d308c3...


        Auto merge of #22480 - cdeler:implement-DOMException-constructor, r=jdm

Implement dom exception constructor The constructor method was implemented I have a question: should I edit `./mach test-wpt` expectations? ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22412 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22480)

bors-servo · 2019-03-20T21:33:21Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 6d308c3 to master...

highfive assigned SimonSapin Dec 17, 2018

highfive added the S-awaiting-review label Dec 17, 2018

cdeler force-pushed the cdeler:implement-DOMException-constructor branch from 37fc164 to 83d318c Dec 17, 2018

jdm assigned jdm and unassigned SimonSapin Dec 21, 2018

jdm removed the S-awaiting-review label Dec 21, 2018

jdm approved these changes Dec 21, 2018

View changes

highfive added the S-awaiting-merge label Dec 22, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 22, 2018

highfive added S-awaiting-review and removed S-tests-failed labels Dec 22, 2018

cdeler force-pushed the cdeler:implement-DOMException-constructor branch from b3c7c2a to e55b76b Dec 23, 2018

servo-wpt-sync mentioned this pull request Dec 23, 2018

Implement dom exception constructor web-platform-tests/wpt#14660

Closed

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 20, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Mar 20, 2019

#22412 disabled /bluetooth/requestDevice/canonicalizeFilter wpt tests…

Loading status checks…

76fed04

… due to #23066

highfive added S-awaiting-review and removed S-tests-failed labels Mar 20, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Mar 20, 2019

highfive removed the S-awaiting-merge label Mar 20, 2019

servo / servo

Implement dom exception constructor #22480

Implement dom exception constructor #22480

cdeler commented Dec 17, 2018 •

edited by ferjm

highfive commented Dec 17, 2018

highfive commented Dec 17, 2018

highfive commented Dec 17, 2018

jdm commented Dec 17, 2018

cdeler commented Dec 17, 2018

cdeler commented Dec 21, 2018

jdm left a comment

jdm commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

jdm commented Dec 22, 2018

jdm commented Dec 22, 2018

cdeler commented Dec 22, 2018

CYBAI commented Dec 23, 2018

jdm commented Dec 23, 2018

jdm commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

highfive commented Mar 20, 2019

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019 •

edited

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019

jdm commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

servo / servo

Join GitHub today

Implement dom exception constructor #22480

Implement dom exception constructor #22480

Conversation

cdeler commented Dec 17, 2018 • edited by ferjm

highfive commented Dec 17, 2018

highfive commented Dec 17, 2018

highfive commented Dec 17, 2018

jdm commented Dec 17, 2018

cdeler commented Dec 17, 2018

cdeler commented Dec 21, 2018

jdm left a comment

jdm commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

bors-servo commented Dec 22, 2018

jdm commented Dec 22, 2018

jdm commented Dec 22, 2018

cdeler commented Dec 22, 2018

CYBAI commented Dec 23, 2018

jdm commented Dec 23, 2018

jdm commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

highfive commented Mar 20, 2019

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019 • edited

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019

jdm commented Mar 20, 2019

cdeler commented Mar 20, 2019

jdm commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

bors-servo commented Mar 20, 2019

cdeler commented Dec 17, 2018 •

edited by ferjm

cdeler commented Mar 20, 2019 •

edited