style: Make Servo use a single thread-pool for layout-related tasks per process. #22487

emilio · 2018-12-17T23:20:10Z

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.

This change is

highfive · 2018-12-17T23:20:14Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/htmliframeelement.rs, components/constellation/pipeline.rs, components/script/dom/windowproxy.rs, components/script/script_thread.rs
@cbrewster: components/constellation/pipeline.rs
@paulrouget: components/constellation/pipeline.rs
@KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/windowproxy.rs, components/script/script_thread.rs, components/script_traits/lib.rs

highfive · 2018-12-17T23:20:16Z

Warning

These commits modify style and script code, but no tests are modified. Please consider adding a test!

emilio · 2018-12-17T23:20:18Z

r? @jdm

emilio · 2018-12-17T23:39:33Z

@bors-servo try

bors-servo · 2018-12-17T23:39:38Z

⌛ Trying commit 14d9ac5 with merge f8f1160...


        Auto merge of #22487 - emilio:single-layout-thread-pool, r=<try>

style: Make Servo use a single thread-pool for layout-related tasks per process. Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22487)

bors-servo · 2018-12-18T00:00:16Z

💔 Test failed - status-taskcluster

bors-servo · 2018-12-18T04:37:45Z

☔ The latest upstream changes (presumably #22474) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2018-12-18T15:25:20Z

☔ The latest upstream changes (presumably #22395) made this pull request unmergeable. Please resolve the merge conflicts.

mandreyel · 2018-12-18T20:16:02Z

Oh you're fast, I also wanted to do this 😄

jdm · 2018-12-22T14:40:02Z

@bors-servo r+

bors-servo · 2018-12-22T14:40:02Z

📌 Commit e9262be has been approved by jdm


        style: Make Servo use a single thread-pool for layout-related tasks p…

…er-process. Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice.

emilio · 2018-12-23T12:01:19Z

@bors-servo r=jdm

Just addressed merge conflicts

bors-servo · 2018-12-23T12:01:19Z

📌 Commit 006e71c has been approved by jdm

bors-servo · 2018-12-23T12:44:16Z

⌛ Testing commit 006e71c with merge 3934ef7...


        Auto merge of #22487 - emilio:single-layout-thread-pool, r=jdm

style: Make Servo use a single thread-pool for layout-related tasks per process. Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22487)

bors-servo · 2018-12-23T13:24:52Z

💔 Test failed - mac-rel-wpt3

jdm · 2018-12-23T13:28:07Z

@bors-servo retry

bors-servo · 2018-12-23T14:39:09Z

⌛ Testing commit 006e71c with merge b5a10e9...


        Auto merge of #22487 - emilio:single-layout-thread-pool, r=jdm

style: Make Servo use a single thread-pool for layout-related tasks per process. Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22487)

bors-servo · 2018-12-23T15:48:14Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing b5a10e9 to master...


        Bug 1518045 - Make Servo use a single thread-pool for layout-related …

…tasks per-process. r=jdm Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice. This cherry-picks servo/servo#22487, with a few minor fixes to the build that are landing as part of the sync associated to this bug, and an lsan exception tweak to point to the right module since it's moving.


        Bug 1518045 - Make Servo use a single thread-pool for layout-related …

…tasks per-process. r=jdm Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice. This cherry-picks servo/servo#22487, with a few minor fixes to the build that are landing as part of the sync associated to this bug, and an lsan exception tweak to point to the right module since it's moving.


        Bug 1518045 - Make Servo use a single thread-pool for layout-related …

…tasks per-process. r=jdm Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice. This cherry-picks servo/servo#22487, with a few minor fixes to the build that are landing as part of the sync associated to this bug, and an lsan exception tweak to point to the right module since it's moving. UltraBlame original commit: 4cfc198196e989cbda49033f03879d7f1b53fae7


        Bug 1518045 - Make Servo use a single thread-pool for layout-related …

…tasks per-process. r=jdm Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice. This cherry-picks servo/servo#22487, with a few minor fixes to the build that are landing as part of the sync associated to this bug, and an lsan exception tweak to point to the right module since it's moving. UltraBlame original commit: 4cfc198196e989cbda49033f03879d7f1b53fae7


        Bug 1518045 - Make Servo use a single thread-pool for layout-related …

…tasks per-process. r=jdm Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice. This cherry-picks servo/servo#22487, with a few minor fixes to the build that are landing as part of the sync associated to this bug, and an lsan exception tweak to point to the right module since it's moving. UltraBlame original commit: 4cfc198196e989cbda49033f03879d7f1b53fae7

highfive assigned ferjm Dec 17, 2018

highfive added the S-awaiting-review label Dec 17, 2018

highfive assigned jdm and unassigned ferjm Dec 17, 2018

emilio mentioned this pull request Dec 17, 2018

[WIP] Implement parallel CSS parsing #22478

Open

4 of 5 tasks complete

highfive added the S-tests-failed label Dec 18, 2018

highfive added the S-needs-rebase label Dec 18, 2018

emilio force-pushed the emilio:single-layout-thread-pool branch from 14d9ac5 to e9262be Dec 18, 2018

highfive removed the S-tests-failed label Dec 18, 2018

jdm approved these changes Dec 21, 2018

View changes

jdm removed the S-awaiting-review label Dec 21, 2018

highfive added S-awaiting-merge and removed S-needs-rebase labels Dec 22, 2018

emilio force-pushed the emilio:single-layout-thread-pool branch from e9262be to 006e71c Dec 23, 2018

highfive added S-awaiting-review and removed S-awaiting-merge labels Dec 23, 2018

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 23, 2018

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 23, 2018

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 23, 2018

bors-servo merged commit 006e71c into servo:master Dec 23, 2018
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Dec 23, 2018

emilio deleted the emilio:single-layout-thread-pool branch Dec 23, 2018

servo / servo

style: Make Servo use a single thread-pool for layout-related tasks per process. #22487

style: Make Servo use a single thread-pool for layout-related tasks per process. #22487

emilio commented Dec 17, 2018 •

edited by SimonSapin

highfive commented Dec 17, 2018

highfive commented Dec 17, 2018

emilio commented Dec 17, 2018

emilio commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 18, 2018

bors-servo commented Dec 18, 2018

bors-servo commented Dec 18, 2018

mandreyel commented Dec 18, 2018

jdm commented Dec 22, 2018

bors-servo commented Dec 22, 2018

emilio commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

jdm commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

servo / servo

Join GitHub today

style: Make Servo use a single thread-pool for layout-related tasks per process. #22487

style: Make Servo use a single thread-pool for layout-related tasks per process. #22487

Conversation

emilio commented Dec 17, 2018 • edited by SimonSapin

highfive commented Dec 17, 2018

highfive commented Dec 17, 2018

emilio commented Dec 17, 2018

emilio commented Dec 17, 2018

bors-servo commented Dec 17, 2018

bors-servo commented Dec 18, 2018

bors-servo commented Dec 18, 2018

bors-servo commented Dec 18, 2018

mandreyel commented Dec 18, 2018

jdm commented Dec 22, 2018

bors-servo commented Dec 22, 2018

emilio commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

jdm commented Dec 23, 2018

bors-servo commented Dec 23, 2018

bors-servo commented Dec 23, 2018

emilio commented Dec 17, 2018 •

edited by SimonSapin