New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Make Servo use a single thread-pool for layout-related tasks per process. #22487

Merged
merged 1 commit into from Dec 23, 2018

Conversation

Projects
None yet
6 participants
@emilio
Copy link
Member

emilio commented Dec 17, 2018

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 17, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmliframeelement.rs, components/constellation/pipeline.rs, components/script/dom/windowproxy.rs, components/script/script_thread.rs
  • @cbrewster: components/constellation/pipeline.rs
  • @paulrouget: components/constellation/pipeline.rs
  • @KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/windowproxy.rs, components/script/script_thread.rs, components/script_traits/lib.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Dec 17, 2018

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member

emilio commented Dec 17, 2018

r? @jdm

@highfive highfive assigned jdm and unassigned ferjm Dec 17, 2018

@emilio emilio referenced this pull request Dec 17, 2018

Open

[WIP] Implement parallel CSS parsing #22478

4 of 5 tasks complete
@emilio

This comment has been minimized.

Copy link
Member

emilio commented Dec 17, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 17, 2018

⌛️ Trying commit 14d9ac5 with merge f8f1160...

bors-servo added a commit that referenced this pull request Dec 17, 2018

Auto merge of #22487 - emilio:single-layout-thread-pool, r=<try>
style: Make Servo use a single thread-pool for layout-related tasks per process.

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22487)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

💔 Test failed - status-taskcluster

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

☔️ The latest upstream changes (presumably #22474) made this pull request unmergeable. Please resolve the merge conflicts.

@emilio emilio force-pushed the emilio:single-layout-thread-pool branch from 14d9ac5 to e9262be Dec 18, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 18, 2018

☔️ The latest upstream changes (presumably #22395) made this pull request unmergeable. Please resolve the merge conflicts.

@mandreyel

This comment has been minimized.

Copy link
Contributor

mandreyel commented Dec 18, 2018

Oh you're fast, I also wanted to do this 😄

@jdm

jdm approved these changes Dec 21, 2018

@jdm jdm removed the S-awaiting-review label Dec 21, 2018

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 22, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 22, 2018

📌 Commit e9262be has been approved by jdm

style: Make Servo use a single thread-pool for layout-related tasks p…
…er-process.

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.

@emilio emilio force-pushed the emilio:single-layout-thread-pool branch from e9262be to 006e71c Dec 23, 2018

@emilio

This comment has been minimized.

Copy link
Member

emilio commented Dec 23, 2018

@bors-servo r=jdm

  • Just addressed merge conflicts
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

📌 Commit 006e71c has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

⌛️ Testing commit 006e71c with merge 3934ef7...

bors-servo added a commit that referenced this pull request Dec 23, 2018

Auto merge of #22487 - emilio:single-layout-thread-pool, r=jdm
style: Make Servo use a single thread-pool for layout-related tasks per process.

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22487)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

💔 Test failed - mac-rel-wpt3

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 23, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

⌛️ Testing commit 006e71c with merge b5a10e9...

bors-servo added a commit that referenced this pull request Dec 23, 2018

Auto merge of #22487 - emilio:single-layout-thread-pool, r=jdm
style: Make Servo use a single thread-pool for layout-related tasks per process.

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22487)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

@bors-servo bors-servo merged commit 006e71c into servo:master Dec 23, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@emilio emilio deleted the emilio:single-layout-thread-pool branch Dec 23, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 7, 2019

Bug 1518045 - Make Servo use a single thread-pool for layout-related …
…tasks per-process. r=jdm

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.

This cherry-picks servo/servo#22487, with a few minor
fixes to the build that are landing as part of the sync associated to this bug,
and an lsan exception tweak to point to the right module since it's moving.

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jan 7, 2019

Bug 1518045 - Make Servo use a single thread-pool for layout-related …
…tasks per-process. r=jdm

Instead of per-document. This also allows to reuse this thread-pool if needed
for other stuff, like parallel CSS parsing (#22478), and to share more code with
Gecko, which is always nice.

This cherry-picks servo/servo#22487, with a few minor
fixes to the build that are landing as part of the sync associated to this bug,
and an lsan exception tweak to point to the right module since it's moving.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment