New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic keyboard support for magicleap #22491

Merged
merged 1 commit into from Dec 23, 2018

Conversation

Projects
None yet
5 participants
@asajeffrey
Copy link
Member

asajeffrey commented Dec 18, 2018

Add basic keyboard support for magicleap servo.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22401
  • These changes do not require tests because we don't test magicleap UI

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 18, 2018

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
}

bool Servo2D::keyboardEventListener(const lumin::ui::KeyboardEvent::EventData& event) {
if (event.getEventType() != lumin::ui::KeyboardEvent::EventType::KEY_PRESSED) {

This comment has been minimized.

@jdm

jdm Dec 21, 2018

Member

Why not pass along KEY_DOWN and KEY_UP like we do in the glutin port, rather than simulating them in libmlservo?

This comment has been minimized.

This comment has been minimized.

@asajeffrey

This comment has been minimized.

@asajeffrey
Show resolved Hide resolved ports/libmlservo/src/lib.rs
@asajeffrey

This comment has been minimized.

Copy link
Member

asajeffrey commented Dec 21, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 21, 2018

📌 Commit 3af2f9a has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 21, 2018

⌛️ Testing commit 3af2f9a with merge d66ac0e...

bors-servo added a commit that referenced this pull request Dec 21, 2018

Auto merge of #22491 - asajeffrey:magicleap-keyboard-visibility, r=jdm
Add basic keyboard support for magicleap

<!-- Please describe your changes on the following line: -->

Add basic keyboard support for magicleap servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22401
- [X] These changes do not require tests because we don't test magicleap UI

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22491)
<!-- Reviewable:end -->
@jdm

jdm approved these changes Dec 21, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 21, 2018

💔 Test failed - status-taskcluster

@asajeffrey

This comment has been minimized.

Copy link
Member

asajeffrey commented Dec 21, 2018

{
    "status": "TIMEOUT", 
    "group": "default", 
    "message": "Test timed out", 
    "stack": null, 
    "subtest": "document.open() aborts documents that are queued for navigation through <meta> refresh with timeout 0 (image loading)", 
    "test": "/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-refresh-immediate.window.html", 
    "line": 134218, 
    "action": "test_result", 
    "expected": "PASS"
}

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 21, 2018

💣 Failed to start rebuilding: Unknown error

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 21, 2018

⌛️ Testing commit 3af2f9a with merge 349d19d...

bors-servo added a commit that referenced this pull request Dec 21, 2018

Auto merge of #22491 - asajeffrey:magicleap-keyboard-visibility, r=jdm
Add basic keyboard support for magicleap

<!-- Please describe your changes on the following line: -->

Add basic keyboard support for magicleap servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22401
- [X] These changes do not require tests because we don't test magicleap UI

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22491)
<!-- Reviewable:end -->
@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 21, 2018

@asajeffrey Very few PRs can land right now. I am dealing with it; don't bother retrying.

@asajeffrey

This comment has been minimized.

Copy link
Member

asajeffrey commented Dec 21, 2018

OK, I'll try to be patient.

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 21, 2018

💔 Test failed - status-taskcluster

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 22, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

⌛️ Testing commit 3af2f9a with merge cc8649d...

bors-servo added a commit that referenced this pull request Dec 23, 2018

Auto merge of #22491 - asajeffrey:magicleap-keyboard-visibility, r=jdm
Add basic keyboard support for magicleap

<!-- Please describe your changes on the following line: -->

Add basic keyboard support for magicleap servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22401
- [X] These changes do not require tests because we don't test magicleap UI

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22491)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

💔 Test failed - mac-rel-wpt4

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 23, 2018

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

⌛️ Testing commit 3af2f9a with merge 3d91d83...

bors-servo added a commit that referenced this pull request Dec 23, 2018

Auto merge of #22491 - asajeffrey:magicleap-keyboard-visibility, r=jdm
Add basic keyboard support for magicleap

<!-- Please describe your changes on the following line: -->

Add basic keyboard support for magicleap servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22401
- [X] These changes do not require tests because we don't test magicleap UI

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22491)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 23, 2018

@bors-servo bors-servo merged commit 3af2f9a into servo:master Dec 23, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment