Implement source for postMessage events #22514

jdm · 2018-12-20T21:29:04Z

Also make similar-origin iframes access their newly loaded document as soon as the new document is created. This should allow tests that check the event.source property to run correctly.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #22499 and fix #12715 and fix #22514.
There are tests for these changes

This change is

servo-wpt-sync · 2018-12-20T21:29:08Z

Error syncing changes upstream. Logs saved in error-snapshot-1545341457705.

highfive · 2018-12-20T21:29:10Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/script_thread.rs, components/script/dom/worker.rs, components/script/dom/webidls/MessageEvent.webidl, components/script/dom/messageevent.rs, components/script/dom/eventsource.rs and 5 more
@cbrewster: components/constellation/constellation.rs
@jgraham: tests/wpt/include.ini
@paulrouget: components/constellation/constellation.rs
@KiChjang: components/script_traits/lib.rs, components/script_traits/script_msg.rs, components/script/script_thread.rs, components/script/dom/worker.rs, components/script/dom/webidls/MessageEvent.webidl and 6 more

highfive · 2018-12-20T21:29:12Z

Warning

These commits modify unsafe code. Please review it carefully!

jdm · 2018-12-20T21:29:14Z

@bors-servo try=wpt

bors-servo · 2018-12-20T21:29:19Z

⌛ Trying commit ccbfb92 with merge c5bbdae...


        Auto merge of #22514 - jdm:source, r=<try>

Implement source for postMessage events This should allow tests that check the event.source property to run correctly. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22499 and fix #12715. - [x] There are tests for these changes

bors-servo · 2018-12-20T21:58:18Z

💔 Test failed - status-taskcluster

servo-wpt-sync · 2018-12-20T22:14:20Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14634.

KiChjang · 2018-12-20T22:18:11Z

components/script/dom/dedicatedworkerglobalscope.rs

@@ -424,7 +424,7 @@ impl DedicatedWorkerGlobalScope {
                    JSAutoCompartment::new(scope.get_cx(), scope.reflector().get_jsobject().get());
                rooted!(in(scope.get_cx()) let mut message = UndefinedValue());
                data.read(scope.upcast(), message.handle_mut());
-                MessageEvent::dispatch_jsval(target, scope.upcast(), message.handle(), None);
+                MessageEvent::dispatch_jsval(target, scope.upcast(), message.handle(), None, None);


Some day we're gonna have to use the builder pattern for this :)

jdm · 2018-12-21T00:57:32Z

@bors-servo try=wpt

bors-servo · 2018-12-21T00:57:37Z

⌛ Trying commit 0797998 with merge 3ebe83a...


        Auto merge of #22514 - jdm:source, r=<try>

Implement source for postMessage events Also make similar-origin iframes access their newly loaded document as soon as the new document is created. This should allow tests that check the event.source property to run correctly. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22499 and fix #12715 and fix #22514. - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22514)

servo-wpt-sync · 2018-12-21T00:58:18Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14634.

bors-servo · 2018-12-21T01:24:37Z

💔 Test failed - status-taskcluster

servo-wpt-sync · 2018-12-21T01:38:26Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14634.

jdm · 2018-12-21T01:39:07Z

@bors-servo try=wpt

bors-servo · 2018-12-21T01:39:12Z

⌛ Trying commit 07f38f5 with merge 870d694...


        Auto merge of #22514 - jdm:source, r=<try>

Implement source for postMessage events Also make similar-origin iframes access their newly loaded document as soon as the new document is created. This should allow tests that check the event.source property to run correctly. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22499 and fix #12715 and fix #22514. - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22514)

jdm · 2018-12-21T01:39:54Z

I feel so much better about the referrer-policy tests now.

jdm · 2018-12-21T01:40:00Z

r? @Manishearth

CYBAI · 2019-01-08T03:01:06Z

@bors-servo retry

#22619

bors-servo · 2019-01-08T03:01:14Z

⌛ Testing commit 9afa722 with merge c050229...


        Auto merge of #22514 - jdm:source, r=Manishearth

Implement source for postMessage events Also make similar-origin iframes access their newly loaded document as soon as the new document is created. This should allow tests that check the event.source property to run correctly. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22499 and fix #12715 and fix #22514. - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22514)

CYBAI · 2019-01-08T03:09:13Z

oops, I found Travis is complaining about tidy

Diff in /home/travis/build/servo/servo/components/script/script_thread.rs at line 2110:
                         return warn!(
                             "postMessage after source pipeline {} closed.",
                             source_pipeline_id,
-                        )
+                        );
                     },
                     Some(source) => source,
                 };
Run `./mach fmt` to fix the formatting


        Provide the source window as part of postMessage events.


        Synchronously update the pipeline of same-origin iframe elements as s…

…oon as the child document begins parsing.


        Use incumbent global for postmessage origin check.


        Run all referrer-policy tests.


        Update expected test results.

jdm · 2019-01-08T03:19:41Z

Thanks for noticing!
@bors-servo r=Manishearth

bors-servo · 2019-01-08T03:19:41Z

📌 Commit 8ff0c41 has been approved by Manishearth

bors-servo · 2019-01-08T03:19:47Z

⌛ Testing commit 8ff0c41 with merge 11d1184...


        Auto merge of #22514 - jdm:source, r=Manishearth

Implement source for postMessage events Also make similar-origin iframes access their newly loaded document as soon as the new document is created. This should allow tests that check the event.source property to run correctly. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22499 and fix #12715 and fix #22514. - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22514)

servo-wpt-sync · 2019-01-08T03:20:34Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14634.

bors-servo · 2019-01-08T04:57:54Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: Manishearth
Pushing 11d1184 to master...

servo-wpt-sync · 2019-01-08T04:58:15Z

Error syncing changes upstream. Logs saved in error-snapshot-1546923619003.

CYBAI · 2019-01-08T07:49:27Z

Error syncing changes upstream. Logs saved in error-snapshot-1546923619003.

I found web-platform-tests/wpt#14634 is not merged but the labels are removed 🤔

jdm · 2019-01-08T22:45:55Z

Merged upstream manually in web-platform-tests/wpt#14634.

highfive assigned emilio Dec 20, 2018

highfive added the S-awaiting-review label Dec 20, 2018

highfive added the S-tests-failed label Dec 20, 2018

jdm force-pushed the jdm:source branch from ccbfb92 to d7198cd Dec 20, 2018

highfive removed the S-tests-failed label Dec 20, 2018

jdm mentioned this pull request Dec 20, 2018

Iframe's contentDocument is incorrect before load event is fired #22503

Closed

servo-wpt-sync mentioned this pull request Dec 20, 2018

Implement source for postMessage events web-platform-tests/wpt#14634

Merged

KiChjang reviewed Dec 20, 2018

View changes

jdm force-pushed the jdm:source branch from d7198cd to 0797998 Dec 21, 2018

highfive added S-tests-failed and removed S-tests-failed labels Dec 21, 2018

highfive added the S-tests-failed label Jan 7, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 8, 2019

jdm added 5 commits Dec 20, 2018

Provide the source window as part of postMessage events.

45619db

Synchronously update the pipeline of same-origin iframe elements as s…

51ab140

…oon as the child document begins parsing.

Use incumbent global for postmessage origin check.

ec6a936

Run all referrer-policy tests.

552a416

Update expected test results.

Loading status checks…

8ff0c41

jdm force-pushed the jdm:source branch from 9afa722 to 8ff0c41 Jan 8, 2019

highfive added S-awaiting-review and removed S-awaiting-merge labels Jan 8, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 8, 2019

bors-servo merged commit 8ff0c41 into servo:master Jan 8, 2019
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed S-awaiting-merge labels Jan 8, 2019

jdm mentioned this pull request Oct 23, 2019

Implement MessageEvent.source #21563

Closed

servo / servo

Implement source for postMessage events #22514

Implement source for postMessage events #22514

jdm commented Dec 20, 2018 •

edited

servo-wpt-sync commented Dec 20, 2018

highfive commented Dec 20, 2018

highfive commented Dec 20, 2018

jdm commented Dec 20, 2018

bors-servo commented Dec 20, 2018

bors-servo commented Dec 20, 2018

servo-wpt-sync commented Dec 20, 2018

This comment has been minimized.

jdm commented Dec 21, 2018

bors-servo commented Dec 21, 2018

servo-wpt-sync commented Dec 21, 2018

bors-servo commented Dec 21, 2018

servo-wpt-sync commented Dec 21, 2018

jdm commented Dec 21, 2018

bors-servo commented Dec 21, 2018

jdm commented Dec 21, 2018

jdm commented Dec 21, 2018

CYBAI commented Jan 8, 2019

bors-servo commented Jan 8, 2019

CYBAI commented Jan 8, 2019

jdm commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

servo-wpt-sync commented Jan 8, 2019

bors-servo commented Jan 8, 2019

servo-wpt-sync commented Jan 8, 2019

CYBAI commented Jan 8, 2019

jdm commented Jan 8, 2019

servo / servo

Join GitHub today

Implement source for postMessage events #22514

Implement source for postMessage events #22514

Conversation

jdm commented Dec 20, 2018 • edited

servo-wpt-sync commented Dec 20, 2018

highfive commented Dec 20, 2018

highfive commented Dec 20, 2018

jdm commented Dec 20, 2018

bors-servo commented Dec 20, 2018

bors-servo commented Dec 20, 2018

servo-wpt-sync commented Dec 20, 2018

This comment has been minimized.

KiChjang Dec 20, 2018

jdm commented Dec 21, 2018

bors-servo commented Dec 21, 2018

servo-wpt-sync commented Dec 21, 2018

bors-servo commented Dec 21, 2018

servo-wpt-sync commented Dec 21, 2018

jdm commented Dec 21, 2018

bors-servo commented Dec 21, 2018

jdm commented Dec 21, 2018

jdm commented Dec 21, 2018

CYBAI commented Jan 8, 2019

bors-servo commented Jan 8, 2019

CYBAI commented Jan 8, 2019

jdm commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

servo-wpt-sync commented Jan 8, 2019

bors-servo commented Jan 8, 2019

servo-wpt-sync commented Jan 8, 2019

CYBAI commented Jan 8, 2019

jdm commented Jan 8, 2019

jdm commented Dec 20, 2018 •

edited