Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHTMLMediaElement backoff protocol and other improvements to a/v playback #22522
Conversation
highfive
commented
Dec 21, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 21, 2018
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Dec 21, 2018
HTMLMediaElement backoff protocol and other improvements to a/v playback - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This PR implements a backoff protocol to keep us from dropping frames whenever it's possible. It also add some other improvements like: - Clean up the implementation a little bit by adding all fetch request related state to `HTMLMediaElementFetchContext`. - Make sure that we ignore responses from old requests. - Implements part of [step 8 of the seek spec](https://html.spec.whatwg.org/multipage/media.html#dom-media-seek) where we bail out if the stream is not seekable. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22522) <!-- Reviewable:end -->
|
r? @Manishearth |
|
This requires servo/media#176. I'll removed the patched Cargo.toml when that one is merged. |
|
|
|
|
|
looks good! |
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2019
HTMLMediaElement backoff protocol and other improvements to a/v playback - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This PR implements a backoff protocol to keep us from dropping frames whenever it's possible. It also add some other improvements like: - Clean up the implementation a little bit by adding all fetch request related state to `HTMLMediaElementFetchContext`. - Make sure that we ignore responses from old requests. - Set the stream to seekable iff there's support for range requests. This will likely change when we add the media cache. - Implements part of [step 8 of the seek spec](https://html.spec.whatwg.org/multipage/media.html#dom-media-seek) where we bail out if the stream is not seekable. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22522) <!-- Reviewable:end -->
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2019
HTMLMediaElement backoff protocol and other improvements to a/v playback - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This PR implements a backoff protocol to keep us from dropping frames whenever it's possible. It also add some other improvements like: - Clean up the implementation a little bit by adding all fetch request related state to `HTMLMediaElementFetchContext`. - Make sure that we ignore responses from old requests. - Set the stream to seekable iff there's support for range requests. This will likely change when we add the media cache. - Implements part of [step 8 of the seek spec](https://html.spec.whatwg.org/multipage/media.html#dom-media-seek) where we bail out if the stream is not seekable. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22522) <!-- Reviewable:end -->
|
|
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 11, 2019
HTMLMediaElement backoff protocol and other improvements to a/v playback - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This PR implements a backoff protocol to keep us from dropping frames whenever it's possible. It also add some other improvements like: - Clean up the implementation a little bit by adding all fetch request related state to `HTMLMediaElementFetchContext`. - Make sure that we ignore responses from old requests. - Set the stream to seekable iff there's support for range requests. This will likely change when we add the media cache. - Implements part of [step 8 of the seek spec](https://html.spec.whatwg.org/multipage/media.html#dom-media-seek) where we bail out if the stream is not seekable. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22522) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
|
|
This was referenced Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedDec 21, 2018
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis PR implements a backoff protocol to keep us from dropping frames whenever it's possible. It also add some other improvements like:
HTMLMediaElementFetchContext.This change is