Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ServiceWorkerContainer Webidl #22538

Merged
merged 1 commit into from Dec 23, 2018
Merged

Update ServiceWorkerContainer Webidl #22538

merged 1 commit into from Dec 23, 2018

Conversation

@CYBAI
Copy link
Collaborator

CYBAI commented Dec 23, 2018 •
edited by SimonSapin

Looks like the spec has changed a lot. Maybe it's better to update the implementation for these methods in a separate PR.

Let's just update webidl in this PR?

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix part of #19302
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable
@CYBAI
Update ServiceWorkerContainer Webidl
Loading status checks…
2f48f43
@highfive
Copy link

highfive commented Dec 23, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/ServiceWorkerContainer.webidl
  • @KiChjang: components/script/dom/webidls/ServiceWorkerContainer.webidl
@highfive
Copy link

highfive commented Dec 23, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@CYBAI CYBAI mentioned this pull request Dec 23, 2018
Closed
5 of 6 tasks complete
@jdm
Copy link
Member

jdm commented Dec 23, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2018

📌 Commit 2f48f43 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Dec 23, 2018
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2018

⌛ Testing commit 2f48f43 with merge 248d859...
bors-servo added a commit that referenced this pull request Dec 23, 2018
@bors-servo
Auto merge of #22538 - CYBAI:update-sw-container, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
248d859 
Update ServiceWorkerContainer Webidl

Looks like the spec has changed a lot. Maybe it's better to update the implementation for these methods in a separate PR.

Let's just update webidl in this PR?

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of  #19302
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22538)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2018

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: jdm
Pushing 248d859 to master...
@bors-servo bors-servo merged commit 2f48f43 into servo:master Dec 23, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@CYBAI CYBAI deleted the CYBAI:update-sw-container branch Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@CYBAI @highfive @jdm @bors-servo @emilio
You can’t perform that action at this time.