Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ParentNode's querySelector & querySelectorAll on Document, DocumentFragment & Element interfaces #2254

Closed
wants to merge 10 commits into from
Closed

Implement ParentNode's querySelector & querySelectorAll on Document, DocumentFragment & Element interfaces #2254

wants to merge 10 commits into from

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Apr 28, 2014

Spec:
http://dom.spec.whatwg.org/#dom-parentnode-queryselector

Closes #851.
@brunoabinader
Implement TNode for JS<Node>
a094e9b
@brunoabinader
Implement TElement for JS<Element>
d4c367e
@brunoabinader
Added ParentNode.querySelector skeleton
94f30ac
@brunoabinader
Implement Document.querySelector
12ecec0
@brunoabinader
Implement DocumentFragment.querySelector
36d8af1
@brunoabinader
Implement Element.querySelector
63181fb
@brunoabinader
Added ParentNode's querySelector content tests
c98c9ea
@highfive
Copy link

highfive commented Apr 28, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 28, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1408

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@SimonSapin
Copy link
Member

SimonSapin commented Apr 28, 2014

WPT has some relevant tests. Can we run them, with this PR? (Feel free to assign to me new issues for failures in these tests.)
@brunoabinader
Implement support for inheritable interfaces
4d3babd 
Added logic to codegen for interfaces that do not possess JS bindings by
themselves - being the descendants responsible for the JS bindings - so
their implementations can be found. This avoids a bunch of code
duplication (eg. ParentNode's 'children' and 'querySelector' code on
Document/DocumentFragment/Element).
@brunoabinader
Implement ParentNode's querySelectorAll
eb345e5 
This applies for Document, DocumentFragment & Element interfaces.
@brunoabinader
Added ParentNode's querySelectorAll content tests
0786626
@brunoabinader brunoabinader changed the title Implement ParentNode's querySelector on Document, DocumentFragment & Element Implement ParentNode's querySelector & querySelectorAll on Document, DocumentFragment & Element interfaces Apr 30, 2014
@brunoabinader
Copy link
Contributor Author

brunoabinader commented May 2, 2014

@SimonSapin my first run on WPT over selectors-api/ folder gives me the following: level1-all.xht passes, while the following gives timeout (Servo crash): level1-additional.html, level1-baseline.html and tests/submissions/Opera/level2-baseline.html. I still need to verify whether the cause of the crashes are related to querySelector/querySelectorAll implementation.
@metajack
Copy link
Contributor

metajack commented May 2, 2014

This will need a rebase.
@brunoabinader brunoabinader mentioned this pull request Jun 4, 2014
Closed
@brunoabinader brunoabinader deleted the brunoabinader:document-queryselector branch Jun 4, 2014
This was referenced Jun 4, 2014
Closed
Merged
bors-servo pushed a commit that referenced this pull request Jun 6, 2014
bors-servo
auto merge of #2591 : brunoabinader/servo/document-queryselector-v3, …
b5ab5df 
…r=jdm

This is a subtask for #2254 & #2576.

Spec:
http://dom.spec.whatwg.org/#dom-parentnode-queryselector
bors-servo pushed a commit that referenced this pull request Jun 6, 2014
bors-servo
auto merge of #2591 : brunoabinader/servo/document-queryselector-v3, …
b52fbe0 
…r=jdm

This is a subtask for #2254 & #2576.

Spec:
http://dom.spec.whatwg.org/#dom-parentnode-queryselector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement document.querySelectorAll and document.querySelector
5 participants
@brunoabinader @highfive @hoppipolla-critic-bot @SimonSapin @metajack
You can’t perform that action at this time.