Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate ServiceWorker webidl #22540
Merged
Update ServiceWorker webidl #22540
Conversation
highfive
commented
Dec 23, 2018
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 23, 2018
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 23, 2018
Update ServiceWorker webidl About the `void postMessage`, I found the spec doesn't have `[Throws]`; however, as the implementation for `postMessage` in spec, we should have `[Throws]` for it because it will throw errors. Then, I realized that `[Throws]` is not part of standard webidl. Btw, there's a issue discussing about if `[Throws]` should be standardized or not at heycam/webidl#603. Also, per the spec, `ServiceWorker` will `includes` `AbstractWorker` instead of `implements` so I filed #22539 for it. We can update it after the issue is fixed. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 - [x] These changes do not require tests because it just updates the webidl and the changes should have no impact to current implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22540) <!-- Reviewable:end -->
|
|
|
@bors-servo retry #13480 |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 23, 2018
Update ServiceWorker webidl About the `void postMessage`, I found the spec doesn't have `[Throws]`; however, as the implementation for `postMessage` in spec, we should have `[Throws]` for it because it will throw errors. Then, I realized that `[Throws]` is not part of standard webidl. Btw, there's a issue discussing about if `[Throws]` should be standardized or not at heycam/webidl#603. Also, per the spec, `ServiceWorker` will `includes` `AbstractWorker` instead of `implements` so I filed #22539 for it. We can update it after the issue is fixed. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #19302 - [x] These changes do not require tests because it just updates the webidl and the changes should have no impact to current implementation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22540) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CYBAI commentedDec 23, 2018
•
edited by SimonSapin
About the
void postMessage, I found the spec doesn't have[Throws]; however, as the implementation forpostMessagein spec, we should have[Throws]for it because it will throw errors. Then, I realized that[Throws]is not part of standard webidl. Btw, there's a issue discussing about if[Throws]should be standardized or not at heycam/webidl#603.Also, per the spec,
ServiceWorkerwillincludesAbstractWorkerinstead ofimplementsso I filed #22539 for it. We can update it after the issue is fixed../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is