Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servo-tidy.toml #22546

Merged
merged 1 commit into from Dec 24, 2018
Merged

Update servo-tidy.toml #22546

merged 1 commit into from Dec 24, 2018

Conversation

@atouchet
Copy link
Contributor

atouchet commented Dec 24, 2018

rand no longer has a dependency on itself since 0.3 was removed in #22388.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive
Copy link

highfive commented Dec 24, 2018

Heads up! This PR modifies the following files:

@jdm
Copy link
Member

jdm commented Dec 24, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Dec 24, 2018

📌 Commit af83a7b has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Dec 24, 2018

Testing commit af83a7b with merge 9ce3c97...

bors-servo added a commit that referenced this pull request Dec 24, 2018
Update servo-tidy.toml

<!-- Please describe your changes on the following line: -->
rand no longer has a dependency on itself since 0.3 was removed in #22388.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22546)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 24, 2018

@bors-servo bors-servo merged commit af83a7b into servo:master Dec 24, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@atouchet atouchet deleted the atouchet:tidy branch Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.