New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading question mark when constructing URLSearchParams #22553

Merged
merged 1 commit into from Dec 25, 2018

Conversation

Projects
None yet
6 participants
@CYBAI
Copy link
Collaborator

CYBAI commented Dec 25, 2018


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22551
  • There are tests for these changes that I add a new test case for this case

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Dec 25, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/urlsearchparams.rs
  • @KiChjang: components/script/dom/urlsearchparams.rs
@servo-wpt-sync

This comment has been minimized.

Copy link
Collaborator

servo-wpt-sync commented Dec 25, 2018

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#14666.

@CYBAI

This comment has been minimized.

Copy link
Collaborator

CYBAI commented Dec 25, 2018

@bors-servo try=wpt

bors-servo added a commit that referenced this pull request Dec 25, 2018

Auto merge of #22553 - CYBAI:rm-leading-question-mark, r=<try>
Remove leading question mark when constructing URLSearchParams

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22551
- [x] There are tests for these changes that I add a new test case for this case

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22553)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 25, 2018

⌛️ Trying commit 9de8e7a with merge c2d3170...

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 25, 2018

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Dec 25, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 25, 2018

📌 Commit 9de8e7a has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Dec 25, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 25, 2018

⌛️ Testing commit 9de8e7a with merge 5ccd912...

bors-servo added a commit that referenced this pull request Dec 25, 2018

Auto merge of #22553 - CYBAI:rm-leading-question-mark, r=jdm
Remove leading question mark when constructing URLSearchParams

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22551
- [x] There are tests for these changes that I add a new test case for this case

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22553)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 25, 2018

@bors-servo bors-servo merged commit 9de8e7a into servo:master Dec 25, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@CYBAI CYBAI deleted the CYBAI:rm-leading-question-mark branch Dec 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment