script: Implement the HTMLTrackElement API #22563

dlrobertson · 2018-12-26T17:39:20Z

Implement the basics of the HTMLTrackElement and update the wpt tests.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

Fixes: #22313

This change is

highfive · 2018-12-26T17:39:24Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/HTMLTrackElement.webidl, components/script/dom/htmltrackelement.rs
@KiChjang: components/script/dom/webidls/HTMLTrackElement.webidl, components/script/dom/htmltrackelement.rs

dlrobertson · 2018-12-26T17:40:19Z

Some of the async tests for activeCue etc were falsely passing. Updated the test expectations.

dlrobertson · 2018-12-26T17:40:30Z

r? @ferjm

dlrobertson · 2018-12-26T19:55:05Z

Sorry, thought I ran test-tidy. Updated.

ferjm

Excellent!

ferjm · 2018-12-28T09:31:26Z

components/script/dom/htmltrackelement.rs

+    // https://html.spec.whatwg.org/multipage/#dom-track-kind
+    fn Kind(&self) -> DOMString {
+        let element = self.upcast::<Element>();
+        // The the value of "kind" and transform all uppercase


typo: duplicated the. I guess you meant to write "Get the value..."

ferjm · 2018-12-28T09:31:26Z

components/script/dom/htmltrackelement.rs

    ) -> HTMLTrackElement {
        HTMLTrackElement {
            htmlelement: HTMLElement::new_inherited(local_name, prefix, document),
+            ready_state: HTMLTrackElementConstants::NONE,


Could we add an enum like https://github.com/servo/servo/blob/master/components/script/dom/htmlmediaelement.rs#L215 ?

I can definitely add that. In this PR the enum would be mostly unused, since None is the only variant that is currently used.

ferjm · 2018-12-28T09:31:26Z

components/script/dom/htmltrackelement.rs

+    // https://html.spec.whatwg.org/multipage/#dom-track-src
+    make_url_getter!(Src, "src");
+    // https://html.spec.whatwg.org/multipage/#dom-track-src
+    make_url_setter!(SetSrc, "src");


I believe we depend on implementing and using Element::set_url_attribute within make_url_setter to be fully spec compliant here. Could you file a follow up bug to implement this, please?

Yeah, for now make_url_setter is the same as make_setter.

ferjm · 2018-12-28T09:31:45Z

@bors-servo try=wpt

bors-servo · 2018-12-28T09:31:52Z

⌛ Trying commit 235ea4d with merge 27fc007...


        Auto merge of #22563 - dlrobertson:htmltextelement, r=<try>

script: Implement the HTMLTrackElement API Implement the basics of the HTMLTrackElement and update the wpt tests. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes Fixes: #22313  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22563)

bors-servo · 2018-12-28T09:53:01Z

💔 Test failed - linux-rel-css

dlrobertson · 2019-01-01T02:34:59Z

@ferjm Updated

ferjm · 2019-01-07T15:41:46Z

It seems that this makes some tests in /html/infrastructure/urls/dynamic-changes-to-base-urls pass.

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "The 'src' attribute of the 'track' element", 
    "test": "/html/infrastructure/urls/dynamic-changes-to-base-urls/dynamic-urls.sub.html", 
    "line": 94427, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "The 'src' attribute of the 'track' element", 
    "test": "/html/infrastructure/urls/dynamic-changes-to-base-urls/historical.sub.xhtml", 
    "line": 95674, 
    "action": "test_result", 
    "expected": "FAIL"
}

dlrobertson · 2019-01-07T19:28:03Z

These timeouts also might be related to this change. The tests include TextTracks and I don't think the previous PASS was spurious.

{
    "status": "TIMEOUT", 
    "group": "default", 
    "message": "Test timed out", 
    "stack": null, 
    "subtest": "<video autoplay> with <track src=\"invalid://url\" default=\"\"> child", 
    "test": "/html/semantics/embedded-content/media-elements/autoplay-with-broken-track.html", 
    "line": 123088, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "TIMEOUT", 
    "group": "default", 
    "message": "Test timed out", 
    "stack": null, 
    "subtest": "<video autoplay> with <track src=\"404\" default=\"\"> child", 
    "test": "/html/semantics/embedded-content/media-elements/autoplay-with-broken-track.html", 
    "line": 123089, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "TIMEOUT", 
    "group": "default", 
    "message": "Test timed out", 
    "stack": null, 
    "subtest": "<video autoplay> with <track src=\"\" default=\"\"> child", 
    "test": "/html/semantics/embedded-content/media-elements/autoplay-with-broken-track.html", 
    "line": 123090, 
    "action": "test_result", 
    "expected": "PASS"
}

dlrobertson · 2019-01-07T23:30:11Z

@ferjm Updated

ferjm · 2019-01-08T07:59:21Z

@bors-servo r+

bors-servo · 2019-01-08T07:59:22Z

📌 Commit ab787bf has been approved by ferjm

bors-servo · 2019-01-08T08:18:50Z

⌛ Testing commit ab787bf with merge 26ece56...


        Auto merge of #22563 - dlrobertson:htmltextelement, r=ferjm

script: Implement the HTMLTrackElement API Implement the basics of the HTMLTrackElement and update the wpt tests. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes Fixes: #22313  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22563)

bors-servo · 2019-01-08T08:46:10Z

💔 Test failed - linux-rel-wpt

ferjm · 2019-01-08T08:58:20Z

We need to update the expectations for html/dom/interfaces.https.html as well

CYBAI · 2019-01-08T08:58:27Z

Looks like there're more PASSed test cases now :D

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack must be primary interface of document.createElement(\"track\").track", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72018, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Stringification of document.createElement(\"track\").track", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72019, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"kind\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72020, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"label\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72021, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"language\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72022, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"id\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72023, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"mode\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72025, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"cues\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72026, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"addCue(TextTrackCue)\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72028, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: calling addCue(TextTrackCue) on document.createElement(\"track\").track with too few arguments must throw TypeError", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72029, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"removeCue(TextTrackCue)\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72030, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: calling removeCue(TextTrackCue) on document.createElement(\"track\").track with too few arguments must throw TypeError", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72031, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "TextTrack interface: document.createElement(\"track\").track must inherit property \"oncuechange\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 72032, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: attribute kind", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80526, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: attribute src", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80527, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: attribute srclang", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80528, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: attribute label", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80529, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: attribute default", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80530, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant NONE on interface object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80531, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant NONE on interface prototype object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80532, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant LOADING on interface object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80533, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant LOADING on interface prototype object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80534, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant LOADED on interface object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80535, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant LOADED on interface prototype object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80536, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant ERROR on interface object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80537, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: constant ERROR on interface prototype object", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80538, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: attribute readyState", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80539, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: attribute track", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80540, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"kind\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80543, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"src\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80544, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"srclang\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80545, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"label\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80546, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"default\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80547, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"NONE\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80548, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"LOADING\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80549, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"LOADED\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80550, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"ERROR\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80551, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"readyState\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80552, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "HTMLTrackElement interface: document.createElement(\"track\") must inherit property \"track\" with the proper type", 
    "test": "/html/dom/interfaces.https.html?include=HTML.*", 
    "line": 80553, 
    "action": "test_result", 
    "expected": "FAIL"
}


        script: Implement the HTMLTrackElement API

Implement the basics of the HTMLTrackElement and update the wpt tests.

dlrobertson · 2019-01-08T13:33:39Z

@ferjm @CYBAI thanks, updated the html/dom/interfaces.https.html test expectations.

ferjm · 2019-01-08T14:00:54Z

@bors-servo r+

bors-servo · 2019-01-08T14:00:55Z

📌 Commit c480207 has been approved by ferjm

bors-servo · 2019-01-08T14:15:23Z

⌛ Testing commit c480207 with merge 7c8de38...


        Auto merge of #22563 - dlrobertson:htmltextelement, r=ferjm

script: Implement the HTMLTrackElement API Implement the basics of the HTMLTrackElement and update the wpt tests. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes Fixes: #22313  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22563)

bors-servo · 2019-01-08T15:44:04Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: ferjm
Pushing 7c8de38 to master...

highfive assigned asajeffrey Dec 26, 2018

highfive added the S-awaiting-review label Dec 26, 2018

highfive assigned ferjm and unassigned asajeffrey Dec 26, 2018

dlrobertson force-pushed the dlrobertson:htmltextelement branch from c32d063 to 235ea4d Dec 26, 2018

ferjm added this to In progress in Media playback Dec 27, 2018

ferjm approved these changes Dec 28, 2018

View changes

highfive added the S-tests-failed label Dec 28, 2018

dlrobertson mentioned this pull request Dec 28, 2018

Implement Element::set_url_attribute #22568

Closed

dlrobertson force-pushed the dlrobertson:htmltextelement branch from 235ea4d to b9f06d6 Jan 1, 2019

highfive removed the S-tests-failed label Jan 1, 2019

ferjm added S-needs-code-changes and removed S-awaiting-review labels Jan 7, 2019

dlrobertson force-pushed the dlrobertson:htmltextelement branch from b9f06d6 to ab787bf Jan 7, 2019

highfive added S-awaiting-review and removed S-needs-code-changes labels Jan 7, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 8, 2019

ferjm mentioned this pull request Jan 8, 2019

Implement HTMLMediaElement muted and defaultMuted attributes #22347

Merged

4 of 4 tasks complete

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 8, 2019

dlrobertson force-pushed the dlrobertson:htmltextelement branch from ab787bf to c480207 Jan 8, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Jan 8, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 8, 2019

Media playback automation moved this from In progress to Done Jan 8, 2019

highfive removed the S-awaiting-merge label Jan 8, 2019

dlrobertson deleted the dlrobertson:htmltextelement branch Jan 8, 2019

servo / servo

script: Implement the HTMLTrackElement API #22563

script: Implement the HTMLTrackElement API #22563

dlrobertson commented Dec 26, 2018 •

edited

highfive commented Dec 26, 2018

dlrobertson commented Dec 26, 2018

dlrobertson commented Dec 26, 2018

dlrobertson commented Dec 26, 2018

ferjm left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ferjm commented Dec 28, 2018

bors-servo commented Dec 28, 2018

bors-servo commented Dec 28, 2018

dlrobertson commented Jan 1, 2019

ferjm commented Jan 7, 2019

dlrobertson commented Jan 7, 2019 •

edited

dlrobertson commented Jan 7, 2019

ferjm commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

ferjm commented Jan 8, 2019

CYBAI commented Jan 8, 2019

dlrobertson commented Jan 8, 2019

ferjm commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

servo / servo

Join GitHub today

script: Implement the HTMLTrackElement API #22563

script: Implement the HTMLTrackElement API #22563

Conversation

dlrobertson commented Dec 26, 2018 • edited

highfive commented Dec 26, 2018

dlrobertson commented Dec 26, 2018

dlrobertson commented Dec 26, 2018

dlrobertson commented Dec 26, 2018

ferjm left a comment

This comment has been minimized.

ferjm Dec 28, 2018

This comment has been minimized.

dlrobertson Dec 28, 2018

This comment has been minimized.

ferjm Dec 28, 2018

This comment has been minimized.

dlrobertson Dec 28, 2018

This comment has been minimized.

ferjm Dec 28, 2018

This comment has been minimized.

dlrobertson Dec 28, 2018

ferjm commented Dec 28, 2018

bors-servo commented Dec 28, 2018

bors-servo commented Dec 28, 2018

dlrobertson commented Jan 1, 2019

ferjm commented Jan 7, 2019

dlrobertson commented Jan 7, 2019 • edited

dlrobertson commented Jan 7, 2019

ferjm commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

ferjm commented Jan 8, 2019

CYBAI commented Jan 8, 2019

dlrobertson commented Jan 8, 2019

ferjm commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

bors-servo commented Jan 8, 2019

dlrobertson commented Dec 26, 2018 •

edited

dlrobertson commented Jan 7, 2019 •

edited