New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing build dependencies for openSUSE #22569

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
5 participants
@IlyaBizyaev
Copy link
Contributor

IlyaBizyaev commented Dec 28, 2018

GStreamer development packages and Autotools 2.13 are required for a successful build of servo on openSUSE Linux.
This commit adds missing dependencies (compare with e.g. Fedora and Arch).


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because they only affect documentation

This change is Reviewable

Add missing build dependencies for openSUSE
GStreamer 1.0 and Autotools 2.13 are required for a successful build of servo on openSUSE Linux
@highfive

This comment has been minimized.

Copy link

highfive commented Dec 28, 2018

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.

@ferjm

This comment has been minimized.

Copy link
Member

ferjm commented Dec 28, 2018

Thanks!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

📌 Commit a1dd938 has been approved by ferjm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

⌛️ Testing commit a1dd938 with merge f39e13a...

bors-servo added a commit that referenced this pull request Dec 28, 2018

Auto merge of #22569 - IlyaBizyaev:add-opensuse-depends, r=ferjm
Add missing build dependencies for openSUSE

<!-- Please describe your changes on the following line: -->
GStreamer development packages and Autotools 2.13 are required for a successful build of servo on openSUSE Linux.
This commit adds missing dependencies (compare with e.g. Fedora and Arch).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only affect documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22569)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

💔 Test failed - linux-rel-wpt

@ferjm

This comment has been minimized.

Copy link
Member

ferjm commented Dec 28, 2018

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

⌛️ Testing commit a1dd938 with merge 00c0341...

bors-servo added a commit that referenced this pull request Dec 28, 2018

Auto merge of #22569 - IlyaBizyaev:add-opensuse-depends, r=ferjm
Add missing build dependencies for openSUSE

<!-- Please describe your changes on the following line: -->
GStreamer development packages and Autotools 2.13 are required for a successful build of servo on openSUSE Linux.
This commit adds missing dependencies (compare with e.g. Fedora and Arch).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only affect documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22569)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Dec 28, 2018

@bors-servo bors-servo merged commit a1dd938 into servo:master Dec 28, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment