Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing build dependencies for openSUSE #22569

Merged
merged 1 commit into from Dec 28, 2018

Conversation

IlyaBizyaev
Copy link
Contributor

@IlyaBizyaev IlyaBizyaev commented Dec 28, 2018

GStreamer development packages and Autotools 2.13 are required for a successful build of servo on openSUSE Linux.
This commit adds missing dependencies (compare with e.g. Fedora and Arch).


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because they only affect documentation

This change is Reviewable

GStreamer 1.0 and Autotools 2.13 are required for a successful build of servo on openSUSE Linux
@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 28, 2018
@ferjm
Copy link
Contributor

ferjm commented Dec 28, 2018

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a1dd938 has been approved by ferjm

@highfive highfive assigned ferjm and unassigned paulrouget Dec 28, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 28, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit a1dd938 with merge f39e13a...

bors-servo pushed a commit that referenced this pull request Dec 28, 2018
Add missing build dependencies for openSUSE

<!-- Please describe your changes on the following line: -->
GStreamer development packages and Autotools 2.13 are required for a successful build of servo on openSUSE Linux.
This commit adds missing dependencies (compare with e.g. Fedora and Arch).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only affect documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22569)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 28, 2018
@ferjm
Copy link
Contributor

ferjm commented Dec 28, 2018

@bors-servo
Copy link
Contributor

⌛ Testing commit a1dd938 with merge 00c0341...

bors-servo pushed a commit that referenced this pull request Dec 28, 2018
Add missing build dependencies for openSUSE

<!-- Please describe your changes on the following line: -->
GStreamer development packages and Autotools 2.13 are required for a successful build of servo on openSUSE Linux.
This commit adds missing dependencies (compare with e.g. Fedora and Arch).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they only affect documentation

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22569)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 28, 2018
@bors-servo
Copy link
Contributor

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: ferjm
Pushing 00c0341 to master...

@bors-servo bors-servo merged commit a1dd938 into servo:master Dec 28, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants