Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webrender #22598

Merged
merged 3 commits into from Jan 18, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Update webrender.

  • Loading branch information
jdm committed Jan 17, 2019
commit 9f855ae8473c225ee007d4e5be74268d643c4d2e

Large diffs are not rendered by default.

@@ -63,5 +63,5 @@ servo-fontconfig = "0.2.1"
xml5ever = {version = "0.12"}

[target.'cfg(target_os = "windows")'.dependencies]
dwrote = "0.6"
dwrote = "0.7"
truetype = "0.26"

Large diffs are not rendered by default.

@@ -859,8 +859,6 @@ malloc_size_of_is_0!(webrender_api::BorderStyle);
#[cfg(feature = "webrender_api")]
malloc_size_of_is_0!(webrender_api::BoxShadowClipMode);
#[cfg(feature = "webrender_api")]
malloc_size_of_is_0!(webrender_api::ClipAndScrollInfo);
#[cfg(feature = "webrender_api")]
malloc_size_of_is_0!(webrender_api::ColorF);
#[cfg(feature = "webrender_api")]
malloc_size_of_is_0!(webrender_api::ComplexClipRegion);
@@ -122,16 +122,16 @@ impl PipelineId {
}
}

pub fn root_scroll_node(&self) -> webrender_api::ClipId {
webrender_api::ClipId::root_scroll_node(self.to_webrender())
pub fn root_scroll_node(&self) -> webrender_api::SpatialId {
webrender_api::SpatialId::root_scroll_node(self.to_webrender())
}

pub fn root_scroll_id(&self) -> webrender_api::ExternalScrollId {
webrender_api::ExternalScrollId(0, self.to_webrender())
}

pub fn root_clip_and_scroll_info(&self) -> webrender_api::ClipAndScrollInfo {
webrender_api::ClipAndScrollInfo::simple(self.root_scroll_node())
pub fn root_clip_node(&self) -> webrender_api::ClipId {
webrender_api::ClipId::root(self.to_webrender())
}
}

@@ -20,6 +20,7 @@ googlevr = ["webvr/googlevr"]
js_backtrace = ["script/js_backtrace"]
native-bluetooth = ["bluetooth/native-bluetooth"]
webrender_debugger = ["webrender/debugger"]
no_static_freetype = ["webrender/no_static_freetype"]
oculusvr = ["webvr/oculusvr"]
unstable = [
"euclid/unstable",
@@ -14,7 +14,7 @@ bench = false

[dependencies]
keyboard-types = "0.4"
libservo = { path = "../../components/servo" }
libservo = { path = "../../components/servo", features = ["no_static_freetype"] }
log = "0.4"
servo-egl = "0.2"
smallvec = "0.6"
@@ -36,6 +36,7 @@ energy-profiling = ["libservo/energy-profiling"]
debugmozjs = ["libservo/debugmozjs"]
unstable = ["libservo/unstable"]
webgl_backtrace = ["libservo/webgl_backtrace"]
webrender_debugger = ["libservo/webrender_debugger"]
js_backtrace = ["libservo/js_backtrace"]

[target.'cfg(not(target_os = "android"))'.dependencies]
@@ -32,9 +32,14 @@ rand = [
[ignore]
# Ignored packages with duplicated versions
packages = [
"base64",
This conversation was marked as resolved by nox

This comment has been minimized.

Copy link
@Eijebong

This comment has been minimized.

Copy link
@nox

nox Jan 8, 2019

Member

@pcwalton AFAIK WR depends on sha, base64 etc only to fingerprint its own shaders, right? Could we use a less fancy hash algo that bring 5 other crates?

This comment has been minimized.

Copy link
@pcwalton

pcwalton Jan 8, 2019

Contributor

This is a question for @gw3583

This comment has been minimized.

Copy link
@gw3583

gw3583 Jan 8, 2019

Contributor

This sounds like it would add complexity to WR - e.g. the shader cache would now have to encode which type of hash it's using etc.

"block-buffer",
"byte-tools",
"crossbeam-deque",
"crossbeam-epoch",
"crossbeam-utils",
"digest",
"generic-array",
"rand",
"unicase",
"winapi",

This file was deleted.

This file was deleted.

@@ -0,0 +1,2 @@
[blur-clip-stacking-context-001.html]
expected: FAIL
@@ -1,6 +1,4 @@
[setrequestheader-header-allowed.htm]
type: testharness
expected: CRASH
bug: https://github.com/hyperium/http/pull/271
[XMLHttpRequest: setRequestHeader() - headers that are allowed (Status-URI)]
expected: FAIL
@@ -1,4 +1,6 @@
[to-data-url-test.html]
expected:
if os == "linux": CRASH
[WebGL test #12: should be 0,255,0,255\nat (0, 0) expected: 0,255,0,255 was 255,0,0,255]
expected: FAIL

@@ -1,4 +1,6 @@
[texture-size-cube-maps.html]
expected:
if os == "linux": CRASH
[WebGL test #87: 0, 0, 2, 1 should be green\nat (0, 0) expected: 0,255,0,255 was 0,255,255,255]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.