New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement performance interface extension for PerformanceResourceTiming #22599

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
7 participants
@aditj
Copy link
Contributor

aditj commented Jan 3, 2019

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22307 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 3, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 3, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/Performance.webidl, components/script/dom/performance.rs
  • @KiChjang: components/script/dom/webidls/Performance.webidl, components/script/dom/performance.rs
@highfive

This comment has been minimized.

Copy link

highfive commented Jan 3, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm jdm assigned ferjm and unassigned asajeffrey Jan 3, 2019

@aditj

This comment has been minimized.

Copy link
Contributor Author

aditj commented Jan 4, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

There are web platform tests for the changes,the code has been tested, the expectation log has been updated accordingly .

Show resolved Hide resolved components/script/dom/performance.rs Outdated
Show resolved Hide resolved components/script/dom/performance.rs Outdated
Show resolved Hide resolved components/script/dom/performance.rs Outdated

@aditj aditj force-pushed the aditj:patch-1-re branch 2 times, most recently from ba8ccb3 to 0ae5106 Jan 8, 2019

@ferjm

ferjm approved these changes Jan 8, 2019

Copy link
Member

ferjm left a comment

Looks good. Thanks!

Please, reword the commit message to something more meaningful:

git commit --amend -m "Implement performance interface extension for PerformanceResourceTiming "

@aditj aditj force-pushed the aditj:patch-1-re branch from 0ae5106 to fd78dc3 Jan 8, 2019

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Jan 8, 2019

@bors-servo r=ferjm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

📌 Commit fd78dc3 has been approved by ferjm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

⌛️ Testing commit fd78dc3 with merge 0ce2c26...

bors-servo added a commit that referenced this pull request Jan 8, 2019

Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 8, 2019

💔 Test failed - linux-rel-css

@CYBAI

This comment has been minimized.

Copy link
Collaborator

CYBAI commented Jan 8, 2019

Need to update the test expectation

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "performance.clearResourceTimings in workers", 
    "test": "/workers/worker-performance.worker.html", 
    "line": 168398, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "performance.setResourceTimingBufferSize in workers", 
    "test": "/workers/worker-performance.worker.html", 
    "line": 168399, 
    "action": "test_result", 
    "expected": "FAIL"
}
@aditj

This comment has been minimized.

Copy link
Contributor Author

aditj commented Jan 8, 2019

Need to update the test expectation

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "performance.clearResourceTimings in workers", 
    "test": "/workers/worker-performance.worker.html", 
    "line": 168398, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "performance.setResourceTimingBufferSize in workers", 
    "test": "/workers/worker-performance.worker.html", 
    "line": 168399, 
    "action": "test_result", 
    "expected": "FAIL"
}

Manually? Shouldnt the update-wpt command do that on its own?

@CYBAI

This comment has been minimized.

Copy link
Collaborator

CYBAI commented Jan 8, 2019

Yeah, you can update the expectations via update-wpt.

$ ./mach test-wpt --log-raw=update.log tests/wpt/web-platform-tests/workers/worker-performance.worker.js
$ ./mach update-wpt update.log

@aditj aditj force-pushed the aditj:patch-1-re branch from fd78dc3 to b9e1535 Jan 8, 2019

update.log Outdated
@@ -0,0 +1,108 @@
{"thread": "MainThread", "level": "DEBUG", "pid": 28315, "component": "vcs", "source": "web-platform-tests", "time": 1546971347685, "action": "log", "message": "git rev-parse --show-toplevel"}

This comment has been minimized.

@jdm

jdm Jan 8, 2019

Member

Please remove this file.

@aditj aditj force-pushed the aditj:patch-1-re branch from b9e1535 to 3ca8247 Jan 8, 2019

@ferjm

This comment has been minimized.

Copy link
Member

ferjm commented Jan 10, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

📌 Commit 3ca8247 has been approved by ferjm

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

⌛️ Testing commit 3ca8247 with merge fd94b76...

bors-servo added a commit that referenced this pull request Jan 10, 2019

Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

💔 Test failed - mac-rel-wpt3

@ferjm

This comment has been minimized.

Copy link
Member

ferjm commented Jan 10, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

⌛️ Testing commit 3ca8247 with merge 4d2cdea...

bors-servo added a commit that referenced this pull request Jan 10, 2019

Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

💔 Test failed - linux-rel-css

@ferjm

This comment has been minimized.

Copy link
Member

ferjm commented Jan 10, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

⌛️ Testing commit 3ca8247 with merge 106f137...

bors-servo added a commit that referenced this pull request Jan 10, 2019

Auto merge of #22599 - aditj:patch-1-re, r=ferjm
Implement performance interface extension for PerformanceResourceTiming

<!-- Please describe your changes on the following line: -->

(There is a previous closed pull for this #22431)
Implemented the following :
a) Added the maxSize Field to the PerformanceEntryList structure.
b) Implemented the clearResourceTimings, setResourceTimingBufferSize, onresourcetimingbufferfull fuctions for the Performance Structure according to the Interface Specification given at : https://w3c.github.io/resource-timing/#sec-extensions-performance-interface

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22307 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22599)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 10, 2019

@bors-servo bors-servo merged commit 3ca8247 into servo:master Jan 10, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment