Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #22623

Closed
wants to merge 0 commits into from
Closed

Comments #22623

wants to merge 0 commits into from

Conversation

@aditj
Copy link
Contributor

aditj commented Jan 5, 2019 •
edited by SimonSapin

Added comments to clarify layout-thread exit workflow (Specifically when will a Exit message be received )

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22475 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because only comments are added.

This change is Reviewable
@highfive
Copy link

highfive commented Jan 5, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.
@highfive
Copy link

highfive commented Jan 5, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/performance.rs, components/script/dom/webidls/Performance.webidl
  • @KiChjang: components/script/dom/performance.rs, components/script/dom/webidls/Performance.webidl
@KiChjang
Copy link
Member

KiChjang commented Jan 5, 2019

This PR contains commits that are from #22431. Could you please remove them?
@aditj
Copy link
Contributor Author

aditj commented Jan 5, 2019 •
edited

@KiChjang Can you help me do that?
@gterzian
gterzian reviewed Jan 6, 2019
View changes
components/layout_thread/lib.rs Outdated
@@ -789,6 +789,7 @@ impl LayoutThread {
self.prepare_to_exit(response_chan);
return false;
},
//Recieving the Exit message at this stage only happens when layout is undergoing a "force exit".

This comment has been minimized.

Sign in to view
@gterzian

gterzian Jan 6, 2019

Member

nit: Typo and lack of leading space, should be // Receiving
@gterzian
Copy link
Member

gterzian commented Jan 6, 2019

git rebase -i HEAD~3, and comment out the commits that you want to remove by adding a # in front of them. That is assuming you want to remove those commits from this branch.
@aditj aditj force-pushed the aditj:comments branch 2 times, most recently from f2a1991 to 31f207a Jan 6, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 6, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1546763031224.
@aditj aditj force-pushed the aditj:comments branch 2 times, most recently from f2a1991 to a0b4dd0 Jan 6, 2019
@aditj aditj closed this Jan 6, 2019
@aditj aditj force-pushed the aditj:comments branch from a0b4dd0 to 1753cda Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gterzian gterzian

Assignees

@paulrouget paulrouget

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Clarify Layout-thread exit workflow
6 participants
@aditj @highfive @KiChjang @gterzian @servo-wpt-sync @paulrouget
You can’t perform that action at this time.